bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95

// SC2321: This && is not a logical AND but part of [[ ]]
use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static AND_OUTSIDE_BRACKET: std::sync::LazyLock<Regex> =
    std::sync::LazyLock::new(|| Regex::new(r"\]\]\s*&&\s*\[\[").unwrap());

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();
    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;
        if line.trim_start().starts_with('#') {
            continue;
        }

        if AND_OUTSIDE_BRACKET.is_match(line) {
            let diagnostic = Diagnostic::new(
                "SC2321",
                Severity::Info,
                "Use [[ condition && condition ]] instead of [[ condition ]] && [[ condition ]]"
                    .to_string(),
                Span::new(line_num, 1, line_num, line.len() + 1),
            );
            result.add(diagnostic);
        }
    }
    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2321_separate_conditions() {
        let code = "[[ $x -eq 1 ]] && [[ $y -eq 2 ]]";
        assert_eq!(check(code).diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2321_combined_ok() {
        let code = "[[ $x -eq 1 && $y -eq 2 ]]";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2321_command_ok() {
        let code = "[[ $x -eq 1 ]] && echo ok";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2321_comment() {
        let code = "# [[ $x ]] && [[ $y ]]";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2321_empty() {
        assert_eq!(check("").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2321_normal() {
        assert_eq!(check("echo test").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2321_single_bracket_ok() {
        let code = "[ $x -eq 1 ] && [ $y -eq 2 ]";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2321_or_operator_ok() {
        let code = "[[ $x -eq 1 ]] || [[ $y -eq 2 ]]";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2321_three_conditions() {
        let code = "[[ $a ]] && [[ $b ]] && [[ $c ]]";
        // Should match first instance
        assert_eq!(check(code).diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2321_multiline() {
        let code = r#"
[[ $x -eq 1 ]] &&
[[ $y -eq 2 ]]
"#;
        assert_eq!(check(code).diagnostics.len(), 0);
    }
}