bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125

// SC2180: Bash doesn't support multidimensional arrays. Use associative arrays.
//
// Bash only supports 1D arrays. Multidimensional access won't work.
//
// Examples:
// Bad:
//   array[0][1]=value            // Not supported
//   echo "${array[0][1]}"        // Won't work
//
// Good:
//   declare -A array             // Associative array
//   array["0,1"]=value           // Use key like "row,col"
//   echo "${array["0,1"]}"       // Access with key
//
// Impact: Syntax error or unexpected behavior

use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static MULTIDIM_ARRAY: std::sync::LazyLock<Regex> =
    std::sync::LazyLock::new(|| Regex::new(r"\[\d+\]\[\d+\]").unwrap());

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();

    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;

        if line.trim_start().starts_with('#') {
            continue;
        }

        for mat in MULTIDIM_ARRAY.find_iter(line) {
            let start_col = mat.start() + 1;
            let end_col = mat.end() + 1;

            let diagnostic = Diagnostic::new(
                "SC2180",
                Severity::Error,
                "Bash doesn't support multidimensional arrays. Use associative arrays".to_string(),
                Span::new(line_num, start_col, line_num, end_col),
            );

            result.add(diagnostic);
        }
    }

    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2180_multidim_access() {
        let code = r#"echo "${array[0][1]}""#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2180_multidim_assignment() {
        let code = "array[0][1]=value";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2180_single_dim_ok() {
        let code = r#"echo "${array[0]}""#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2180_assoc_array_ok() {
        let code = r#"declare -A array; array["0,1"]=value"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2180_comment_ok() {
        let code = "# array[0][1]=value";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2180_multiple() {
        let code = "array[0][1]=a\narray[2][3]=b";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 2);
    }

    #[test]
    fn test_sc2180_higher_dimensions() {
        let code = "array[0][1][2]=value";
        let result = check(code);
        // Matches [0][1]
        assert!(!result.diagnostics.is_empty());
    }

    #[test]
    fn test_sc2180_nested_var_ok() {
        let code = r#"echo "${array[${index}]}""#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2180_arithmetic_ok() {
        let code = "result=$((array[0] + array[1]))";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2180_matrix_access() {
        let code = "value=${matrix[5][10]}";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
}