bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97

// SC2206: Quote to prevent word splitting/globbing in arrays
use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static UNQUOTED_ARRAY_EXPANSION: std::sync::LazyLock<Regex> = std::sync::LazyLock::new(|| {
    // Match array=($var) or array=($(cmd)) or array=($a $b) without quotes
    Regex::new(r"\w+\s*=\s*\([^)]*\$").unwrap()
});

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();
    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;
        if line.trim_start().starts_with('#') {
            continue;
        }

        if UNQUOTED_ARRAY_EXPANSION.is_match(line) {
            // Exclude if already quoted: array=("$var")
            if !line.contains("(\"$") && !line.contains("(\"$(") {
                let diagnostic = Diagnostic::new(
                    "SC2206",
                    Severity::Warning,
                    "Quote to prevent word splitting/globbing in arrays. Use array=(\"$var\") or mapfile".to_string(),
                    Span::new(line_num, 1, line_num, line.len() + 1),
                );
                result.add(diagnostic);
            }
        }
    }
    result
}

#[cfg(test)]
mod tests {
    use super::*;
    #[test]
    fn test_sc2206_unquoted_var() {
        let code = r#"array=($var)"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2206_unquoted_cmdsub() {
        let code = r#"files=$(ls *.txt)"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0); // Not array assignment
    }
    #[test]
    fn test_sc2206_quoted_ok() {
        let code = r#"array=("$var")"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2206_literal_ok() {
        let code = r#"array=(one two three)"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2206_expansion_in_array() {
        let code = r#"arr=($VAR)"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2206_braced_var() {
        let code = r#"array=(${items})"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2206_cmdsub_in_array() {
        let code = r#"array=($(find . -name "*.txt"))"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2206_multiple_vars() {
        let code = r#"arr=($a $b $c)"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2206_quoted_cmdsub_ok() {
        let code = r#"array=("$(get_items)")"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2206_comment_skipped() {
        let code = r#"# array=($var)"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
}