bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90

// SC2288: Prefer always true/false over [ 1 = 1 ]
use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static TAUTOLOGY: std::sync::LazyLock<Regex> =
    std::sync::LazyLock::new(|| Regex::new(r"\[\s+(1\s*=\s*1|true\s*=\s*true)\s*\]").unwrap());

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();
    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;
        if line.trim_start().starts_with('#') {
            continue;
        }

        if TAUTOLOGY.is_match(line) {
            let diagnostic = Diagnostic::new(
                "SC2288",
                Severity::Info,
                "Use 'true' or 'false' directly instead of [ 1 = 1 ]".to_string(),
                Span::new(line_num, 1, line_num, line.len() + 1),
            );
            result.add(diagnostic);
        }
    }
    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2288_one_equals_one() {
        let code = "[ 1 = 1 ]";
        assert_eq!(check(code).diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2288_true_command_ok() {
        let code = "if true; then";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2288_comment() {
        let code = "# [ 1 = 1 ]";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2288_empty() {
        assert_eq!(check("").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2288_normal() {
        assert_eq!(check("echo test").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2288_variable_comparison_ok() {
        let code = "[ $x = 1 ]";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2288_two_equals_two_ok() {
        let code = "[ 2 = 2 ]";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2288_false_ok() {
        let code = "if false; then";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2288_true_equals_true() {
        let code = "[ true = true ]";
        assert_eq!(check(code).diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2288_colon_ok() {
        let code = ": # no-op";
        assert_eq!(check(code).diagnostics.len(), 0);
    }
}