bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143

// SC2107: Instead of [ a && b ], use [ a ] && [ b ]
//
// Detects usage of && or || inside single brackets, which is not POSIX-compliant.
// In POSIX shell, use separate test commands with shell && or ||.
//
// Examples:
// Bad:
//   if [ "$a" = "1" && "$b" = "2" ]; then
//
// Good:
//   if [ "$a" = "1" ] && [ "$b" = "2" ]; then

use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static LOGICAL_IN_SINGLE_BRACKET: std::sync::LazyLock<Regex> = std::sync::LazyLock::new(|| {
    // Match [ ... && ... ] or [ ... || ... ]
    Regex::new(r"\[\s+[^\]]*(?:&&|\|\|)[^\]]*\]").unwrap()
});

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();

    for (i, line) in source.lines().enumerate() {
        let line_num = i + 1;

        // Skip comments
        if line.trim_start().starts_with('#') {
            continue;
        }

        // Skip double brackets [[ ]]
        if line.contains("[[") {
            continue;
        }

        // Detect && or || inside single brackets
        if let Some(mat) = LOGICAL_IN_SINGLE_BRACKET.find(line) {
            let start_col = mat.start() + 1;
            let end_col = mat.end() + 1;

            let operator = if mat.as_str().contains("&&") {
                "&&"
            } else {
                "||"
            };

            let diagnostic = Diagnostic::new(
                "SC2107",
                Severity::Error,
                format!(
                    "Use separate test commands: [ a ] {} [ b ] instead of [ a {} b ]",
                    operator, operator
                ),
                Span::new(line_num, start_col, line_num, end_col),
            );

            result.add(diagnostic);
        }
    }

    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2107_and_in_single_bracket() {
        let code = r#"if [ "$a" = "1" && "$b" = "2" ]; then"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
        assert_eq!(result.diagnostics[0].code, "SC2107");
        assert_eq!(result.diagnostics[0].severity, Severity::Error);
        assert!(result.diagnostics[0].message.contains("&&"));
    }

    #[test]
    fn test_sc2107_or_in_single_bracket() {
        let code = r#"if [ "$a" = "1" || "$b" = "2" ]; then"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
        assert!(result.diagnostics[0].message.contains("||"));
    }

    #[test]
    fn test_sc2107_separate_tests_ok() {
        let code = r#"if [ "$a" = "1" ] && [ "$b" = "2" ]; then"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2107_double_bracket_ok() {
        let code = r#"if [[ "$a" = "1" && "$b" = "2" ]]; then"#;
        let result = check(code);
        // Double brackets allow && (bash extension)
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2107_single_test_ok() {
        let code = r#"if [ "$a" = "1" ]; then"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2107_complex_condition() {
        let code = r#"if [ "$a" -eq 1 && "$b" -gt 2 ]; then"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2107_file_tests() {
        let code = r#"if [ -f "$file1" && -r "$file2" ]; then"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2107_negation_ok() {
        let code = r#"if [ ! -f "$file" ]; then"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2107_no_test_command() {
        let code = r#"echo "test && test""#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2107_multiple_ands() {
        let code = r#"if [ "$a" = "1" && "$b" = "2" && "$c" = "3" ]; then"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
}