bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
//! SC2154 Pure Logic - Variable reference validation
//!
//! Extracted for EXTREME TDD testability.

use regex::Regex;
use std::collections::HashSet;

/// Get set of built-in/environment variables to skip
/// This includes POSIX standard variables and bash-specific builtins
pub fn get_builtins() -> HashSet<&'static str> {
    [
        // POSIX standard environment variables
        "HOME",
        "PATH",
        "PWD",
        "USER",
        "SHELL",
        "TERM",
        "LANG",
        "LC_ALL",
        "OLDPWD",
        "IFS",
        "OPTARG",
        "OPTIND",
        "PPID",
        "CDPATH",
        "MAILCHECK",
        "PS1",
        "PS2",
        "PS3",
        "PS4",
        "ENV",
        "FCEDIT",
        "HISTFILE",
        "HISTSIZE",
        "MAIL",
        "MAILPATH",
        "NLSPATH",
        "TMOUT",
        "COLUMNS",
        "LINES",
        // Bash specific - User/System info
        "EUID",
        "UID",
        "GROUPS",
        "HOSTNAME",
        "HOSTTYPE",
        "OSTYPE",
        "MACHTYPE",
        // Bash specific - Version info
        "BASH",
        "BASH_VERSION",
        "BASH_VERSINFO",
        "BASH_SUBSHELL",
        "BASHPID",
        // Bash specific - Special runtime variables
        "RANDOM",
        "SECONDS",
        "LINENO",
        "SHLVL",
        "REPLY",
        "EPOCHSECONDS",
        "EPOCHREALTIME",
        "SRANDOM",
        // Bash specific - Function/script context
        "FUNCNAME",
        "BASH_SOURCE",
        "BASH_LINENO",
        "FUNCNEST",
        // Bash specific - Command/execution context
        "BASH_COMMAND",
        "BASH_EXECUTION_STRING",
        "BASH_ARGC",
        "BASH_ARGV",
        "BASH_ARGV0",
        "BASH_REMATCH",
        "MAPFILE",
        "READLINE_LINE",
        "READLINE_POINT",
        "READLINE_MARK",
        // Bash specific - Pipeline/job status
        "PIPESTATUS",
        // Bash specific - Completion
        "COMP_WORDS",
        "COMP_CWORD",
        "COMP_LINE",
        "COMP_POINT",
        "COMP_TYPE",
        "COMP_KEY",
        "COMPREPLY",
        // Bash specific - Options
        "SHELLOPTS",
        "BASHOPTS",
        "BASH_COMPAT",
        // Bash specific - History
        "HISTCMD",
        "HISTCONTROL",
        "HISTIGNORE",
        "HISTTIMEFORMAT",
        // Bash specific - Directory stack
        "DIRSTACK",
        // Bash specific - Coprocesses
        "COPROC",
        // Common environment variables (widely used)
        "TMPDIR",
        "TEMP",
        "TMP",
        "EDITOR",
        "VISUAL",
        "PAGER",
        "BROWSER",
        "DISPLAY",
        "XAUTHORITY",
        "DBUS_SESSION_BUS_ADDRESS",
        "XDG_CONFIG_HOME",
        "XDG_DATA_HOME",
        "XDG_CACHE_HOME",
        "XDG_RUNTIME_DIR",
        "XDG_SESSION_TYPE",
        "XDG_CURRENT_DESKTOP",
        "LOGNAME",
        "HOSTNAME",
        "HOSTFILE",
        "INPUTRC",
        // Terminal/locale
        "COLORTERM",
        "TERM_PROGRAM",
        "LC_CTYPE",
        "LC_MESSAGES",
        "LC_NUMERIC",
        "LC_TIME",
        "LC_COLLATE",
        "LC_MONETARY",
    ]
    .iter()
    .copied()
    .collect()
}

/// Check if variable is special or builtin (should be skipped)
pub fn is_special_or_builtin(var_name: &str, builtins: &HashSet<&str>) -> bool {
    // Skip if in builtins
    if builtins.contains(var_name) {
        return true;
    }

    // Skip numeric variables (positional parameters)
    if var_name.chars().all(|c| c.is_ascii_digit()) {
        return true;
    }

    // Skip special variables
    if ["@", "*", "#", "?", "$", "!", "0", "-"].contains(&var_name) {
        return true;
    }

    false
}

/// Check if script sources external files
/// If source/. commands are found, we're more lenient with undefined variables
pub fn has_source_commands(source: &str) -> bool {
    for line in source.lines() {
        let trimmed = line.trim();
        if trimmed.starts_with('#') {
            continue;
        }
        // Match: source file, . file, source "file", . "file"
        if trimmed.starts_with("source ") || trimmed.starts_with(". ") {
            return true;
        }
        // Also check for source/. after semicolon or &&/||
        if trimmed.contains("; source ")
            || trimmed.contains("; . ")
            || trimmed.contains("&& source ")
            || trimmed.contains("&& . ")
            || trimmed.contains("|| source ")
            || trimmed.contains("|| . ")
        {
            return true;
        }
    }
    false
}

/// Check if line is a comment
pub fn is_comment_line(line: &str) -> bool {
    line.trim_start().starts_with('#')
}

/// Check if variable is all uppercase (likely environment var)
pub fn is_uppercase_var(var_name: &str) -> bool {
    var_name.chars().all(|c| c.is_uppercase() || c == '_')
}

/// Check if a variable reference uses parameter expansion operators
/// ${VAR:-}, ${VAR:=}, ${VAR:+}, ${VAR:?} are intentional patterns
/// that should not trigger "undefined variable" warnings
///
/// Issue #132: Variables like ${BASHRS_TEST:-} are intentional env var checks
pub fn is_parameter_expansion_with_operator(line: &str, match_end: usize) -> bool {
    // Check what follows the variable name in the line
    let remaining = &line[match_end..];

    // Parameter expansion operators are :-, :=, :+, :?
    // Also handle the non-colon variants -, =, +, ?
    if remaining.starts_with(":-")
        || remaining.starts_with(":=")
        || remaining.starts_with(":+")
        || remaining.starts_with(":?")
        || remaining.starts_with('-')
        || remaining.starts_with('=')
        || remaining.starts_with('+')
        || remaining.starts_with('?')
    {
        return true;
    }

    false
}

/// Check if a trimmed line is an esac statement
fn is_esac_line(trimmed: &str) -> bool {
    trimmed == "esac" || trimmed.starts_with("esac;") || trimmed.starts_with("esac ")
}

/// Extract assigned variable names from a case block that has a default branch
fn extract_case_block_vars(case_block: &[&str], assign_pattern: &Regex) -> Vec<String> {
    let has_default = case_block.iter().any(|l| {
        let t = l.trim();
        t.starts_with("*)") || t.starts_with("* )") || t.contains("*)")
    });

    if !has_default {
        return Vec::new();
    }

    let mut vars = Vec::new();
    for case_line in case_block {
        let t = case_line.trim();
        if t.ends_with(')') && !t.contains('=') {
            continue;
        }
        for cap in assign_pattern.captures_iter(case_line) {
            if let Some(var) = cap.get(1) {
                vars.push(var.as_str().to_string());
            }
        }
    }
    vars
}

/// Find variables assigned inside case statements with default branches
/// If a case has a *) default branch, variables assigned in ANY branch are considered defined
#[allow(clippy::expect_used)] // Compile-time regex
pub fn collect_case_statement_variables(source: &str) -> HashSet<String> {
    let mut case_vars: HashSet<String> = HashSet::new();
    let lines: Vec<&str> = source.lines().collect();
    let mut in_case = false;
    let mut case_start = 0;
    let mut case_depth = 0;

    let assign_pattern =
        Regex::new(r"([A-Za-z_][A-Za-z0-9_]*)=").expect("valid assignment regex pattern");

    for (i, line) in lines.iter().enumerate() {
        let trimmed = line.trim();

        if trimmed.starts_with("case ") && trimmed.contains(" in") {
            if !in_case {
                in_case = true;
                case_start = i;
            }
            case_depth += 1;
        }

        if is_esac_line(trimmed) {
            if case_depth > 0 {
                case_depth -= 1;
            }
            if case_depth == 0 && in_case {
                let case_block: Vec<&str> = lines[case_start..=i].to_vec();
                for var in extract_case_block_vars(&case_block, &assign_pattern) {
                    case_vars.insert(var);
                }
                in_case = false;
            }
        }
    }

    case_vars
}

/// Check if line is a case expression start
pub fn is_case_start(line: &str) -> bool {
    let trimmed = line.trim();
    trimmed.starts_with("case ") && trimmed.contains(" in")
}

/// Check if line is case end
pub fn is_case_end(line: &str) -> bool {
    let trimmed = line.trim();
    trimmed == "esac" || trimmed.starts_with("esac;") || trimmed.starts_with("esac ")
}

/// Check if case block has default branch
pub fn case_has_default(block: &[&str]) -> bool {
    block.iter().any(|l| {
        let t = l.trim();
        t.starts_with("*)") || t.starts_with("* )") || t.contains("*)")
    })
}

/// Check if line is a pattern line in case (like "a)" or "*)")
pub fn is_case_pattern_line(line: &str) -> bool {
    let t = line.trim();
    t.ends_with(')') && !t.contains('=')
}

/// Extract variable names from read command in a line
pub fn extract_read_variables(line: &str) -> Vec<String> {
    let mut vars = Vec::new();
    if let Some(read_pos) = line.find("read ") {
        let after_read = &line[read_pos + 5..];
        let parts: Vec<&str> = after_read.split_whitespace().collect();
        let mut i = 0;
        // Skip flags
        while i < parts.len() {
            let part = parts[i];
            if part.starts_with('-') {
                i += 1;
                if matches!(part, "-p" | "-a" | "-d" | "-n" | "-t" | "-u") {
                    i += 1;
                }
            } else {
                break;
            }
        }
        // Remaining parts are variable names
        while i < parts.len() {
            let var_name = parts[i].trim_end_matches(';');
            if var_name
                .chars()
                .next()
                .is_some_and(|c| c.is_alphabetic() || c == '_')
                && var_name.chars().all(|c| c.is_alphanumeric() || c == '_')
            {
                vars.push(var_name.to_string());
                i += 1;
            } else {
                break;
            }
        }
    }
    vars
}

/// Patterns for variable detection
pub struct Patterns {
    pub assign: Regex,
    pub use_: Regex,
    pub for_loop: Regex,
    pub c_style_for: Regex,
    pub case_expr: Regex,
}

/// Create regex patterns for variable detection
#[allow(clippy::unwrap_used)] // Compile-time regex
pub fn create_patterns() -> Patterns {
    Patterns {
        assign: Regex::new(
            r"^\s*(?:(?:local|readonly|export|declare|typeset)(?:\s+-[a-zA-Z]+)?\s+)?([A-Za-z_][A-Za-z0-9_]*)=",
        ).unwrap(),
        use_: Regex::new(r"\$\{?([A-Za-z_][A-Za-z0-9_]*)\}?").unwrap(),
        for_loop: Regex::new(r"\bfor\s+([A-Za-z_][A-Za-z0-9_]*)\s+in\b").unwrap(),
        c_style_for: Regex::new(r"\bfor\s*\(\(\s*([A-Za-z_][A-Za-z0-9_]*)\s*=").unwrap(),
        case_expr: Regex::new(r"\bcase\s+\$\{?([A-Za-z_][A-Za-z0-9_]*)\}?\s+in\b").unwrap(),
    }
}

/// Collect variable assignments and uses from source
#[allow(clippy::unwrap_used)] // Regex captures in known patterns
pub fn collect_variable_info(
    source: &str,
    patterns: &Patterns,
) -> (HashSet<String>, Vec<(String, usize, usize)>) {
    let mut assigned: HashSet<String> = HashSet::new();
    let mut used_vars: Vec<(String, usize, usize)> = Vec::new();
    let has_sources = has_source_commands(source);

    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;
        if is_comment_line(line) {
            continue;
        }

        for cap in patterns.assign.captures_iter(line) {
            assigned.insert(cap.get(1).unwrap().as_str().to_string());
        }
        for cap in patterns.for_loop.captures_iter(line) {
            assigned.insert(cap.get(1).unwrap().as_str().to_string());
        }
        for cap in patterns.c_style_for.captures_iter(line) {
            assigned.insert(cap.get(1).unwrap().as_str().to_string());
        }
        for cap in patterns.case_expr.captures_iter(line) {
            assigned.insert(cap.get(1).unwrap().as_str().to_string());
        }
        for var in extract_read_variables(line) {
            assigned.insert(var);
        }
        for cap in patterns.use_.captures_iter(line) {
            let var_name = cap.get(1).unwrap().as_str();
            let full_match = cap.get(0).unwrap();
            let col = full_match.start() + 1;

            // Issue #132: Skip variables with parameter expansion operators
            // ${VAR:-}, ${VAR:=}, ${VAR:+}, ${VAR:?} are intentional default/check patterns
            if is_parameter_expansion_with_operator(line, full_match.end()) {
                continue;
            }

            if has_sources && is_uppercase_var(var_name) {
                continue;
            }
            used_vars.push((var_name.to_string(), line_num, col));
        }
    }
    (assigned, used_vars)
}

/// Validate undefined variables and return diagnostics info
pub fn find_undefined_variables(
    assigned: &HashSet<String>,
    used_vars: &[(String, usize, usize)],
    builtins: &HashSet<&str>,
) -> Vec<(String, usize, usize)> {
    let mut undefined = Vec::new();
    for (var_name, line_num, col) in used_vars {
        if assigned.contains(var_name) {
            continue;
        }
        if is_special_or_builtin(var_name, builtins) {
            continue;
        }
        undefined.push((var_name.clone(), *line_num, *col));
    }
    undefined
}

#[cfg(test)]
#[path = "sc2154_logic_tests_get_builtins.rs"]
mod tests_extracted;