bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96

// SC2300: Use ${var:?} for required environment variables
use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static UNCHECKED_ENV: std::sync::LazyLock<Regex> =
    std::sync::LazyLock::new(|| Regex::new(r"=\s*\$\{?[A-Z_][A-Z0-9_]*\}?\s*$").unwrap());

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();
    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;
        if line.trim_start().starts_with('#') {
            continue;
        }

        // Check for environment variable usage without error handling
        if line.contains("export") || line.starts_with("export") {
            continue; // Skip export statements
        }

        if UNCHECKED_ENV.is_match(line) && !line.contains(":?") {
            let diagnostic = Diagnostic::new(
                "SC2300",
                Severity::Info,
                "Consider using ${VAR:?} to ensure required environment variables are set"
                    .to_string(),
                Span::new(line_num, 1, line_num, line.len() + 1),
            );
            result.add(diagnostic);
        }
    }
    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2300_unchecked_env() {
        let code = "path=$HOME";
        assert_eq!(check(code).diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2300_with_check_ok() {
        let code = "path=${HOME:?}";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2300_export_ok() {
        let code = "export PATH=$PATH";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2300_comment() {
        let code = "# x=$HOME";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2300_empty() {
        assert_eq!(check("").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2300_normal() {
        assert_eq!(check("echo test").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2300_lowercase_var_ok() {
        let code = "path=$home";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2300_with_default_ok() {
        let code = "path=${HOME:-/default}";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2300_config_var() {
        let code = "db=$DATABASE_URL";
        assert_eq!(check(code).diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2300_in_command_ok() {
        let code = "echo $HOME";
        assert_eq!(check(code).diagnostics.len(), 0);
    }
}