bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104

// SC2217: Use [ p ] || [ q ] instead of [ p -o q ]
use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static DEPRECATED_O_OPERATOR: std::sync::LazyLock<Regex> = std::sync::LazyLock::new(|| {
    // Match [ ... -o ... ] in single bracket tests
    Regex::new(r"\[\s+[^\]]*\s+-o\s+[^\]]*\]").unwrap()
});

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();
    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;
        if line.trim_start().starts_with('#') {
            continue;
        }

        // Skip [[ ]] (has different semantics)
        if line.contains("[[") {
            continue;
        }
        // Skip set -o / shopt -o (shell options)
        if line.contains("set -o") || line.contains("shopt -o") {
            continue;
        }

        if DEPRECATED_O_OPERATOR.is_match(line) {
            let diagnostic = Diagnostic::new(
                "SC2217",
                Severity::Warning,
                "Use [ p ] || [ q ] instead of deprecated [ p -o q ] for better portability"
                    .to_string(),
                Span::new(line_num, 1, line_num, line.len() + 1),
            );
            result.add(diagnostic);
        }
    }
    result
}

#[cfg(test)]
mod tests {
    use super::*;
    #[test]
    fn test_sc2217_deprecated_o() {
        let code = r#"[ "$x" -eq 1 -o "$y" -eq 2 ]"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2217_separate_ok() {
        let code = r#"[ "$x" -eq 1 ] || [ "$y" -eq 2 ]"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2217_double_bracket_ok() {
        let code = r#"[[ "$x" -eq 1 -o "$y" -eq 2 ]]"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0); // Not single bracket
    }
    #[test]
    fn test_sc2217_set_option_ok() {
        let code = r#"set -o errexit"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0); // Shell option
    }
    #[test]
    fn test_sc2217_shopt_ok() {
        let code = r#"shopt -o nullglob"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0); // Shell option
    }
    #[test]
    fn test_sc2217_string_comparison() {
        let code = r#"[ "$a" = "x" -o "$b" = "y" ]"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2217_nested_conditions() {
        let code = r#"if [ "$x" -gt 0 -o "$y" -lt 10 ]; then"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2217_comment_skipped() {
        let code = r#"# [ "$a" -eq 1 -o "$b" -eq 2 ]"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2217_file_tests() {
        let code = r#"[ -f "$file" -o -d "$dir" ]"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2217_no_o_ok() {
        let code = r#"[ "$x" -eq 1 ]"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
}