bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156

//! SC1078: Did you forget to close this double-quoted string?
//!
//! Detects lines with an odd number of unescaped double quotes,
//! suggesting an unclosed string.

use crate::linter::{Diagnostic, LintResult, Severity, Span};

/// Check for unclosed double-quoted strings
pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();

    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;
        let trimmed = line.trim_start();

        if trimmed.starts_with('#') {
            continue;
        }

        // Skip heredoc markers and lines that are part of heredocs
        if trimmed.starts_with("<<") {
            continue;
        }

        let unescaped_quote_count = count_unescaped_double_quotes(line);

        #[allow(clippy::manual_is_multiple_of)]
        if unescaped_quote_count % 2 != 0 {
            // Find the position of the last unescaped quote
            let col = find_last_unescaped_double_quote(line);
            let diagnostic = Diagnostic::new(
                "SC1078",
                Severity::Error,
                "Did you forget to close this double-quoted string?",
                Span::new(line_num, col + 1, line_num, col + 2),
            );
            result.add(diagnostic);
        }
    }

    result
}

fn count_unescaped_double_quotes(line: &str) -> usize {
    let bytes = line.as_bytes();
    let mut count = 0;
    let mut in_single_quote = false;

    let mut i = 0;
    while i < bytes.len() {
        if bytes[i] == b'\'' && !in_single_quote {
            in_single_quote = true;
            i += 1;
            continue;
        }
        if bytes[i] == b'\'' && in_single_quote {
            in_single_quote = false;
            i += 1;
            continue;
        }
        if in_single_quote {
            i += 1;
            continue;
        }

        if bytes[i] == b'"' {
            // Check if escaped
            if i > 0 && bytes[i - 1] == b'\\' {
                // Check for double-escape (\\")
                if i > 1 && bytes[i - 2] == b'\\' {
                    count += 1; // \\" means the backslash is escaped, quote is real
                }
                // Otherwise it's escaped, skip
            } else {
                count += 1;
            }
        }
        i += 1;
    }

    count
}

fn find_last_unescaped_double_quote(line: &str) -> usize {
    let bytes = line.as_bytes();
    let mut last_pos = 0;
    let mut in_single_quote = false;

    let mut i = 0;
    while i < bytes.len() {
        if bytes[i] == b'\'' && !in_single_quote {
            in_single_quote = true;
            i += 1;
            continue;
        }
        if bytes[i] == b'\'' && in_single_quote {
            in_single_quote = false;
            i += 1;
            continue;
        }
        if in_single_quote {
            i += 1;
            continue;
        }

        if bytes[i] == b'"' && (i == 0 || bytes[i - 1] != b'\\') {
            last_pos = i;
        }
        i += 1;
    }

    last_pos
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc1078_unclosed_double_quote() {
        let script = "echo \"hello world";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 1);
        assert_eq!(result.diagnostics[0].code, "SC1078");
        assert_eq!(result.diagnostics[0].severity, Severity::Error);
    }

    #[test]
    fn test_sc1078_closed_double_quote() {
        let script = "echo \"hello world\"";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc1078_escaped_quote_not_flagged() {
        let script = r#"echo "hello \" world""#;
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc1078_comment_skipped() {
        let script = "# echo \"unclosed";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc1078_single_quote_inside_not_counted() {
        // Single-quoted section containing " should not affect count
        let script = "echo 'he said \"hi\"'";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 0);
    }
}