bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131

// SC2079: (( )) doesn't support decimals. Use bc or awk for floating point
//
// Shell arithmetic expansion $(( )) only supports integer arithmetic.
// Decimal numbers are truncated or cause errors.
//
// Examples:
// Bad:
//   result=$((3.14 * 2))       // Decimals not supported
//   if (( value > 2.5 )); then // Error or wrong result
//
// Good:
//   result=$(echo "3.14 * 2" | bc)         // Use bc
//   result=$(awk "BEGIN {print 3.14 * 2}") // Use awk
//
// Impact: Syntax errors, wrong calculations

use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static DECIMAL_IN_ARITHMETIC: std::sync::LazyLock<Regex> = std::sync::LazyLock::new(|| {
    // Match: $(( ... 3.14 ... )) or (( ... 2.5 ... ))
    Regex::new(r"\$?\(\(\s*[^)]*[0-9]+\.[0-9]+[^)]*\)\)").unwrap()
});

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();

    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;

        if line.trim_start().starts_with('#') {
            continue;
        }

        for mat in DECIMAL_IN_ARITHMETIC.find_iter(line) {
            let start_col = mat.start() + 1;
            let end_col = mat.end() + 1;

            let diagnostic = Diagnostic::new(
                "SC2079",
                Severity::Error,
                "(( )) doesn't support decimals. Use bc or awk for floating point arithmetic"
                    .to_string(),
                Span::new(line_num, start_col, line_num, end_col),
            );

            result.add(diagnostic);
        }
    }

    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2079_decimal_in_arithmetic() {
        let code = r#"result=$((3.14 * 2))"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2079_decimal_comparison() {
        let code = r#"if (( value > 2.5 )); then echo "yes"; fi"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2079_decimal_pi() {
        let code = r#"circumference=$((2 * 3.14159 * radius))"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2079_integer_ok() {
        let code = r#"result=$((3 * 2))"#;
        let result = check(code);
        // Integer arithmetic is OK
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2079_bc_ok() {
        let code = r#"result=$(echo "3.14 * 2" | bc)"#;
        let result = check(code);
        // Using bc for decimals is correct
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2079_awk_ok() {
        let code = r#"result=$(awk 'BEGIN {print 3.14 * 2}')"#;
        let result = check(code);
        // Using awk for decimals is correct
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2079_comment_ok() {
        let code = r#"# result=$((3.14 * 2))"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2079_multiple_decimals() {
        let code = r#"result=$((1.5 + 2.5))"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2079_double_paren() {
        let code = r#"(( x = 1.5 ))"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2079_version_string() {
        let code = r#"version="1.2.3""#;
        let result = check(code);
        // String assignment, not arithmetic
        assert_eq!(result.diagnostics.len(), 0);
    }
}