bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90

// SC2298: Useless use of cat before pipe
use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static USELESS_CAT: std::sync::LazyLock<Regex> =
    std::sync::LazyLock::new(|| Regex::new(r"\bcat\s+[^\s|-][^\s|]*\s*\|").unwrap());

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();
    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;
        if line.trim_start().starts_with('#') {
            continue;
        }

        if USELESS_CAT.is_match(line) {
            let diagnostic = Diagnostic::new(
                "SC2298",
                Severity::Info,
                "Use < file instead of cat file | for better performance".to_string(),
                Span::new(line_num, 1, line_num, line.len() + 1),
            );
            result.add(diagnostic);
        }
    }
    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2298_cat_pipe() {
        let code = "cat file | grep pattern";
        assert_eq!(check(code).diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2298_redirect_ok() {
        let code = "grep pattern < file";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2298_cat_multiple_ok() {
        let code = "cat file1 file2 | grep";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2298_comment() {
        let code = "# cat file | grep";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2298_empty() {
        assert_eq!(check("").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2298_normal() {
        assert_eq!(check("echo test").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2298_cat_no_pipe_ok() {
        let code = "cat file";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2298_pipe_without_cat_ok() {
        let code = "echo test | grep t";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2298_cat_dash_ok() {
        let code = "cat - | grep pattern";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2298_with_path() {
        let code = "cat /path/to/file | sort";
        assert_eq!(check(code).diagnostics.len(), 1);
    }
}