bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44

// SC2204: (..) is subshell, not test
use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static IF_SUBSHELL: std::sync::LazyLock<Regex> =
    std::sync::LazyLock::new(|| Regex::new(r"\bif\s+\(").unwrap());

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();
    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;
        if line.trim_start().starts_with('#') {
            continue;
        }

        if IF_SUBSHELL.is_match(line) && !line.contains("$(") && !line.contains("((") {
            let diagnostic = Diagnostic::new(
                "SC2204",
                Severity::Warning,
                "(..) is a subshell. Use [ ] or [[ ]] for test".to_string(),
                Span::new(line_num, 1, line_num, line.len() + 1),
            );
            result.add(diagnostic);
        }
    }
    result
}

#[cfg(test)]
mod tests {
    use super::*;
    #[test]
    fn test_sc2204_if_subshell() {
        let code = "if ( test ); then";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2204_if_test_ok() {
        let code = "if [ test ]; then";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
}