bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98

// SC2238: Redirecting to/from command name instead of file
use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static REDIRECT_TO_COMMAND: std::sync::LazyLock<Regex> = std::sync::LazyLock::new(|| {
    // Match: > command_name or < command_name (no path separator), but not >>
    Regex::new(r"([^>]>|<)\s*[a-z_][a-z0-9_-]*\s*($|;|\||&)").unwrap()
});

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();
    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;
        if line.trim_start().starts_with('#') {
            continue;
        }

        if REDIRECT_TO_COMMAND.is_match(line) {
            // Skip if it looks like a file (has extension or path)
            if !line.contains('.') && !line.contains('/') {
                let diagnostic = Diagnostic::new(
                    "SC2238",
                    Severity::Warning,
                    "Redirecting to/from bare word may be a command name. Use ./ or quotes if it's a file"
                        .to_string(),
                    Span::new(line_num, 1, line_num, line.len() + 1),
                );
                result.add(diagnostic);
            }
        }
    }
    result
}

#[cfg(test)]
mod tests {
    use super::*;
    #[test]
    fn test_sc2238_redirect_to_command() {
        let code = "echo test > output";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2238_redirect_to_file_ok() {
        let code = "echo test > output.txt";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2238_redirect_with_path_ok() {
        let code = "echo test > ./output";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2238_redirect_from_command() {
        let code = "cat < input";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2238_comment_skipped() {
        let code = "# echo > output";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2238_redirect_with_slash() {
        let code = "echo test > /tmp/output";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2238_stderr_redirect() {
        let code = "cmd 2> errors";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2238_no_code() {
        let code = "";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2238_normal_command() {
        let code = "echo test";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2238_append_redirect() {
        let code = "echo data >> logfile";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0); // >> not matched by pattern
    }
}