bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111

// SC2249: Consider adding default case to case statement
use crate::linter::{Diagnostic, LintResult, Severity, Span};

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();
    let full_source = source.to_string();

    // Find all "case " statements in source
    let mut pos = 0;
    while let Some(case_pos) = full_source[pos..].find("case ") {
        let abs_pos = pos + case_pos;
        let line_num = full_source[..abs_pos].matches('\n').count() + 1;

        // Skip if in a comment (check if line starts with #)
        let line_start = full_source[..abs_pos].rfind('\n').map_or(0, |p| p + 1);
        let line_prefix = &full_source[line_start..abs_pos];
        if line_prefix.trim().starts_with('#') {
            pos = abs_pos + 5;
            continue;
        }

        // Find corresponding esac
        if let Some(esac_pos) = full_source[abs_pos..].find("esac") {
            let case_block = &full_source[abs_pos..abs_pos + esac_pos + 4];

            // Check if it has a default pattern (*)
            let has_default = case_block.contains("*)");

            if !has_default {
                let diagnostic = Diagnostic::new(
                    "SC2249",
                    Severity::Info,
                    "Consider adding a *) default case to handle unexpected values".to_string(),
                    Span::new(line_num, 1, line_num, 10),
                );
                result.add(diagnostic);
            }

            // Move past this case statement
            pos = abs_pos + esac_pos + 4;
        } else {
            break;
        }
    }
    result
}

#[cfg(test)]
mod tests {
    use super::*;
    #[test]
    fn test_sc2249_no_default() {
        let code = "case $x in\n  a) echo 1;;\n  b) echo 2;;\nesac";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2249_has_default_ok() {
        let code = "case $x in\n  a) echo 1;;\n  *) echo default;;\nesac";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2249_default_with_action() {
        let code = "case $x in\n  a) echo 1;;\n  *) ;;\nesac";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2249_comment_skipped() {
        let code = "# case $x in a) ;; esac";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2249_single_pattern() {
        let code = "case $x in\n  *) echo all;;\nesac";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2249_multiple_cases() {
        let code = "case $a in\n  x) ;;\nesac\ncase $b in\n  y) ;;\n  *) ;;\nesac";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1); // First case missing default
    }
    #[test]
    fn test_sc2249_no_code() {
        let code = "";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2249_normal_command() {
        let code = "echo test";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }
    #[test]
    fn test_sc2249_inline_case() {
        let code = "case $x in a) echo 1;; b) echo 2;; esac";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
    #[test]
    fn test_sc2249_nested_case() {
        let code = "case $x in\n  a) case $y in z) ;; esac;;\n  *) ;;\nesac";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1); // Inner case missing default
    }
}