bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137

// SC2319: This $? refers to a condition, not the previous command
use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static CONDITION_EXITCODE: std::sync::LazyLock<Regex> =
    std::sync::LazyLock::new(|| Regex::new(r"(?:if|while|until)\s+.*;\s*then").unwrap());

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();
    let lines: Vec<&str> = source.lines().collect();

    for i in 0..lines.len() {
        let line = lines[i].trim();

        if line.starts_with('#') {
            continue;
        }

        // Check if this line is a condition
        if CONDITION_EXITCODE.is_match(line) {
            // Check if next line uses $?
            if i + 1 < lines.len() {
                let next_line = lines[i + 1].trim();
                if next_line.contains("$?") && !next_line.starts_with('#') {
                    let diagnostic = Diagnostic::new(
                        "SC2319",
                        Severity::Warning,
                        "$? refers to the condition's exit code, not the command inside it"
                            .to_string(),
                        Span::new(i + 2, 1, i + 2, next_line.len() + 1),
                    );
                    result.add(diagnostic);
                }
            }
        }
    }

    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2319_exitcode_after_if() {
        let code = r#"
if command; then
    echo $?
fi
"#;
        assert_eq!(check(code).diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2319_save_exitcode_ok() {
        let code = r#"
command
status=$?
if [ $status -eq 0 ]; then
    echo ok
fi
"#;
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2319_direct_test_ok() {
        let code = r#"
if command; then
    echo "success"
fi
"#;
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2319_comment_ok() {
        let code = r#"
if command; then
    # echo $?
fi
"#;
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2319_empty() {
        assert_eq!(check("").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2319_normal() {
        assert_eq!(check("echo test").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2319_while_loop() {
        let code = r#"
while command; then
    echo $?
done
"#;
        assert_eq!(check(code).diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2319_no_then_ok() {
        let code = r#"
command
echo $?
"#;
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2319_nested_command_ok() {
        let code = r#"
if command; then
    other_command
    echo $?
fi
"#;
        // This is technically ambiguous but we don't catch it
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2319_variable_comparison_ok() {
        let code = r#"
if [ $x -eq $? ]; then
    echo ok
fi
"#;
        assert_eq!(check(code).diagnostics.len(), 0);
    }
}