bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159

//! SC2164: Use cd ... || exit in case cd fails
//!
//! # Examples
//!
//! Bad:
//! ```bash
//! cd /some/directory
//! ./script.sh  # Runs in wrong directory if cd fails!
//! ```
//!
//! Good:
//! ```bash
//! cd /some/directory || exit
//! ./script.sh
//! ```
//!
//! # Rationale
//!
//! If cd fails, subsequent commands run in the wrong directory:
//! - Can cause data loss
//! - Can execute wrong scripts
//! - Hard to debug failures
//!
//! Always check cd exit status or use `set -e`.
//!
//! # Auto-fix
//!
//! Add || exit to cd command

use crate::linter::{Diagnostic, Fix, LintResult, Severity, Span};
use regex::Regex;

/// Check for cd without error handling
static PATTERN: std::sync::LazyLock<Regex> =
    std::sync::LazyLock::new(|| Regex::new(r"\bcd\s+([^\s;&|]+)").unwrap());

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();

    // Pattern: cd path (simple detection - enhancement needed)
    // TODO: Improve negative lookahead for better detection
    let pattern = &*PATTERN;

    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;

        if line.trim_start().starts_with('#') {
            continue;
        }

        // Skip if line already has error handling
        if line.contains("|| exit") || line.contains("|| return") || line.contains("&& ") {
            continue;
        }

        for cap in pattern.captures_iter(line) {
            let full_match = cap.get(0).unwrap();
            let directory = cap.get(1).unwrap().as_str();

            let start_col = full_match.start() + 1;
            let end_col = full_match.end() + 1;

            let fix_text = format!("cd {} || exit", directory);

            let diagnostic = Diagnostic::new(
                "SC2164",
                Severity::Warning,
                "Use 'cd ... || exit' in case cd fails",
                Span::new(line_num, start_col, line_num, end_col),
            )
            .with_fix(Fix::new(fix_text));

            result.add(diagnostic);
        }
    }

    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2164_basic_detection() {
        let script = "cd /tmp";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 1);
        assert_eq!(result.diagnostics[0].code, "SC2164");
    }

    #[test]
    fn test_sc2164_autofix() {
        let script = "cd /tmp";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 1);
        assert!(result.diagnostics[0].fix.is_some());
        assert_eq!(
            result.diagnostics[0].fix.as_ref().unwrap().replacement,
            "cd /tmp || exit"
        );
    }

    #[test]
    fn test_sc2164_with_variable() {
        let script = "cd \"$HOME/projects\"";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2164_relative_path() {
        let script = "cd ../..";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2164_false_positive_with_exit() {
        let script = "cd /tmp || exit";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2164_false_positive_with_return() {
        let script = "cd /tmp || return";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2164_false_positive_in_comment() {
        let script = "# cd /tmp";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2164_in_script() {
        let script = "cd /var/log\ngrep ERROR syslog";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2164_with_tilde() {
        let script = "cd ~/documents";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2164_false_positive_with_and() {
        let script = "cd /tmp && ls";
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 0);
    }
}