bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92

// SC2277: Prefer process substitution over temporary files
use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static TEMP_FILE_PATTERN: std::sync::LazyLock<Regex> =
    std::sync::LazyLock::new(|| Regex::new(r"mktemp.*;\s*\w+\s+[^;]+;\s*rm").unwrap());

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();

    // Check across multiple lines for temp file pattern
    if TEMP_FILE_PATTERN.is_match(source) {
        for (line_num, line) in source.lines().enumerate() {
            let line_num = line_num + 1;
            if line.contains("mktemp") {
                let diagnostic = Diagnostic::new(
                    "SC2277",
                    Severity::Info,
                    "Consider using process substitution <(...) instead of temporary files"
                        .to_string(),
                    Span::new(line_num, 1, line_num, line.len() + 1),
                );
                result.add(diagnostic);
                break;
            }
        }
    }
    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2277_temp_file_pattern() {
        let code = "tmp=$(mktemp); echo data > $tmp; cat $tmp; rm $tmp";
        assert_eq!(check(code).diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2277_process_subst_ok() {
        let code = "diff <(cmd1) <(cmd2)";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2277_mktemp_alone_ok() {
        let code = "tmp=$(mktemp)";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2277_comment() {
        let code = "# mktemp; cat; rm";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2277_empty() {
        assert_eq!(check("").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2277_normal() {
        assert_eq!(check("echo test").diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2277_mktemp_kept_ok() {
        let code = "tmp=$(mktemp); echo data > $tmp";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2277_no_mktemp_ok() {
        let code = "cat file; rm file";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2277_heredoc_ok() {
        let code = "cat << EOF\ndata\nEOF";
        assert_eq!(check(code).diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2277_pipe_ok() {
        let code = "echo data | cat";
        assert_eq!(check(code).diagnostics.len(), 0);
    }
}