bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143

// SC2122: '>=' is not a valid comparison operator. Use -ge
//
// In [ ] test, use -ge for numeric >= comparison, not >=.
// The >= syntax is for string comparison in [[ ]], not arithmetic in [ ].
//
// Examples:
// Bad:
//   [ $x >= 10 ]              // Wrong operator in [ ]
//   if [ $count >= 5 ]        // Won't work as expected
//
// Good:
//   [ $x -ge 10 ]             // Arithmetic comparison
//   [[ $str >= "abc" ]]       // String comparison (but rarely useful)
//
// Impact: Comparison doesn't work correctly, treated as string

use crate::linter::{Diagnostic, LintResult, Severity, Span};
use regex::Regex;

static SINGLE_BRACKET_GE: std::sync::LazyLock<Regex> = std::sync::LazyLock::new(|| {
    // Match: [ ... >= ... ] (not [[]])
    Regex::new(r"\[\s[^\]]*>=\s*[^\]]*\]").unwrap()
});

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();

    for (line_num, line) in source.lines().enumerate() {
        let line_num = line_num + 1;

        if line.trim_start().starts_with('#') {
            continue;
        }

        // Skip lines with [[ ]] (double brackets allow >=)
        if line.contains("[[") {
            continue;
        }

        for mat in SINGLE_BRACKET_GE.find_iter(line) {
            let matched = mat.as_str();

            // Find position of >= within match
            if let Some(ge_pos) = matched.find(">=") {
                let start_col = mat.start() + ge_pos + 1;
                let end_col = start_col + 2; // length of ">="

                let diagnostic = Diagnostic::new(
                    "SC2122",
                    Severity::Error,
                    "'>=' is not a valid operator in [ ]. Use -ge for numeric, or [[ ]] for lexical comparison".to_string(),
                    Span::new(line_num, start_col, line_num, end_col),
                );

                result.add(diagnostic);
            }
        }
    }

    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_sc2122_single_bracket_ge() {
        let code = "[ $x >= 10 ]";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2122_ge_correct_ok() {
        let code = "[ $x -ge 10 ]";
        let result = check(code);
        // -ge is correct
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2122_double_bracket_ok() {
        let code = "[[ $x >= 10 ]]";
        let result = check(code);
        // [[ ]] allows >= for lexical comparison
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2122_comment_ok() {
        let code = "# [ $x >= 10 ]";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2122_in_if() {
        let code = "if [ $count >= 5 ]; then";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2122_with_variable() {
        let code = r#"[ "$VAR" >= "$MIN" ]"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2122_spaces() {
        let code = "[ $x  >=  10 ]";
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2122_multiline() {
        let code = r#"
if [ $value >= 100 ]; then
    echo "Large"
fi
"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }

    #[test]
    fn test_sc2122_gt_ok() {
        let code = "[ $x -gt 10 ]";
        let result = check(code);
        // -gt is correct, not testing >=
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_sc2122_string_comparison() {
        let code = r#"[ "$str1" >= "$str2" ]"#;
        let result = check(code);
        assert_eq!(result.diagnostics.len(), 1);
    }
}