bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104

//! PERF004: find -exec with \\; forks per file
//!
//! **Rule**: Detect `find -exec cmd {} \;` which forks a process per matched file
//!
//! **Why this matters**:
//! `find -exec cmd {} \;` executes `cmd` once per file found, forking a new
//! process each time. Using `find -exec cmd {} +` batches files into fewer
//! invocations, dramatically improving performance for large file sets.
//!
//! **Auto-fix**: Safe - suggest replacing `\;` with `+`
//!
//! ## Examples
//!
//! Bad (forks per file):
//! ```bash
//! find . -name "*.log" -exec rm {} \;
//! ```
//!
//! Good (batches files):
//! ```bash
//! find . -name "*.log" -exec rm {} +
//! ```

use crate::linter::{Diagnostic, Fix, LintResult, Severity, Span};
use regex::Regex;

/// Check for find -exec with \; instead of +
static PATTERN: std::sync::LazyLock<Regex> =
    std::sync::LazyLock::new(|| Regex::new(r"\bfind\b.*\-exec\b.*\{\}\s*(\\;|';')").unwrap());

pub fn check(source: &str) -> LintResult {
    let mut result = LintResult::new();

    // Match find ... -exec ... {} \;  or  find ... -exec ... {} ';'
    let pattern = &*PATTERN;

    for (line_num, line) in source.lines().enumerate() {
        let trimmed = line.trim_start();

        // Skip comments
        if trimmed.starts_with('#') {
            continue;
        }

        if let Some(m) = pattern.find(line) {
            let start_col = m.start() + 1;
            let end_col = m.end() + 1;

            let diagnostic = Diagnostic::new(
                "PERF004",
                Severity::Warning,
                "find -exec with \\; forks a process per file. Use + to batch: -exec cmd {} +",
                Span::new(line_num + 1, start_col, line_num + 1, end_col),
            )
            .with_fix(Fix::new("Replace \\; with + to batch file arguments"));

            result.add(diagnostic);
        }
    }

    result
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_perf004_detects_exec_semicolon() {
        let script = r#"find . -name "*.log" -exec rm {} \;"#;
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 1);
        assert_eq!(result.diagnostics[0].code, "PERF004");
        assert_eq!(result.diagnostics[0].severity, Severity::Warning);
    }

    #[test]
    fn test_perf004_no_flag_exec_plus() {
        let script = r#"find . -name "*.log" -exec rm {} +"#;
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_perf004_provides_fix() {
        let script = r#"find . -name "*.log" -exec rm {} \;"#;
        let result = check(script);
        assert!(result.diagnostics[0].fix.is_some());
    }

    #[test]
    fn test_perf004_no_false_positive_comment() {
        let script = r#"# find . -name "*.log" -exec rm {} \;"#;
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 0);
    }

    #[test]
    fn test_perf004_detects_with_complex_command() {
        let script = r#"find /var/log -type f -name "*.gz" -exec gzip -d {} \;"#;
        let result = check(script);
        assert_eq!(result.diagnostics.len(), 1);
    }
}