rrubocop 0.8.14

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68

//! Style/YAMLFileRead — prefer YAML.load_file.

use tree_sitter::Node;

use crate::cop::shared::{argument_nodes, call_method_name, call_receiver, is_const_named};
use crate::cop::{Cop, CopConfig};
use crate::diagnostic::Diagnostic;
use crate::parse::source::SourceFile;

pub struct YAMLFileRead;

impl Cop for YAMLFileRead {
    fn name(&self) -> &'static str {
        "Style/YAMLFileRead"
    }

    fn interested_node_kinds(&self) -> &'static [&'static str] {
        &["call"]
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        _config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        _corrections: Option<&mut Vec<crate::correction::Correction>>,
    ) {
        if !is_yaml_file_read(source, node) {
            return;
        }
        let (line, col) = source.offset_to_line_col(node.start_byte());
        diagnostics.push(self.diagnostic(
            source,
            line,
            col,
            "Use `YAML.load_file` instead of `YAML.load(File.read(...))`.".to_string(),
        ));
    }
}

fn is_yaml_file_read(source: &SourceFile, node: Node<'_>) -> bool {
    let Some(method) = call_method_name(source, node) else {
        return false;
    };
    if method != b"load" && method != b"safe_load" && method != b"parse" {
        return false;
    }
    let Some(recv) = call_receiver(node) else {
        return false;
    };
    if !is_const_named(source, recv, b"YAML") {
        return false;
    }
    argument_nodes(node)
        .first()
        .is_some_and(|arg| is_file_read(source, *arg))
}

fn is_file_read(source: &SourceFile, arg: Node<'_>) -> bool {
    if arg.kind() != "call" {
        return false;
    }
    if call_method_name(source, arg) != Some(b"read") {
        return false;
    }
    call_receiver(arg).is_some_and(|r| is_const_named(source, r, b"File"))
}