rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80

//! Style/ColonMethodCall
use tree_sitter::Node;
use crate::cop::shared::{call_receiver, node_bytes};
use crate::cop::{Cop, CopConfig};
use crate::correction::Correction;
use crate::diagnostic::Diagnostic;
use crate::parse::source::SourceFile;

pub struct ColonMethodCall;

impl Cop for ColonMethodCall {
    fn name(&self) -> &'static str {
        "Style/ColonMethodCall"
    }

    fn supports_autocorrect(&self) -> bool {
        true
    }

    fn interested_node_kinds(&self) -> &'static [&'static str] {
        &["call"]
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        _c: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        mut corrections: Option<&mut Vec<Correction>>,
    ) {
        let Some(op) = colon_method_op(source, node) else {
            return;
        };
        let (l, c) = source.offset_to_line_col(op.start_byte());
        let mut diag = self.diagnostic(
            source,
            l,
            c,
            "Do not use `::` for method calls.".into(),
        );
        if let Some(corr) = corrections.as_mut() {
            corr.push(Correction {
                start: op.start_byte(),
                end: op.end_byte(),
                replacement: ".".into(),
                cop_name: self.name(),
                cop_index: 0,
            });
            diag.corrected = true;
        }
        diagnostics.push(diag);
    }
}

fn colon_method_op<'a>(source: &SourceFile, node: Node<'a>) -> Option<Node<'a>> {
    let op = find_colon_op(node)?;
    if !method_is_lowercase(source, node) || is_java_recv(source, node) {
        return None;
    }
    Some(op)
}

fn find_colon_op(node: Node<'_>) -> Option<Node<'_>> {
    let mut cur = node.walk();
    node.children(&mut cur).find(|ch| !ch.is_named() && ch.kind() == "::")
}

fn method_is_lowercase(source: &SourceFile, node: Node<'_>) -> bool {
    let Some(method) = node.child_by_field_name("method") else {
        return false;
    };
    let mb = node_bytes(source, method);
    !mb.is_empty() && !mb[0].is_ascii_uppercase()
}

fn is_java_recv(source: &SourceFile, node: Node<'_>) -> bool {
    call_receiver(node)
        .is_some_and(|recv| recv.kind() == "constant" && node_bytes(source, recv) == b"Java")
}