rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79

//! Style/CharacterLiteral — avoid ?x character literals.

use tree_sitter::Node;

use crate::cop::{Cop, CopConfig};
use crate::correction::Correction;
use crate::diagnostic::Diagnostic;
use crate::parse::source::SourceFile;

pub struct CharacterLiteral;

impl Cop for CharacterLiteral {
    fn name(&self) -> &'static str {
        "Style/CharacterLiteral"
    }

    fn supports_autocorrect(&self) -> bool {
        true
    }

    fn interested_node_kinds(&self) -> &'static [&'static str] {
        &["character"]
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        _config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        mut corrections: Option<&mut Vec<Correction>>,
    ) {
        report(self, source, node, diagnostics, &mut corrections);
    }
}

fn report(
    cop: &CharacterLiteral,
    source: &SourceFile,
    node: Node<'_>,
    diagnostics: &mut Vec<Diagnostic>,
    corrections: &mut Option<&mut Vec<Correction>>,
) {
    let (line, col) = source.offset_to_line_col(node.start_byte());
    let mut diag = cop.diagnostic(
        source,
        line,
        col,
        "Do not use the character literal - use string literal instead.".to_string(),
    );
    if let Some(corr) = corrections.as_mut() {
        corr.push(Correction {
            start: node.start_byte(),
            end: node.end_byte(),
            replacement: to_string_lit(source, node),
            cop_name: cop.name(),
            cop_index: 0,
        });
        diag.corrected = true;
    }
    diagnostics.push(diag);
}

fn to_string_lit(source: &SourceFile, node: Node<'_>) -> String {
    let bytes = &source.as_bytes()[node.start_byte()..node.end_byte()];
    if bytes.len() == 2
        && bytes[0] == b'?'
        && bytes[1].is_ascii_graphic()
        && bytes[1] != b'\\'
        && bytes[1] != b'"'
    {
        return format!("\"{}\"", bytes[1] as char);
    }
    if bytes.first() == Some(&b'?') {
        let src = std::str::from_utf8(&bytes[1..]).unwrap_or("?");
        return format!("\"{src}\"");
    }
    format!("\"{}\"", String::from_utf8_lossy(bytes))
}