rrubocop 0.8.14

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100

//! Style/SuperWithArgsParentheses — super(...) needs parens.

use tree_sitter::Node;

use crate::cop::shared::{argument_nodes, node_bytes};
use crate::cop::{Cop, CopConfig};
use crate::correction::Correction;
use crate::diagnostic::Diagnostic;
use crate::parse::source::SourceFile;

pub struct SuperWithArgsParentheses;

impl Cop for SuperWithArgsParentheses {
    fn name(&self) -> &'static str {
        "Style/SuperWithArgsParentheses"
    }

    fn supports_autocorrect(&self) -> bool {
        true
    }

    fn interested_node_kinds(&self) -> &'static [&'static str] {
        &["call", "command"]
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        _config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        mut corrections: Option<&mut Vec<Correction>>,
    ) {
        let Some(first) = super_kw(source, node) else {
            return;
        };
        if node.child_by_field_name("arguments").is_none() || node.kind() != "command" {
            return;
        }
        report(self, source, node, first, diagnostics, &mut corrections);
    }
}

fn super_kw<'a>(source: &SourceFile, node: Node<'a>) -> Option<Node<'a>> {
    let mut cur = node.walk();
    let first = node.children(&mut cur).next()?;
    if node_bytes(source, first) != b"super" {
        return None;
    }
    Some(first)
}

fn report(
    cop: &SuperWithArgsParentheses,
    source: &SourceFile,
    node: Node<'_>,
    first: Node<'_>,
    diagnostics: &mut Vec<Diagnostic>,
    corrections: &mut Option<&mut Vec<Correction>>,
) {
    let (line, col) = source.offset_to_line_col(node.start_byte());
    let mut diag = cop.diagnostic(
        source,
        line,
        col,
        "Use parentheses for `super` call with arguments.".to_string(),
    );
    if let Some(corr) = corrections.as_mut() {
        push_parens(cop, node, first, corr, &mut diag);
    }
    diagnostics.push(diag);
}

fn push_parens(
    cop: &SuperWithArgsParentheses,
    node: Node<'_>,
    first: Node<'_>,
    corr: &mut Vec<Correction>,
    diag: &mut Diagnostic,
) {
    let args = argument_nodes(node);
    let (Some(first_arg), Some(last_arg)) = (args.first(), args.last()) else {
        return;
    };
    corr.push(Correction {
        start: first.end_byte(),
        end: first_arg.start_byte(),
        replacement: "(".into(),
        cop_name: cop.name(),
        cop_index: 0,
    });
    corr.push(Correction {
        start: last_arg.end_byte(),
        end: last_arg.end_byte(),
        replacement: ")".into(),
        cop_name: cop.name(),
        cop_index: 0,
    });
    diag.corrected = true;
}