neser 0.1.0

NESER - NES Emulator in Rust - is a NES emulator written in Rust. It aims to be a high-quality, hardware-accurate emulator that is also easy to use and extend. It supports a wide range of NES games and features, including various mappers, audio processing, and input handling. NESER is designed to be modular and extensible, allowing developers to easily add new features or support for additional hardware. It can be run using one of two frontends: a native desktop application using SDL2, or a web application using WebAssembly. The desktop application provides a high-performance, feature-rich experience with support for various input devices and display options, while the web application allows users to play NES games directly in their browsers without needing to install any software in a BYOR manner (Bring Your Own Roms).
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
//! Mapper 335 - BMC-CTC-09 (10-in-1 multicart)
//!
//! Specifications:
//! - Primary reference: FCEUmm `bmcctc09.c` (libretro-fceumm)
//! - NesDev: <https://www.nesdev.org/wiki/NES_2.0_Mapper_335>
//! - UNIF board name: BMC-CTC-09
//!
//! ## Register Map
//!
//! | Address       | Function          |
//! |---------------|-------------------|
//! | $8000–$BFFF   | CHR bank register |
//! | $C000$FFFF   | PRG bank register |
//!
//! ## PRG Banking (two 16 KB windows)
//!
//! Let `prg = regs[PRG]`:
//! - If `prg & 0x10` (NROM-128 mode): both $8000 and $C000//!   bank `((prg & 0x07) << 1) | ((prg >> 3) & 1)`
//! - Otherwise (NROM-256 mode): $8000 → `(prg & 0x07) * 2`,
//!   $C000 → `(prg & 0x07) * 2 + 1`
//!
//! ## CHR Banking
//!
//! 8 KB CHR page: `regs[CHR] & 0x0F`
//!
//! ## Mirroring
//!
//! Controlled by bit 5 of the PRG register:
//! - Bit 5 = 0 → Vertical
//! - Bit 5 = 1 → Horizontal
//!
//! ## Power-on / Reset
//!
//! Both registers initialised to 0: PRG banks 0/1, CHR bank 0, vertical mirroring.
//!
//! ## Known Limitations
//!
//! No known gameplay-blocking limitations.

use crate::cartridge::base_mapper::BaseMapper;
use crate::cartridge::mapper::{Mapper, MapperCapabilities};

const MAPPER_NUMBER: u16 = 335;
const PRG_BANK_SIZE_BYTES: usize = 16 * 1024;
const CHR_BANK_SIZE_BYTES: usize = 8 * 1024;
const NROM128_BIT: u8 = 0x10;
const PRG_BANK_MASK: u8 = 0x07;
const CHR_BANK_MASK: u8 = 0x0F;
const MIRROR_BIT: u8 = 0x20;
const REGISTERS_SNAPSHOT_LEN: usize = 2;

pub struct Mapper335 {
    base: BaseMapper,
    prg_reg: u8,
    chr_reg: u8,
}

impl Mapper335 {
    pub fn new(ctx: super::mapper::MapperContext) -> Self {
        let capabilities = MapperCapabilities {
            has_dynamic_mirroring: true,
            has_chr_banking: true,
            prg_bank_size_kb: 16,
            chr_bank_size_kb: 8,
            max_prg_ram_kb: 0,
            ..Default::default()
        };

        let mut base = BaseMapper::new(&ctx, capabilities);
        base.configure_prg_banking(PRG_BANK_SIZE_BYTES);
        base.configure_chr_banking(CHR_BANK_SIZE_BYTES);

        let mut mapper = Self {
            base,
            prg_reg: 0,
            chr_reg: 0,
        };
        mapper.apply_state(0, 0);
        mapper
    }

    fn prg_bank_8000(prg_reg: u8) -> i16 {
        if prg_reg & NROM128_BIT != 0 {
            (((prg_reg & PRG_BANK_MASK) << 1) | ((prg_reg >> 3) & 1)) as i16
        } else {
            ((prg_reg & PRG_BANK_MASK) as i16) * 2
        }
    }

    fn prg_bank_c000(prg_reg: u8) -> i16 {
        if prg_reg & NROM128_BIT != 0 {
            (((prg_reg & PRG_BANK_MASK) << 1) | ((prg_reg >> 3) & 1)) as i16
        } else {
            ((prg_reg & PRG_BANK_MASK) as i16) * 2 + 1
        }
    }

    fn apply_state(&mut self, prg_reg: u8, chr_reg: u8) {
        self.prg_reg = prg_reg;
        self.chr_reg = chr_reg;

        self.base.select_prg_page(0, Self::prg_bank_8000(prg_reg));
        self.base.select_prg_page(1, Self::prg_bank_c000(prg_reg));
        self.base
            .select_chr_page(0, (chr_reg & CHR_BANK_MASK) as i16);
        self.base.set_mirroring_hv((prg_reg & MIRROR_BIT) != 0);
    }
}

impl Mapper for Mapper335 {
    fn base(&self) -> &BaseMapper {
        &self.base
    }

    fn base_mut(&mut self) -> &mut BaseMapper {
        &mut self.base
    }

    fn mapper_number(&self) -> u16 {
        MAPPER_NUMBER
    }

    fn write_prg(&mut self, addr: u16, value: u8) {
        match addr {
            0x8000..=0xBFFF => self.apply_state(self.prg_reg, value),
            0xC000..=0xFFFF => self.apply_state(value, self.chr_reg),
            _ => {}
        }
    }

    fn registers_snapshot(&self) -> Vec<u8> {
        vec![self.prg_reg, self.chr_reg]
    }

    fn restore_registers(&mut self, data: &[u8]) {
        if data.len() < REGISTERS_SNAPSHOT_LEN {
            return;
        }
        self.apply_state(data[0], data[1]);
    }

    fn reset(&mut self) {
        self.apply_state(0, 0);
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::cartridge::NametableLayout;
    use crate::cartridge::mapper::{MapperContext, create_mapper};
    use crate::cartridge::test_helpers::banked_data;

    const PRG_BANKS_16K: usize = 48;
    const CHR_BANKS_8K: usize = 16;

    fn make_mapper() -> Mapper335 {
        Mapper335::new(MapperContext::new_for_test(
            MAPPER_NUMBER,
            banked_data(PRG_BANK_SIZE_BYTES, PRG_BANKS_16K),
            banked_data(CHR_BANK_SIZE_BYTES, CHR_BANKS_8K),
            NametableLayout::Vertical,
        ))
    }

    // ── Factory registration ──────────────────────────────────────────────────

    #[test]
    fn mapper_335_is_registered_in_factory() {
        let result = create_mapper(MapperContext::new_for_test(
            MAPPER_NUMBER,
            banked_data(PRG_BANK_SIZE_BYTES, PRG_BANKS_16K),
            banked_data(CHR_BANK_SIZE_BYTES, CHR_BANKS_8K),
            NametableLayout::Vertical,
        ));
        assert!(result.is_ok(), "Mapper 335 must be registered in factory");
    }

    // ── Power-on / reset state ────────────────────────────────────────────────

    #[test]
    fn power_on_prg_banks_are_0_and_1_with_vertical_mirroring() {
        let mapper = make_mapper();
        assert_eq!(mapper.read_prg(0x8000), 0, "$8000 should be PRG bank 0");
        assert_eq!(mapper.read_prg(0xC000), 1, "$C000 should be PRG bank 1");
        assert_eq!(
            mapper.get_mirroring(),
            NametableLayout::Vertical,
            "mirroring should be vertical at power-on"
        );
    }

    #[test]
    fn power_on_chr_bank_is_0() {
        let mut mapper = make_mapper();
        assert_eq!(
            mapper.read_chr(0x0000),
            0,
            "CHR bank should be 0 at power-on"
        );
    }

    // ── PRG banking: NROM-256 mode (bit 4 clear) ─────────────────────────────

    #[test]
    fn nrom256_mode_prg_bank_3_gives_pages_6_and_7() {
        // prg_reg = 0x03: bit4=0 → NROM-256; bank = 3 → page0 = 6, page1 = 7
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x03);
        assert_eq!(mapper.read_prg(0x8000), 6, "$8000 should be 16KB page 6");
        assert_eq!(mapper.read_prg(0xC000), 7, "$C000 should be 16KB page 7");
    }

    #[test]
    fn nrom256_mode_prg_bank_5_gives_pages_10_and_11() {
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x05);
        assert_eq!(mapper.read_prg(0x8000), 10, "$8000 should be 16KB page 10");
        assert_eq!(mapper.read_prg(0xC000), 11, "$C000 should be 16KB page 11");
    }

    #[test]
    fn nrom256_mode_upper_prg_bits_are_ignored() {
        // Only bits [2:0] are used for bank in NROM-256 mode
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x43); // bit 6 set, bits [2:0] = 3 → pages 6/7
        assert_eq!(mapper.read_prg(0x8000), 6);
        assert_eq!(mapper.read_prg(0xC000), 7);
    }

    // ── PRG banking: NROM-128 mode (bit 4 set) ───────────────────────────────

    #[test]
    fn nrom128_mode_both_windows_use_same_bank() {
        // prg_reg = 0x10: bit4=1 → NROM-128; bits[2:0]=0, bit3=0 → bank=(0<<1)|0=0
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x10);
        let bank8 = mapper.read_prg(0x8000);
        let bankc = mapper.read_prg(0xC000);
        assert_eq!(
            bank8, bankc,
            "$8000 and $C000 must use the same bank in NROM-128"
        );
    }

    #[test]
    fn nrom128_bank_formula_uses_bits2_0_and_bit3() {
        // prg_reg = 0x1B: bit4=1, bits[2:0]=3, bit3=1 → bank=(3<<1)|1=7
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x1B);
        assert_eq!(mapper.read_prg(0x8000), 7, "NROM-128 bank should be 7");
        assert_eq!(mapper.read_prg(0xC000), 7, "$C000 should also be bank 7");
    }

    #[test]
    fn nrom128_bank_with_bits2_0_eq_2_and_bit3_set_gives_bank_5() {
        // prg_reg = 0x1A: bit4=1, bits[2:0]=2, bit3=1 → bank=(2<<1)|1=5
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x1A);
        assert_eq!(mapper.read_prg(0x8000), 5, "NROM-128 bank should be 5");
        assert_eq!(mapper.read_prg(0xC000), 5, "$C000 should also be bank 5");
    }

    #[test]
    fn nrom128_bank_with_bits2_0_eq_1_and_bit3_clear_gives_bank_2() {
        // prg_reg = 0x11: bit4=1, bits[2:0]=1, bit3=0 → bank=(1<<1)|0=2
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x11);
        assert_eq!(mapper.read_prg(0x8000), 2, "NROM-128 bank should be 2");
        assert_eq!(mapper.read_prg(0xC000), 2, "$C000 should also be bank 2");
    }

    // ── Write handlers ────────────────────────────────────────────────────────

    #[test]
    fn writes_below_8000_do_not_change_prg_or_chr_banks() {
        let mut mapper = make_mapper();
        // Establish a known non-default state first
        mapper.write_prg(0xC000, 0x03); // PRG pages 6/7
        mapper.write_prg(0x8000, 0x05); // CHR bank 5
        // Writes in the $4020-$7FFF range must be silently ignored
        mapper.write_prg(0x4020, 0xFF);
        mapper.write_prg(0x6000, 0xFF);
        mapper.write_prg(0x7FFF, 0xFF);
        assert_eq!(
            mapper.read_prg(0x8000),
            6,
            "PRG $8000 should remain 6 after writes below $8000"
        );
        assert_eq!(
            mapper.read_prg(0xC000),
            7,
            "PRG $C000 should remain 7 after writes below $8000"
        );
        assert_eq!(
            mapper.read_chr(0x0000),
            5,
            "CHR bank should remain 5 after writes below $8000"
        );
    }

    #[test]
    fn writes_to_8000_bfff_change_chr_bank() {
        let mut mapper = make_mapper();
        mapper.write_prg(0x8000, 0x05);
        assert_eq!(mapper.read_chr(0x0000), 5, "CHR should switch to bank 5");
    }

    #[test]
    fn writes_to_c000_ffff_change_prg_bank() {
        let mut mapper = make_mapper();
        mapper.write_prg(0xFFFF, 0x02);
        assert_eq!(mapper.read_prg(0x8000), 4, "$8000 should be PRG page 4");
        assert_eq!(mapper.read_prg(0xC000), 5, "$C000 should be PRG page 5");
    }

    #[test]
    fn chr_write_does_not_affect_prg_banks() {
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x03); // PRG bank 3 → pages 6/7
        mapper.write_prg(0x8000, 0x07); // CHR bank change
        assert_eq!(mapper.read_prg(0x8000), 6, "PRG should remain at page 6");
        assert_eq!(mapper.read_prg(0xC000), 7, "PRG should remain at page 7");
    }

    #[test]
    fn prg_write_does_not_affect_chr_bank() {
        let mut mapper = make_mapper();
        mapper.write_prg(0x8000, 0x0A); // CHR bank 10
        mapper.write_prg(0xC000, 0x05); // PRG change
        assert_eq!(mapper.read_chr(0x0000), 10, "CHR should remain at bank 10");
    }

    // ── CHR banking ───────────────────────────────────────────────────────────

    #[test]
    fn chr_bank_register_uses_only_low_4_bits() {
        let mut mapper = make_mapper();
        mapper.write_prg(0x8000, 0xF5); // bits[3:0] = 5
        assert_eq!(
            mapper.read_chr(0x0000),
            5,
            "CHR should be bank 5 (bits[3:0])"
        );
    }

    #[test]
    fn chr_bank_15_is_selectable() {
        let mut mapper = make_mapper();
        mapper.write_prg(0x8000, 0x0F);
        assert_eq!(
            mapper.read_chr(0x0000),
            15,
            "CHR bank 15 should be selectable"
        );
    }

    // ── Mirroring ─────────────────────────────────────────────────────────────

    #[test]
    fn prg_bit5_set_gives_horizontal_mirroring() {
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x20); // bit 5 = 1
        assert_eq!(
            mapper.get_mirroring(),
            NametableLayout::Horizontal,
            "bit5=1 should select horizontal mirroring"
        );
    }

    #[test]
    fn prg_bit5_clear_gives_vertical_mirroring() {
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x20); // set horizontal
        mapper.write_prg(0xC000, 0x00); // clear bit 5
        assert_eq!(
            mapper.get_mirroring(),
            NametableLayout::Vertical,
            "bit5=0 should select vertical mirroring"
        );
    }

    // ── Snapshot / restore ────────────────────────────────────────────────────

    #[test]
    fn snapshot_restore_preserves_prg_chr_and_mirroring() {
        let mut mapper = make_mapper();
        // prg_reg = 0x35: bit5=1(H), bit4=1(NROM-128), bit3=0, bits[2:0]=5 → bank=(5<<1)|0=10
        mapper.write_prg(0xC000, 0x35);
        mapper.write_prg(0x8000, 0x0C); // chr_reg: bank 12
        let snap = mapper.registers_snapshot();

        let mut restored = make_mapper();
        restored.restore_registers(&snap);

        assert_eq!(
            restored.read_prg(0x8000),
            10,
            "restored PRG bank should be 10"
        );
        assert_eq!(
            restored.read_prg(0xC000),
            10,
            "restored PRG $C000 should be 10 (NROM-128)"
        );
        assert_eq!(
            restored.read_chr(0x0000),
            12,
            "restored CHR bank should be 12"
        );
        assert_eq!(
            restored.get_mirroring(),
            NametableLayout::Horizontal,
            "restored mirroring should be horizontal"
        );
    }

    #[test]
    fn reset_restores_power_on_state() {
        let mut mapper = make_mapper();
        mapper.write_prg(0xC000, 0x25);
        mapper.write_prg(0x8000, 0x0C);
        mapper.reset();
        assert_eq!(mapper.read_prg(0x8000), 0);
        assert_eq!(mapper.read_prg(0xC000), 1);
        assert_eq!(mapper.read_chr(0x0000), 0);
        assert_eq!(mapper.get_mirroring(), NametableLayout::Vertical);
    }

    // ── Capabilities ──────────────────────────────────────────────────────────

    #[test]
    fn capabilities_match_specification() {
        let mapper = make_mapper();
        let caps = mapper.capabilities();
        assert!(!caps.has_irq);
        assert!(!caps.has_expansion_audio);
        assert!(caps.has_dynamic_mirroring);
        assert!(caps.has_chr_banking);
        assert_eq!(caps.prg_bank_size_kb, 16);
        assert_eq!(caps.chr_bank_size_kb, 8);
        assert_eq!(caps.max_prg_ram_kb, 0);
    }
}