malvin 0.2.6

Non-interactive research and coding agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171

use crate::cli::admin_cmd::AdminArgs;
use crate::cli::args::{Cli, Commands};
use crate::cli::shared_opts::{RouterOpts, SharedOpts};
use crate::model_id::ParsedModel;

#[derive(Debug)]
pub(crate) enum MalvinWorkflow {
    Do {
        request: Option<String>,
        shared: SharedOpts,
    },
    Admin {
        admin: AdminArgs,
        model: ParsedModel,
    },
    DefaultRoute {
        request: String,
        shared: SharedOpts,
        router: RouterOpts,
    },
    GatesOnly {
        shared: SharedOpts,
        router: RouterOpts,
    },
}

#[must_use]
pub(crate) fn malvin_workflow_from_cli(cli: Cli) -> Option<MalvinWorkflow> {
    if cli.do_workflow {
        return Some(MalvinWorkflow::Do {
            request: cli.request,
            shared: cli.shared,
        });
    }
    if let Some(Commands::Admin(admin)) = cli.command {
        return Some(MalvinWorkflow::Admin {
            admin,
            model: cli.shared.model,
        });
    }
    if let Some(request) = cli.request {
        return Some(MalvinWorkflow::DefaultRoute {
            request,
            shared: cli.shared,
            router: cli.router,
        });
    }
    if cli.router.gates {
        return Some(MalvinWorkflow::GatesOnly {
            shared: cli.shared,
            router: cli.router,
        });
    }
    None
}

#[cfg(test)]
mod tests {
    use super::{MalvinWorkflow, malvin_workflow_from_cli};
    use crate::cli::Cli;
    use clap::Parser;

    #[test]
    fn do_workflow_omits_loop_budgets_and_router_opts_from_payload() {
        let cli = Cli::try_parse_from(["malvin", "--do", "fix it"]).expect("parse");
        let workflow = malvin_workflow_from_cli(cli).expect("do workflow");
        match workflow {
            MalvinWorkflow::Do { request, shared: _ } => {
                assert_eq!(request.as_deref(), Some("fix it"));
            }
            MalvinWorkflow::Admin { .. }
            | MalvinWorkflow::DefaultRoute { .. }
            | MalvinWorkflow::GatesOnly { .. } => {
                panic!("expected Do variant without loop-budget or router fields")
            }
        }
    }

    #[test]
    fn do_workflow_payload_has_no_router_fields() {
        // Compile-time shape check: Do carries SharedOpts only (no RouterOpts / quiet).
        let cli = Cli::try_parse_from(["malvin", "--do", "x"]).expect("parse");
        let workflow = malvin_workflow_from_cli(cli).expect("do");
        let MalvinWorkflow::Do { shared, .. } = workflow else {
            panic!("expected Do");
        };
        let _ = shared.model;
        let _ = shared.verbose;
        let _ = shared.max_acp_retries;
        // quiet lives on RouterOpts; SharedOpts has no quiet field after the peel.
    }

    #[test]
    fn default_route_carries_quiet_on_router_opts() {
        let cli = Cli::try_parse_from(["malvin", "-q", "build it"]).expect("parse");
        let workflow = malvin_workflow_from_cli(cli).expect("default route");
        match workflow {
            MalvinWorkflow::DefaultRoute { router, .. } => {
                assert!(router.quiet);
            }
            other => panic!("expected DefaultRoute, got {other:?}"),
        }
    }

    #[test]
    fn default_route_carries_loop_budgets_and_router_opts() {
        let cli = Cli::try_parse_from([
            "malvin",
            "--max-loops",
            "4",
            "--max-hypotheses",
            "7",
            "--creative=0.5",
            "build it",
        ])
        .expect("parse");
        let workflow = malvin_workflow_from_cli(cli).expect("default route");
        match workflow {
            MalvinWorkflow::DefaultRoute {
                request,
                router,
                ..
            } => {
                assert_eq!(request, "build it");
                assert_eq!(router.max_loops, 4);
                assert_eq!(router.max_hypotheses, 7);
                assert_eq!(router.creative, Some(0.5));
                assert!(!router.gates);
            }
            other => panic!("expected DefaultRoute, got {other:?}"),
        }
    }

    #[test]
    fn gates_only_carries_loop_budgets_without_request() {
        let cli = Cli::try_parse_from(["malvin", "-g", "--max-loops", "2"]).expect("parse");
        let workflow = malvin_workflow_from_cli(cli).expect("gates only");
        match workflow {
            MalvinWorkflow::GatesOnly { router, .. } => {
                assert!(router.gates);
                assert_eq!(router.max_loops, 2);
            }
            other => panic!("expected GatesOnly, got {other:?}"),
        }
    }

    #[test]
    fn empty_cli_maps_to_none() {
        let cli = Cli::try_parse_from(["malvin"]).expect("parse");
        assert!(malvin_workflow_from_cli(cli).is_none());
    }

    #[test]
    fn admin_workflow_payload_carries_model_only() {
        let cli = Cli::try_parse_from([
            "malvin",
            "--model",
            "cursor:auto",
            "admin",
            "models",
        ])
        .expect("parse");
        let workflow = malvin_workflow_from_cli(cli).expect("admin workflow");
        match workflow {
            MalvinWorkflow::Admin { model, .. } => {
                assert_eq!(model.canonical(), "cursor:auto");
            }
            other => panic!("expected Admin, got {other:?}"),
        }
    }
}