malvin 0.2.6

Non-interactive research and coding agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110

use clap::ArgMatches;

use crate::reliability_tier::ReliabilityTier;

use super::config_defaults::global_flag_from_command_line;

pub const TENACIOUS_MAX_LOOPS: usize = 9999;
pub const TENACIOUS_MAX_ACP_RETRIES: u32 = 9999;

pub struct TenaciousBudgetGuard {
    pub max_loops_explicit: bool,
    pub max_acp_retries_explicit: bool,
}

pub fn apply_default_route_tenacious(
    max_loops: &mut usize,
    max_acp_retries: &mut u32,
    matches: &ArgMatches,
) {
    apply_tenacious(
        max_loops,
        max_acp_retries,
        ReliabilityTier::Tenacious,
        TenaciousBudgetGuard {
            max_loops_explicit: global_flag_from_command_line(matches, "max_loops"),
            max_acp_retries_explicit: global_flag_from_command_line(matches, "max_acp_retries"),
        },
    );
}

#[allow(clippy::missing_const_for_fn)]
pub fn apply_tenacious(
    max_loops: &mut usize,
    _max_acp_retries: &mut u32,
    tier: ReliabilityTier,
    guard: TenaciousBudgetGuard,
) {
    let _ = guard.max_acp_retries_explicit;
    if tier == ReliabilityTier::Tenacious && !guard.max_loops_explicit {
        *max_loops = TENACIOUS_MAX_LOOPS;
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn apply_tenacious_sets_large_budgets() {
        let mut loops = 1usize;
        let mut retries = 3u32;
        apply_tenacious(
            &mut loops,
            &mut retries,
            ReliabilityTier::Tenacious,
            TenaciousBudgetGuard {
                max_loops_explicit: false,
                max_acp_retries_explicit: false,
            },
        );
        assert_eq!(loops, TENACIOUS_MAX_LOOPS);
        assert_eq!(retries, 3);
    }

    #[test]
    fn apply_tenacious_skips_explicit_max_loops() {
        let mut loops = 3usize;
        let mut retries = 3u32;
        apply_tenacious(
            &mut loops,
            &mut retries,
            ReliabilityTier::Tenacious,
            TenaciousBudgetGuard {
                max_loops_explicit: true,
                max_acp_retries_explicit: false,
            },
        );
        assert_eq!(loops, 3);
        assert_eq!(retries, 3);
    }

    #[test]
    fn apply_default_route_tenacious_expands_unless_opted_out() {
        use crate::cli::Cli;
        use clap::CommandFactory;
        let matches = Cli::command().get_matches_from(["malvin", "topic"]);
        let mut loops = 1usize;
        let mut retries = 3u32;
        apply_default_route_tenacious(&mut loops, &mut retries, &matches);
        assert_eq!(loops, TENACIOUS_MAX_LOOPS);
        assert_eq!(retries, 3);
    }

    #[test]
    fn apply_tenacious_conservative_leaves_budgets() {
        let mut loops = 3usize;
        let mut retries = 5u32;
        apply_tenacious(
            &mut loops,
            &mut retries,
            ReliabilityTier::Conservative,
            TenaciousBudgetGuard {
                max_loops_explicit: false,
                max_acp_retries_explicit: false,
            },
        );
        assert_eq!(loops, 3);
        assert_eq!(retries, 5);
    }
}