malvin 0.2.6

Non-interactive research and coding agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155

use super::{Commands, Exit, entrypoint_from};

fn git_flag_is_rejected_by_clap() {
    use clap::Parser;
    let err = crate::cli::Cli::try_parse_from(["malvin", "--git", "--doc"])
        .expect_err("--git must be rejected");
    let msg = err.to_string();
    assert!(
        msg.contains("unexpected") || msg.contains("unknown") || msg.contains("--git"),
        "clap must reject --git; got {msg}"
    );
}

fn help_omits_git_flag() {
    use clap::CommandFactory;
    let help = crate::cli::Cli::command().render_help().to_string();
    assert!(!help.contains("--git"), "help={help}");
}

fn shared_opts_parses_creative_flag_default_off() {
    use clap::Parser;
    let cli = crate::cli::Cli::try_parse_from(["malvin", "--doc"]).expect("parse");
    assert!(cli.router.creative.is_none());
}

fn shared_opts_parses_creative_flag_on() {
    use clap::Parser;
    let cli = crate::cli::Cli::try_parse_from(["malvin", "--creative", "--doc"]).expect("parse");
    assert_eq!(cli.router.creative, Some(1.0));
}

fn help_lists_creative_flag() {
    use clap::CommandFactory;
    let help = crate::cli::Cli::command().render_help().to_string();
    assert!(help.contains("--creative"), "help={help}");
}

fn shared_opts_parses_no_kpop_flag_default_off() {
    use clap::Parser;
    let cli = crate::cli::Cli::try_parse_from(["malvin", "--doc"]).expect("parse");
    assert!(!cli.router.no_kpop);
}

fn shared_opts_parses_no_kpop_flag_on() {
    use clap::Parser;
    let cli = crate::cli::Cli::try_parse_from(["malvin", "--no-kpop", "--doc"]).expect("parse");
    assert!(cli.router.no_kpop);
}

fn help_hides_no_kpop_flag() {
    use clap::CommandFactory;
    let help = crate::cli::Cli::command().render_help().to_string();
    assert!(
        !help.contains("--no-kpop"),
        "hidden --no-kpop must not appear in help: {help}"
    );
}

fn help_omits_name_flag() {
    use clap::CommandFactory;
    let help = crate::cli::Cli::command().render_help().to_string();
    assert!(
        !help.contains("--name"),
        "help must not list removed --name: {help}"
    );
}

fn doc_does_not_create_name_files() {
    crate::test_utils::with_isolated_home(|work| {
        let _ = work;
        let root = crate::names_registry_root();
        assert_eq!(entrypoint_from(["malvin", "--doc"]), Exit::Success);
        assert!(
            !root.exists()
                || std::fs::read_dir(&root)
                    .expect("read names")
                    .next()
                    .is_none(),
            "doc must not create name files"
        );
    });
}

fn bare_help_does_not_create_name_files() {
    crate::test_utils::with_isolated_home(|work| {
        let _ = work;
        let root = crate::names_registry_root();
        assert_eq!(entrypoint_from(["malvin"]), Exit::Success);
        assert!(
            !root.exists()
                || std::fs::read_dir(&root)
                    .expect("read names")
                    .next()
                    .is_none(),
            "bare help must not create name files"
        );
    });
}

fn do_workflow_parses_without_name_flag() {
    use crate::cli::config_defaults::parse_cli_with_config_defaults;

    crate::test_utils::with_isolated_home(|_| {
        let (cli, _) =
            parse_cli_with_config_defaults(["malvin", "--do", "say hello"]).expect("parse --do");
        assert!(cli.do_workflow);
        assert_eq!(cli.request.as_deref(), Some("say hello"));
        assert!(cli.command.is_none());
    });
}

fn gates_only_route_needs_session() {
    use clap::Parser;
    assert!(crate::cli::config_defaults::is_gates_only_route(
        &crate::cli::Cli::try_parse_from(["malvin", "-g"]).expect("parse")
    ));
}

fn admin_command_is_not_gates_only() {
    use crate::cli::{AdminArgs, AdminCommand};
    use crate::cli::models_cmd::ModelsArgs;
    let _ = Commands::Admin(AdminArgs {
        command: AdminCommand::Models(ModelsArgs::default()),
    });
}

fn name_flag_is_rejected_by_clap() {
    use clap::Parser;
    let err = crate::cli::Cli::try_parse_from(["malvin", "--name", "probe", "--doc"])
        .expect_err("--name must be unknown");
    let msg = err.to_string();
    assert!(
        msg.contains("unexpected") || msg.contains("unknown") || msg.contains("--name"),
        "clap must reject --name; got: {msg}"
    );
}

#[test]
fn kiss_bundled_cli_entrypoint_name_tests() {
    git_flag_is_rejected_by_clap();
    help_omits_git_flag();
    shared_opts_parses_creative_flag_default_off();
    shared_opts_parses_creative_flag_on();
    help_lists_creative_flag();
    shared_opts_parses_no_kpop_flag_default_off();
    shared_opts_parses_no_kpop_flag_on();
    help_hides_no_kpop_flag();
    help_omits_name_flag();
    doc_does_not_create_name_files();
    bare_help_does_not_create_name_files();
    do_workflow_parses_without_name_flag();
    gates_only_route_needs_session();
    admin_command_is_not_gates_only();
    name_flag_is_rejected_by_clap();
}