malvin 0.2.6

Non-interactive research and coding agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149

use clap::Parser;

use crate::cli::Cli;
use crate::config::DEFAULT_MAX_ACP_RETRIES;

fn cli_accepts_do_and_passes_request() {
    let cli = Cli::try_parse_from(["malvin", "--do", "fix the bug"]).expect("parse");
    assert!(cli.do_workflow);
    assert_eq!(cli.request.as_deref(), Some("fix the bug"));
    assert!(cli.command.is_none());
}

fn cli_rejects_do_thoughts_flag() {
    let err = Cli::try_parse_from(["malvin", "--do", "--thoughts", "z"]).expect_err("parse");
    let msg = err.to_string();
    assert!(
        msg.contains("unexpected argument") || msg.contains("--thoughts"),
        "expected --thoughts rejected; got {msg}"
    );
}

fn cli_accepts_all_shared_flags_before_subcommand() {
    let cli = Cli::try_parse_from([
        "malvin",
        "--model",
        "cursor:composer-2",
        "--do",
        "z",
    ])
    .expect("parse");
    assert_eq!(cli.shared.model.canonical(), "cursor:composer-2");
    assert!(cli.do_workflow);
    assert_eq!(cli.request.as_deref(), Some("z"));
}

fn cli_rejects_max_loops_with_do() {
    let err =
        Cli::try_parse_from(["malvin", "--do", "--max-loops", "5", "task"]).expect_err("parse");
    let msg = err.to_string();
    assert!(
        msg.contains("cannot be used with") || msg.contains("--max-loops"),
        "expected --max-loops conflict rejected; got {msg}"
    );

    let err2 =
        Cli::try_parse_from(["malvin", "--max-loops", "5", "--do", "task"]).expect_err("parse");
    let msg2 = err2.to_string();
    assert!(
        msg2.contains("cannot be used with") || msg2.contains("--max-loops"),
        "expected --max-loops conflict rejected; got {msg2}"
    );
}

fn cli_rejects_gates_with_do() {
    let err = Cli::try_parse_from(["malvin", "--do", "-g", "task"]).expect_err("parse");
    let msg = err.to_string();
    assert!(
        msg.contains("cannot be used with") || msg.contains("--gates") || msg.contains("-g"),
        "expected --gates conflict rejected; got {msg}"
    );

    let err2 = Cli::try_parse_from(["malvin", "--gates", "--do", "task"]).expect_err("parse");
    let msg2 = err2.to_string();
    assert!(
        msg2.contains("cannot be used with") || msg2.contains("--gates"),
        "expected --gates conflict rejected; got {msg2}"
    );
}

fn cli_rejects_creative_with_do() {
    let err =
        Cli::try_parse_from(["malvin", "--do", "--creative=0.8", "task"]).expect_err("parse");
    let msg = err.to_string();
    assert!(
        msg.contains("cannot be used with") || msg.contains("--creative"),
        "expected --creative conflict rejected; got {msg}"
    );
}

fn cli_rejects_max_hypotheses_with_do() {
    let err = Cli::try_parse_from(["malvin", "--do", "--max-hypotheses", "10", "task"])
        .expect_err("parse");
    let msg = err.to_string();
    assert!(
        msg.contains("cannot be used with") || msg.contains("--max-hypotheses"),
        "expected --max-hypotheses conflict rejected; got {msg}"
    );
}

fn cli_rejects_no_kpop_with_do() {
    let err = Cli::try_parse_from(["malvin", "--do", "--no-kpop", "task"]).expect_err("parse");
    let msg = err.to_string();
    assert!(
        msg.contains("cannot be used with") || msg.contains("--no-kpop"),
        "expected --no-kpop conflict rejected; got {msg}"
    );
}

fn cli_rejects_quiet_with_do() {
    let err = Cli::try_parse_from(["malvin", "--do", "-q", "task"]).expect_err("parse");
    let msg = err.to_string();
    assert!(
        msg.contains("cannot be used with") || msg.contains("--quiet") || msg.contains("-q"),
        "expected --quiet conflict rejected; got {msg}"
    );

    let err2 = Cli::try_parse_from(["malvin", "--quiet", "--do", "task"]).expect_err("parse");
    let msg2 = err2.to_string();
    assert!(
        msg2.contains("cannot be used with") || msg2.contains("--quiet"),
        "expected --quiet conflict rejected; got {msg2}"
    );
}

fn cli_accepts_max_acp_retries_global_flag() {
    let cli = Cli::try_parse_from(["malvin", "--do", "task"]).expect("parse");
    assert_eq!(cli.shared.max_acp_retries, DEFAULT_MAX_ACP_RETRIES);

    let cli =
        Cli::try_parse_from(["malvin", "--max-acp-retries", "5", "--do", "task"]).expect("parse");
    assert_eq!(cli.shared.max_acp_retries, 5);
}

fn cli_accepts_verbose_short_and_long_global_flags() {
    let cli = Cli::try_parse_from(["malvin", "-v", "--do", "x"]).expect("parse");
    assert!(cli.shared.verbose);
    assert!(cli.do_workflow);
    assert_eq!(cli.request.as_deref(), Some("x"));

    let cli = Cli::try_parse_from(["malvin", "--do", "--verbose", "y"]).expect("parse");
    assert!(cli.shared.verbose);
    assert!(cli.do_workflow);
    assert_eq!(cli.request.as_deref(), Some("y"));
}

#[test]
fn kiss_bundled_cli_do_flow_cli_parse_tests() {
    cli_accepts_do_and_passes_request();
    cli_rejects_do_thoughts_flag();
    cli_accepts_all_shared_flags_before_subcommand();
    cli_rejects_max_loops_with_do();
    cli_rejects_gates_with_do();
    cli_rejects_creative_with_do();
    cli_rejects_no_kpop_with_do();
    cli_rejects_quiet_with_do();
    cli_rejects_max_hypotheses_with_do();
    cli_accepts_max_acp_retries_global_flag();
    cli_accepts_verbose_short_and_long_global_flags();
}