clippy 0.0.124

A bunch of helpful lints to avoid common pitfalls in Rust
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159

error: this loop could be written as a `while let` loop
  --> $DIR/while_loop.rs:9:5
   |
9  |       loop {
   |  _____^ starting here...
10 | |
11 | |
12 | |
...  |
17 | |         }
18 | |     }
   | |_____^ ...ending here
   |
note: lint level defined here
  --> $DIR/while_loop.rs:4:9
   |
4  | #![deny(while_let_loop, empty_loop, while_let_on_iterator)]
   |         ^^^^^^^^^^^^^^
help: try
   |     while let Some(_x) = y { .. }

error: this loop could be written as a `while let` loop
  --> $DIR/while_loop.rs:25:5
   |
25 |       loop {
   |  _____^ starting here...
26 | |
27 | |
28 | |
...  |
32 | |         };
33 | |     }
   | |_____^ ...ending here
   |
help: try
   |     while let Some(_x) = y { .. }

error: this loop could be written as a `while let` loop
  --> $DIR/while_loop.rs:34:5
   |
34 |       loop {
   |  _____^ starting here...
35 | |
36 | |
37 | |
...  |
43 | |         let _str = "foo";
44 | |     }
   | |_____^ ...ending here
   |
help: try
   |     while let Some(x) = y { .. }

error: this loop could be written as a `while let` loop
  --> $DIR/while_loop.rs:45:5
   |
45 |       loop {
   |  _____^ starting here...
46 | |
47 | |
48 | |
...  |
54 | |         { let _b = "foobar"; }
55 | |     }
   | |_____^ ...ending here
   |
help: try
   |     while let Some(x) = y { .. }

error: this loop could be written as a `while let` loop
  --> $DIR/while_loop.rs:70:5
   |
70 |       loop {
   |  _____^ starting here...
71 | |
72 | |
73 | |
...  |
79 | |         let _ = (e, l);
80 | |     }
   | |_____^ ...ending here
   |
help: try
   |     while let Some(word) = "".split_whitespace().next() { .. }

error: this loop could be written as a `for` loop
  --> $DIR/while_loop.rs:83:5
   |
83 |       while let Option::Some(x) = iter.next() {
   |  _____^ starting here...
84 | |
85 | |
86 | |
87 | |         println!("{}", x);
88 | |     }
   | |_____^ ...ending here
   |
note: lint level defined here
  --> $DIR/while_loop.rs:4:37
   |
4  | #![deny(while_let_loop, empty_loop, while_let_on_iterator)]
   |                                     ^^^^^^^^^^^^^^^^^^^^^
help: try
   |     for x in iter { .. }

error: this loop could be written as a `for` loop
  --> $DIR/while_loop.rs:91:5
   |
91 |       while let Some(x) = iter.next() {
   |  _____^ starting here...
92 | |
93 | |
94 | |
95 | |         println!("{}", x);
96 | |     }
   | |_____^ ...ending here
   |
help: try
   |     for x in iter { .. }

error: this loop could be written as a `for` loop
  --> $DIR/while_loop.rs:99:5
   |
99 |     while let Some(_) = iter.next() {}
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: try
   |     for _ in iter { .. }

error: this loop could be written as a `while let` loop
   --> $DIR/while_loop.rs:142:5
    |
142 |       loop {
    |  _____^ starting here...
143 | |
144 | |
145 | |
...   |
150 | |         loop {}
151 | |     }
    | |_____^ ...ending here
    |
help: try
    |     while let Some(ele) = iter.next() { .. }

error: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body.
   --> $DIR/while_loop.rs:150:9
    |
150 |         loop {}
    |         ^^^^^^^
    |
note: lint level defined here
   --> $DIR/while_loop.rs:4:25
    |
4   | #![deny(while_let_loop, empty_loop, while_let_on_iterator)]
    |                         ^^^^^^^^^^

error: aborting due to 10 previous errors