clippy 0.0.124

A bunch of helpful lints to avoid common pitfalls in Rust
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51

error: called `filter(p).map(q)` on an `Iterator`. This is more succinctly expressed by calling `.filter_map(..)` instead.
  --> $DIR/filter_methods.rs:8:21
   |
8  |       let _: Vec<_> = vec![5; 6].into_iter()
   |  _____________________^ starting here...
9  | |                               .filter(|&x| x == 0)
10 | |                               .map(|x| x * 2)
   | |_____________________________________________^ ...ending here
   |
   = note: #[deny(filter_map)] implied by #[deny(clippy_pedantic)]
note: lint level defined here
  --> $DIR/filter_methods.rs:4:17
   |
4  | #![deny(clippy, clippy_pedantic)]
   |                 ^^^^^^^^^^^^^^^

error: called `filter(p).flat_map(q)` on an `Iterator`. This is more succinctly expressed by calling `.flat_map(..)` and filtering by returning an empty Iterator.
  --> $DIR/filter_methods.rs:13:21
   |
13 |       let _: Vec<_> = vec![5_i8; 6].into_iter()
   |  _____________________^ starting here...
14 | |                                 .filter(|&x| x == 0)
15 | |                                 .flat_map(|x| x.checked_mul(2))
   | |_______________________________________________________________^ ...ending here
   |
   = note: #[deny(filter_map)] implied by #[deny(clippy_pedantic)]

error: called `filter_map(p).flat_map(q)` on an `Iterator`. This is more succinctly expressed by calling `.flat_map(..)` and filtering by returning an empty Iterator.
  --> $DIR/filter_methods.rs:18:21
   |
18 |       let _: Vec<_> = vec![5_i8; 6].into_iter()
   |  _____________________^ starting here...
19 | |                                 .filter_map(|x| x.checked_mul(2))
20 | |                                 .flat_map(|x| x.checked_mul(2))
   | |_______________________________________________________________^ ...ending here
   |
   = note: #[deny(filter_map)] implied by #[deny(clippy_pedantic)]

error: called `filter_map(p).map(q)` on an `Iterator`. This is more succinctly expressed by only calling `.filter_map(..)` instead.
  --> $DIR/filter_methods.rs:23:21
   |
23 |       let _: Vec<_> = vec![5_i8; 6].into_iter()
   |  _____________________^ starting here...
24 | |                                 .filter_map(|x| x.checked_mul(2))
25 | |                                 .map(|x| x.checked_mul(2))
   | |__________________________________________________________^ ...ending here
   |
   = note: #[deny(filter_map)] implied by #[deny(clippy_pedantic)]

error: aborting due to 4 previous errors