clippy 0.0.124

A bunch of helpful lints to avoid common pitfalls in Rust
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80

error: you added something to a string. Consider using `String::push_str()` instead
  --> $DIR/strings.rs:10:13
   |
10 |         x = x + ".";
   |             ^^^^^^^
   |
note: lint level defined here
  --> $DIR/strings.rs:4:8
   |
4  | #[deny(string_add)]
   |        ^^^^^^^^^^

error: you added something to a string. Consider using `String::push_str()` instead
  --> $DIR/strings.rs:14:13
   |
14 |     let z = y + "...";
   |             ^^^^^^^^^

error: you assigned the result of adding something to this string. Consider using `String::push_str()` instead
  --> $DIR/strings.rs:24:9
   |
24 |         x = x + ".";
   |         ^^^^^^^^^^^
   |
note: lint level defined here
  --> $DIR/strings.rs:19:8
   |
19 | #[deny(string_add_assign)]
   |        ^^^^^^^^^^^^^^^^^

error: you assigned the result of adding something to this string. Consider using `String::push_str()` instead
  --> $DIR/strings.rs:38:9
   |
38 |         x = x + ".";
   |         ^^^^^^^^^^^
   |
note: lint level defined here
  --> $DIR/strings.rs:33:20
   |
33 | #[deny(string_add, string_add_assign)]
   |                    ^^^^^^^^^^^^^^^^^

error: you added something to a string. Consider using `String::push_str()` instead
  --> $DIR/strings.rs:42:13
   |
42 |     let z = y + "...";
   |             ^^^^^^^^^
   |
note: lint level defined here
  --> $DIR/strings.rs:33:8
   |
33 | #[deny(string_add, string_add_assign)]
   |        ^^^^^^^^^^

error: calling `as_bytes()` on a string literal
  --> $DIR/strings.rs:50:14
   |
50 |     let bs = "hello there".as_bytes();
   |              ^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: lint level defined here
  --> $DIR/strings.rs:48:8
   |
48 | #[deny(string_lit_as_bytes)]
   |        ^^^^^^^^^^^^^^^^^^^
help: consider using a byte string literal instead
   |     let bs = b"hello there";

warning: manual implementation of an assign operation
  --> $DIR/strings.rs:68:7
   |
68 |     ; x = x + 1;
   |       ^^^^^^^^^
   |
   = note: #[warn(assign_op_pattern)] on by default
help: replace it with
   |     ; x += 1;

error: aborting due to 6 previous errors