clippy 0.0.124

A bunch of helpful lints to avoid common pitfalls in Rust
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119

error: strict comparison of f32 or f64
  --> $DIR/float_cmp.rs:43:5
   |
43 |     ONE == 1f32;
   |     ^^^^^^^^^^^
   |
note: lint level defined here
  --> $DIR/float_cmp.rs:4:9
   |
4  | #![deny(float_cmp)]
   |         ^^^^^^^^^
help: consider comparing them within some error
   |     (ONE - 1f32).abs() < error;
note: std::f32::EPSILON and std::f64::EPSILON are available.
  --> $DIR/float_cmp.rs:43:5
   |
43 |     ONE == 1f32;
   |     ^^^^^^^^^^^

error: strict comparison of f32 or f64
  --> $DIR/float_cmp.rs:47:5
   |
47 |     ONE == 1.0 + 0.0;
   |     ^^^^^^^^^^^^^^^^
   |
help: consider comparing them within some error
   |     (ONE - (1.0 + 0.0)).abs() < error;
note: std::f32::EPSILON and std::f64::EPSILON are available.
  --> $DIR/float_cmp.rs:47:5
   |
47 |     ONE == 1.0 + 0.0;
   |     ^^^^^^^^^^^^^^^^

error: strict comparison of f32 or f64
  --> $DIR/float_cmp.rs:52:5
   |
52 |     ONE + ONE == ZERO + ONE + ONE;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: consider comparing them within some error
   |     (ONE + ONE - (ZERO + ONE + ONE)).abs() < error;
note: std::f32::EPSILON and std::f64::EPSILON are available.
  --> $DIR/float_cmp.rs:52:5
   |
52 |     ONE + ONE == ZERO + ONE + ONE;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: strict comparison of f32 or f64
  --> $DIR/float_cmp.rs:57:5
   |
57 |     ONE != 2.0;
   |     ^^^^^^^^^^
   |
help: consider comparing them within some error
   |     (ONE - 2.0).abs() < error;
note: std::f32::EPSILON and std::f64::EPSILON are available.
  --> $DIR/float_cmp.rs:57:5
   |
57 |     ONE != 2.0;
   |     ^^^^^^^^^^

error: strict comparison of f32 or f64
  --> $DIR/float_cmp.rs:62:5
   |
62 |     twice(ONE) != ONE;
   |     ^^^^^^^^^^^^^^^^^
   |
help: consider comparing them within some error
   |     (twice(ONE) - ONE).abs() < error;
note: std::f32::EPSILON and std::f64::EPSILON are available.
  --> $DIR/float_cmp.rs:62:5
   |
62 |     twice(ONE) != ONE;
   |     ^^^^^^^^^^^^^^^^^

error: strict comparison of f32 or f64
  --> $DIR/float_cmp.rs:66:5
   |
66 |     ONE as f64 != 2.0;
   |     ^^^^^^^^^^^^^^^^^
   |
help: consider comparing them within some error
   |     (ONE as f64 - 2.0).abs() < error;
note: std::f32::EPSILON and std::f64::EPSILON are available.
  --> $DIR/float_cmp.rs:66:5
   |
66 |     ONE as f64 != 2.0;
   |     ^^^^^^^^^^^^^^^^^

error: strict comparison of f32 or f64
  --> $DIR/float_cmp.rs:74:5
   |
74 |     x == 1.0;
   |     ^^^^^^^^
   |
help: consider comparing them within some error
   |     (x - 1.0).abs() < error;
note: std::f32::EPSILON and std::f64::EPSILON are available.
  --> $DIR/float_cmp.rs:74:5
   |
74 |     x == 1.0;
   |     ^^^^^^^^

error: strict comparison of f32 or f64
  --> $DIR/float_cmp.rs:80:5
   |
80 |     twice(x) != twice(ONE as f64);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: consider comparing them within some error
   |     (twice(x) - twice(ONE as f64)).abs() < error;
note: std::f32::EPSILON and std::f64::EPSILON are available.
  --> $DIR/float_cmp.rs:80:5
   |
80 |     twice(x) != twice(ONE as f64);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 8 previous errors