rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98

use tree_sitter::Node;

use crate::cop::shared::node_text;
use crate::cop::{Cop, CopConfig};
use crate::correction::Correction;
use crate::diagnostic::{Diagnostic, Severity};
use crate::parse::source::SourceFile;

/// Lint/PercentStringArray — quotes/commas inside %w/%W.
pub struct PercentStringArray;

fn strip_quotes_commas(s: &str) -> String {
    let mut out = s.to_string();
    while out.ends_with(',') || out.ends_with('\'') || out.ends_with('"') {
        out.pop();
    }
    if out.starts_with('\'') || out.starts_with('"') {
        out.remove(0);
    }
    out
}

fn bad_bare_strings<'a>(source: &SourceFile, node: Node<'a>) -> Vec<Node<'a>> {
    let mut cur = node.walk();
    node.named_children(&mut cur)
        .filter(|c| c.kind() == "bare_string")
        .filter(|c| {
            let t = node_text(source, *c);
            t.contains('\'') || t.contains('"') || t.contains(',')
        })
        .collect()
}

fn apply_fixes(
    source: &SourceFile,
    cop_name: &'static str,
    offenders: &[Node<'_>],
    corr: &mut Vec<Correction>,
) {
    for child in offenders {
        let t = node_text(source, *child);
        let cleaned = strip_quotes_commas(&t);
        if cleaned != t {
            corr.push(Correction {
                start: child.start_byte(),
                end: child.end_byte(),
                replacement: cleaned,
                cop_name,
                cop_index: 0,
            });
        }
    }
}

impl Cop for PercentStringArray {
    fn name(&self) -> &'static str {
        "Lint/PercentStringArray"
    }

    fn default_severity(&self) -> Severity {
        Severity::Warning
    }

    fn supports_autocorrect(&self) -> bool {
        true
    }

    fn interested_node_kinds(&self) -> &'static [&'static str] {
        &["string_array"]
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        _config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        mut corrections: Option<&mut Vec<Correction>>,
    ) {
        let offenders = bad_bare_strings(source, node);
        if offenders.is_empty() {
            return;
        }
        let (line, col) = source.offset_to_line_col(node.start_byte());
        let mut diag = self.diagnostic(
            source,
            line,
            col,
            "Within `%w`/`%W`, quotes and ',' are unnecessary and may be unwanted in the resulting string."
                .to_string(),
        );
        if let Some(corr) = corrections.as_mut() {
            apply_fixes(source, self.name(), &offenders, corr);
            diag.corrected = true;
        }
        diagnostics.push(diag);
    }
}