rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57

//! Lint/EnsureReturn — `return` inside `ensure`.

use tree_sitter::Node;

use crate::cop::{Cop, CopConfig};
use crate::diagnostic::{Diagnostic, Severity};
use crate::parse::source::SourceFile;

pub struct EnsureReturn;

fn find_return_offsets(node: Node<'_>, out: &mut Vec<usize>) {
    if node.kind() == "return" {
        out.push(node.start_byte());
    }
    if matches!(node.kind(), "method" | "singleton_method" | "class" | "module") {
        return;
    }
    let mut cur = node.walk();
    for child in node.children(&mut cur) {
        find_return_offsets(child, out);
    }
}

impl Cop for EnsureReturn {
    fn name(&self) -> &'static str {
        "Lint/EnsureReturn"
    }

    fn default_severity(&self) -> Severity {
        Severity::Warning
    }

    fn interested_node_kinds(&self) -> &'static [&'static str] {
        &["ensure"]
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        _config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        _corrections: Option<&mut Vec<crate::correction::Correction>>,
    ) {
        let mut offsets = Vec::new();
        find_return_offsets(node, &mut offsets);
        for off in offsets {
            let (line, col) = source.offset_to_line_col(off);
            diagnostics.push(self.diagnostic(
                source,
                line,
                col,
                "Do not return from an `ensure` block.".to_string(),
            ));
        }
    }
}