rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101

use tree_sitter::Node;

use crate::cop::shared::{call_method_name, call_receiver, node_bytes, node_text};
use crate::cop::{Cop, CopConfig};
use crate::diagnostic::{Diagnostic, Severity};
use crate::parse::source::SourceFile;

/// Lint/DeprecatedOpenSSLConstant — OpenSSL::Cipher::X.new etc.
pub struct DeprecatedOpenSSLConstant;

fn scope_parts(source: &SourceFile, mut node: Node<'_>) -> Vec<Vec<u8>> {
    let mut parts = Vec::new();
    loop {
        match node.kind() {
            "scope_resolution" => {
                if let Some(name) = node.child_by_field_name("name") {
                    parts.push(node_bytes(source, name).to_vec());
                }
                match node.child_by_field_name("scope") {
                    Some(s) => node = s,
                    None => break,
                }
            }
            "constant" => {
                parts.push(node_bytes(source, node).to_vec());
                break;
            }
            _ => break,
        }
    }
    parts.reverse();
    parts
}

fn replacement(mid: &[u8], meth: &[u8], algo: &str) -> String {
    if mid == b"Cipher" {
        format!("OpenSSL::Cipher.new(\"{algo}\")")
    } else if meth == b"digest" {
        format!("OpenSSL::Digest.digest(\"{algo}\", ...)")
    } else {
        format!("OpenSSL::Digest.new(\"{algo}\")")
    }
}

fn openssl_algo(parts: &[Vec<u8>]) -> Option<(&str, &[u8])> {
    if parts.len() < 3 || parts[0] != b"OpenSSL" {
        return None;
    }
    let mid = parts[1].as_slice();
    if mid != b"Cipher" && mid != b"Digest" {
        return None;
    }
    if mid == b"Digest" && parts.len() == 3 && parts[2] == b"Digest" {
        return None;
    }
    Some((std::str::from_utf8(&parts[2]).unwrap_or(""), mid))
}

impl Cop for DeprecatedOpenSSLConstant {
    fn name(&self) -> &'static str {
        "Lint/DeprecatedOpenSSLConstant"
    }

    fn default_severity(&self) -> Severity {
        Severity::Warning
    }

    fn interested_node_kinds(&self) -> &'static [&'static str] {
        &["call"]
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        _config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        _corrections: Option<&mut Vec<crate::correction::Correction>>,
    ) {
        let Some(meth) = call_method_name(source, node) else {
            return;
        };
        if meth != b"new" && meth != b"digest" {
            return;
        }
        let Some(recv) = call_receiver(node) else {
            return;
        };
        if let Some((algo, mid)) = openssl_algo(&scope_parts(source, recv)) {
            let original = node_text(source, node);
            let repl = replacement(mid, meth, algo);
            let (line, col) = source.offset_to_line_col(node.start_byte());
            diagnostics.push(self.diagnostic(
                source,
                line,
                col,
                format!("Use `{repl}` instead of `{original}`."),
            ));
        }
    }
}