mdbook-lint 0.2.0

A fast markdown linter for mdBook
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
//! MD048: Code fence style consistency
//!
//! This rule checks that fenced code blocks use a consistent fence style (backticks vs tildes) throughout the document.

use crate::error::Result;
use crate::rule::{AstRule, RuleCategory, RuleMetadata};
use crate::{
    Document,
    violation::{Severity, Violation},
};
use comrak::nodes::{AstNode, NodeValue};

/// Rule to check code fence style consistency
pub struct MD048 {
    /// Preferred fence style
    style: FenceStyle,
}

#[derive(Debug, Clone, Copy, PartialEq)]
pub enum FenceStyle {
    /// Use backticks (```)
    Backtick,
    /// Use tildes (~~~)
    Tilde,
    /// Detect from first usage in document
    Consistent,
}

impl MD048 {
    /// Create a new MD048 rule with consistent style detection
    pub fn new() -> Self {
        Self {
            style: FenceStyle::Consistent,
        }
    }

    /// Create a new MD048 rule with specific style preference
    #[allow(dead_code)]
    pub fn with_style(style: FenceStyle) -> Self {
        Self { style }
    }

    /// Determine the fence style of a code block
    fn get_fence_style(&self, node: &AstNode) -> Option<FenceStyle> {
        if let NodeValue::CodeBlock(code_block) = &node.data.borrow().value {
            if code_block.fenced {
                // Check the fence character - comrak stores the fence info
                if code_block.fence_char as char == '`' {
                    Some(FenceStyle::Backtick)
                } else if code_block.fence_char as char == '~' {
                    Some(FenceStyle::Tilde)
                } else {
                    None
                }
            } else {
                // Not a fenced code block, ignore
                None
            }
        } else {
            None
        }
    }

    /// Get line and column position for a node
    fn get_position<'a>(&self, node: &'a AstNode<'a>) -> (usize, usize) {
        let data = node.data.borrow();
        let pos = data.sourcepos;
        (pos.start.line, pos.start.column)
    }

    /// Walk AST and find all fence style violations
    fn check_node<'a>(
        &self,
        node: &'a AstNode<'a>,
        violations: &mut Vec<Violation>,
        expected_style: &mut Option<FenceStyle>,
    ) {
        if let NodeValue::CodeBlock(_) = &node.data.borrow().value {
            if let Some(current_style) = self.get_fence_style(node) {
                if let Some(expected) = expected_style {
                    // Check consistency with established style
                    if *expected != current_style {
                        let (line, column) = self.get_position(node);
                        let expected_char = match expected {
                            FenceStyle::Backtick => "`",
                            FenceStyle::Tilde => "~",
                            FenceStyle::Consistent => "consistent", // shouldn't happen
                        };
                        let found_char = match current_style {
                            FenceStyle::Backtick => "`",
                            FenceStyle::Tilde => "~",
                            FenceStyle::Consistent => "consistent", // shouldn't happen
                        };

                        violations.push(self.create_violation(
                            format!(
                                "Code fence style inconsistent - expected '{expected_char}' but found '{found_char}'"
                            ),
                            line,
                            column,
                            Severity::Warning,
                        ));
                    }
                } else {
                    // First fenced code block found - establish the style
                    match self.style {
                        FenceStyle::Backtick => *expected_style = Some(FenceStyle::Backtick),
                        FenceStyle::Tilde => *expected_style = Some(FenceStyle::Tilde),
                        FenceStyle::Consistent => *expected_style = Some(current_style),
                    }
                }
            }
        }

        // Recursively check children
        for child in node.children() {
            self.check_node(child, violations, expected_style);
        }
    }
}

impl Default for MD048 {
    fn default() -> Self {
        Self::new()
    }
}

impl AstRule for MD048 {
    fn id(&self) -> &'static str {
        "MD048"
    }

    fn name(&self) -> &'static str {
        "code-fence-style"
    }

    fn description(&self) -> &'static str {
        "Code fence style should be consistent"
    }

    fn metadata(&self) -> RuleMetadata {
        RuleMetadata::stable(RuleCategory::Formatting).introduced_in("mdbook-lint v0.1.0")
    }

    fn check_ast<'a>(&self, _document: &Document, ast: &'a AstNode<'a>) -> Result<Vec<Violation>> {
        let mut violations = Vec::new();
        let mut expected_style = match self.style {
            FenceStyle::Backtick => Some(FenceStyle::Backtick),
            FenceStyle::Tilde => Some(FenceStyle::Tilde),
            FenceStyle::Consistent => None, // Detect from first usage
        };

        self.check_node(ast, &mut violations, &mut expected_style);
        Ok(violations)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::rule::Rule;
    use std::path::PathBuf;

    fn create_test_document(content: &str) -> Document {
        Document::new(content.to_string(), PathBuf::from("test.md")).unwrap()
    }

    #[test]
    fn test_md048_consistent_backtick_style() {
        let content = r#"Here is some backtick fenced code:

```rust
fn main() {
    println!("Hello");
}
```

And another backtick block:

```python
print("Hello")
```
"#;

        let document = create_test_document(content);
        let rule = MD048::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md048_consistent_tilde_style() {
        let content = r#"Here is some tilde fenced code:

~~~rust
fn main() {
    println!("Hello");
}
~~~

And another tilde block:

~~~python
print("Hello")
~~~
"#;

        let document = create_test_document(content);
        let rule = MD048::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md048_mixed_fence_styles_violation() {
        let content = r#"Here is backtick fenced code:

```rust
fn main() {
    println!("Hello");
}
```

And here is tilde fenced code:

~~~python
print("Hello")
~~~
"#;

        let document = create_test_document(content);
        let rule = MD048::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert_eq!(violations[0].rule_id, "MD048");
        assert!(violations[0].message.contains("expected '`' but found '~'"));
    }

    #[test]
    fn test_md048_preferred_backtick_style() {
        let content = r#"Here is tilde fenced code:

~~~rust
fn main() {}
~~~
"#;

        let document = create_test_document(content);
        let rule = MD048::with_style(FenceStyle::Backtick);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(violations[0].message.contains("expected '`' but found '~'"));
    }

    #[test]
    fn test_md048_preferred_tilde_style() {
        let content = r#"Here is backtick fenced code:

```rust
fn main() {}
```
"#;

        let document = create_test_document(content);
        let rule = MD048::with_style(FenceStyle::Tilde);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(violations[0].message.contains("expected '~' but found '`'"));
    }

    #[test]
    fn test_md048_indented_code_blocks_ignored() {
        let content = r#"Backtick fenced:

```rust
fn main() {}
```

Indented code (should be ignored):

    print("hello")

Tilde fenced (should be flagged):

~~~python
print("world")
~~~
"#;

        let document = create_test_document(content);
        let rule = MD048::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(violations[0].message.contains("expected '`' but found '~'"));
    }

    #[test]
    fn test_md048_multiple_backtick_blocks() {
        let content = r#"First block:

```rust
fn main() {}
```

Second block:

```python
print("hello")
```

Third block:

```javascript
console.log("hello");
```
"#;

        let document = create_test_document(content);
        let rule = MD048::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md048_multiple_tilde_blocks() {
        let content = r#"First block:

~~~rust
fn main() {}
~~~

Second block:

~~~python
print("hello")
~~~

Third block:

~~~javascript
console.log("hello");
~~~
"#;

        let document = create_test_document(content);
        let rule = MD048::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md048_mixed_multiple_violations() {
        let content = r#"Start with backticks:

```rust
fn main() {}
```

Then tildes (violation):

~~~python
print("hello")
~~~

Then backticks again:

```javascript
console.log("hello");
```

And tildes again (violation):

~~~bash
echo "hello"
~~~
"#;

        let document = create_test_document(content);
        let rule = MD048::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 2);
        assert!(violations[0].message.contains("expected '`' but found '~'"));
        assert!(violations[1].message.contains("expected '`' but found '~'"));
    }

    #[test]
    fn test_md048_no_fenced_code_blocks() {
        let content = r#"This document has no fenced code blocks.

Just regular text and paragraphs.

    This is indented code, not fenced.

And maybe some `inline code` but no fenced blocks.
"#;

        let document = create_test_document(content);
        let rule = MD048::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md048_tilde_first_determines_style() {
        let content = r#"Start with tildes:

~~~rust
fn main() {}
~~~

Then backticks should be flagged:

```python
print("hello")
```
"#;

        let document = create_test_document(content);
        let rule = MD048::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(violations[0].message.contains("expected '~' but found '`'"));
    }

    #[test]
    fn test_md048_with_languages() {
        let content = r#"Different languages, same fence style:

```rust
fn main() {}
```

```python
def hello():
    pass
```

```javascript
function hello() {}
```
"#;

        let document = create_test_document(content);
        let rule = MD048::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }
}