mdbook-lint 0.2.0

A fast markdown linter for mdBook
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
//! MD043: Required heading structure
//!
//! This rule checks that headings follow a required structure/hierarchy pattern.

use crate::error::Result;
use crate::rule::{AstRule, RuleCategory, RuleMetadata};
use crate::{
    Document,
    violation::{Severity, Violation},
};
use comrak::nodes::{AstNode, NodeValue};

/// Rule to check required heading structure
pub struct MD043 {
    /// Required heading patterns
    headings: Vec<String>,
}

impl MD043 {
    /// Create a new MD043 rule with default heading structure
    pub fn new() -> Self {
        Self {
            headings: Vec::new(), // No required structure by default
        }
    }

    /// Create a new MD043 rule with required heading structure
    #[allow(dead_code)]
    pub fn with_headings(headings: Vec<String>) -> Self {
        Self { headings }
    }

    /// Get line and column position for a node
    fn get_position<'a>(&self, node: &'a AstNode<'a>) -> (usize, usize) {
        let data = node.data.borrow();
        let pos = data.sourcepos;
        (pos.start.line, pos.start.column)
    }

    /// Extract text content from a heading node
    fn extract_heading_text<'a>(&self, node: &'a AstNode<'a>) -> String {
        let mut text = String::new();
        Self::collect_text_content(node, &mut text);
        text
    }

    /// Recursively collect text content from a node and its children
    fn collect_text_content<'a>(node: &'a AstNode<'a>, text: &mut String) {
        match &node.data.borrow().value {
            NodeValue::Text(t) => text.push_str(t),
            NodeValue::Code(code) => text.push_str(&code.literal),
            _ => {}
        }

        for child in node.children() {
            Self::collect_text_content(child, text);
        }
    }

    /// Check if a heading text matches a required pattern
    fn matches_pattern(&self, heading_text: &str, pattern: &str) -> bool {
        // For now, implement exact match (case-insensitive)
        // Could be extended to support regex patterns in the future
        heading_text.trim().to_lowercase() == pattern.trim().to_lowercase()
    }

    /// Walk AST and collect headings, then validate structure
    fn check_node<'a>(&self, node: &'a AstNode<'a>, headings: &mut Vec<(usize, String, usize)>) {
        if let NodeValue::Heading(heading_data) = &node.data.borrow().value {
            let (line, _) = self.get_position(node);
            let text = self.extract_heading_text(node);
            headings.push((line, text, heading_data.level as usize));
        }

        // Recursively check children
        for child in node.children() {
            self.check_node(child, headings);
        }
    }
}

impl Default for MD043 {
    fn default() -> Self {
        Self::new()
    }
}

impl AstRule for MD043 {
    fn id(&self) -> &'static str {
        "MD043"
    }

    fn name(&self) -> &'static str {
        "required-headings"
    }

    fn description(&self) -> &'static str {
        "Required heading structure"
    }

    fn metadata(&self) -> RuleMetadata {
        RuleMetadata::stable(RuleCategory::Structure).introduced_in("mdbook-lint v0.1.0")
    }

    fn check_ast<'a>(&self, _document: &Document, ast: &'a AstNode<'a>) -> Result<Vec<Violation>> {
        let mut violations = Vec::new();

        // If no required structure is configured, skip checking
        if self.headings.is_empty() {
            return Ok(violations);
        }

        let mut document_headings = Vec::new();
        self.check_node(ast, &mut document_headings);

        // Check if document has the required number of headings
        if document_headings.len() < self.headings.len() {
            violations.push(self.create_violation(
                format!(
                    "Document should have at least {} headings but found {}",
                    self.headings.len(),
                    document_headings.len()
                ),
                1,
                1,
                Severity::Warning,
            ));
            return Ok(violations);
        }

        // Check each required heading
        for (i, required_heading) in self.headings.iter().enumerate() {
            if i < document_headings.len() {
                let (line, actual_text, _level) = &document_headings[i];
                if !self.matches_pattern(actual_text, required_heading) {
                    violations.push(self.create_violation(
                        format!("Expected heading '{required_heading}' but found '{actual_text}'"),
                        *line,
                        1,
                        Severity::Warning,
                    ));
                }
            }
        }

        Ok(violations)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::rule::Rule;
    use std::path::PathBuf;

    fn create_test_document(content: &str) -> Document {
        Document::new(content.to_string(), PathBuf::from("test.md")).unwrap()
    }

    #[test]
    fn test_md043_no_required_structure() {
        let content = r#"# Any Heading

## Any Subheading

### Any Sub-subheading
"#;

        let document = create_test_document(content);
        let rule = MD043::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0); // No requirements, so no violations
    }

    #[test]
    fn test_md043_correct_structure() {
        let content = r#"# Introduction

## Getting Started

## Configuration
"#;

        let required_headings = vec![
            "Introduction".to_string(),
            "Getting Started".to_string(),
            "Configuration".to_string(),
        ];

        let document = create_test_document(content);
        let rule = MD043::with_headings(required_headings);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md043_incorrect_heading_text() {
        let content = r#"# Introduction

## Getting Started

## Setup
"#;

        let required_headings = vec![
            "Introduction".to_string(),
            "Getting Started".to_string(),
            "Configuration".to_string(),
        ];

        let document = create_test_document(content);
        let rule = MD043::with_headings(required_headings);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert_eq!(violations[0].rule_id, "MD043");
        assert!(
            violations[0]
                .message
                .contains("Expected heading 'Configuration' but found 'Setup'")
        );
        assert_eq!(violations[0].line, 5);
    }

    #[test]
    fn test_md043_missing_headings() {
        let content = r#"# Introduction

## Getting Started
"#;

        let required_headings = vec![
            "Introduction".to_string(),
            "Getting Started".to_string(),
            "Configuration".to_string(),
        ];

        let document = create_test_document(content);
        let rule = MD043::with_headings(required_headings);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(
            violations[0]
                .message
                .contains("should have at least 3 headings but found 2")
        );
    }

    #[test]
    fn test_md043_case_insensitive_matching() {
        let content = r#"# INTRODUCTION

## getting started

## Configuration
"#;

        let required_headings = vec![
            "Introduction".to_string(),
            "Getting Started".to_string(),
            "Configuration".to_string(),
        ];

        let document = create_test_document(content);
        let rule = MD043::with_headings(required_headings);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0); // Case-insensitive matching should work
    }

    #[test]
    fn test_md043_extra_headings_allowed() {
        let content = r#"# Introduction

## Getting Started

## Configuration

## Advanced Topics

### Customization
"#;

        let required_headings = vec![
            "Introduction".to_string(),
            "Getting Started".to_string(),
            "Configuration".to_string(),
        ];

        let document = create_test_document(content);
        let rule = MD043::with_headings(required_headings);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0); // Extra headings are allowed
    }

    #[test]
    fn test_md043_first_heading_wrong() {
        let content = r#"# Overview

## Getting Started

## Configuration
"#;

        let required_headings = vec![
            "Introduction".to_string(),
            "Getting Started".to_string(),
            "Configuration".to_string(),
        ];

        let document = create_test_document(content);
        let rule = MD043::with_headings(required_headings);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(
            violations[0]
                .message
                .contains("Expected heading 'Introduction' but found 'Overview'")
        );
        assert_eq!(violations[0].line, 1);
    }

    #[test]
    fn test_md043_multiple_violations() {
        let content = r#"# Overview

## Setup

## Deployment
"#;

        let required_headings = vec![
            "Introduction".to_string(),
            "Getting Started".to_string(),
            "Configuration".to_string(),
        ];

        let document = create_test_document(content);
        let rule = MD043::with_headings(required_headings);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 3); // All three headings are wrong
        assert!(
            violations[0]
                .message
                .contains("Expected heading 'Introduction' but found 'Overview'")
        );
        assert!(
            violations[1]
                .message
                .contains("Expected heading 'Getting Started' but found 'Setup'")
        );
        assert!(
            violations[2]
                .message
                .contains("Expected heading 'Configuration' but found 'Deployment'")
        );
    }

    #[test]
    fn test_md043_headings_with_formatting() {
        let content = r#"# **Introduction**

## *Getting Started*

## Configuration
"#;

        let required_headings = vec![
            "Introduction".to_string(),
            "Getting Started".to_string(),
            "Configuration".to_string(),
        ];

        let document = create_test_document(content);
        let rule = MD043::with_headings(required_headings);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0); // Should extract text content ignoring formatting
    }

    #[test]
    fn test_md043_headings_with_code() {
        let content = r#"# Introduction

## Getting Started with `npm`

## Configuration
"#;

        let required_headings = vec![
            "Introduction".to_string(),
            "Getting Started with npm".to_string(),
            "Configuration".to_string(),
        ];

        let document = create_test_document(content);
        let rule = MD043::with_headings(required_headings);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md043_whitespace_handling() {
        let content = r#"#   Introduction

##    Getting Started

##  Configuration
"#;

        let required_headings = vec![
            "Introduction".to_string(),
            "Getting Started".to_string(),
            "Configuration".to_string(),
        ];

        let document = create_test_document(content);
        let rule = MD043::with_headings(required_headings);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0); // Should handle whitespace properly
    }
}