mdbook-lint 0.2.0

A fast markdown linter for mdBook
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
//! MD046: Code block style consistency
//!
//! This rule checks that code blocks use a consistent style (fenced vs indented) throughout the document.

use crate::error::Result;
use crate::rule::{AstRule, RuleCategory, RuleMetadata};
use crate::{
    Document,
    violation::{Severity, Violation},
};
use comrak::nodes::{AstNode, NodeValue};

/// Rule to check code block style consistency
pub struct MD046 {
    /// Preferred code block style
    style: CodeBlockStyle,
}

#[derive(Debug, Clone, Copy, PartialEq)]
pub enum CodeBlockStyle {
    /// Use fenced code blocks (``` or ~~~)
    Fenced,
    /// Use indented code blocks (4 spaces or 1 tab)
    Indented,
    /// Detect from first usage in document
    Consistent,
}

impl MD046 {
    /// Create a new MD046 rule with consistent style detection
    pub fn new() -> Self {
        Self {
            style: CodeBlockStyle::Consistent,
        }
    }

    /// Create a new MD046 rule with specific style preference
    #[allow(dead_code)]
    pub fn with_style(style: CodeBlockStyle) -> Self {
        Self { style }
    }

    /// Determine if a code block is fenced or indented
    fn get_code_block_style(&self, node: &AstNode) -> Option<CodeBlockStyle> {
        if let NodeValue::CodeBlock(code_block) = &node.data.borrow().value {
            // Check if it's a fenced code block by looking for fence markers
            if code_block.fenced {
                Some(CodeBlockStyle::Fenced)
            } else {
                Some(CodeBlockStyle::Indented)
            }
        } else {
            None
        }
    }

    /// Get line and column position for a node
    fn get_position<'a>(&self, node: &'a AstNode<'a>) -> (usize, usize) {
        let data = node.data.borrow();
        let pos = data.sourcepos;
        (pos.start.line, pos.start.column)
    }

    /// Walk AST and find all code block style violations
    fn check_node<'a>(
        &self,
        node: &'a AstNode<'a>,
        violations: &mut Vec<Violation>,
        expected_style: &mut Option<CodeBlockStyle>,
    ) {
        if let NodeValue::CodeBlock(_) = &node.data.borrow().value {
            if let Some(current_style) = self.get_code_block_style(node) {
                if let Some(expected) = expected_style {
                    // Check consistency with established style
                    if *expected != current_style {
                        let (line, column) = self.get_position(node);
                        let expected_name = match expected {
                            CodeBlockStyle::Fenced => "fenced",
                            CodeBlockStyle::Indented => "indented",
                            CodeBlockStyle::Consistent => "consistent", // shouldn't happen
                        };
                        let found_name = match current_style {
                            CodeBlockStyle::Fenced => "fenced",
                            CodeBlockStyle::Indented => "indented",
                            CodeBlockStyle::Consistent => "consistent", // shouldn't happen
                        };

                        violations.push(self.create_violation(
                            format!(
                                "Code block style inconsistent - expected {expected_name} but found {found_name}"
                            ),
                            line,
                            column,
                            Severity::Warning,
                        ));
                    }
                } else {
                    // First code block found - establish the style
                    match self.style {
                        CodeBlockStyle::Fenced => *expected_style = Some(CodeBlockStyle::Fenced),
                        CodeBlockStyle::Indented => {
                            *expected_style = Some(CodeBlockStyle::Indented)
                        }
                        CodeBlockStyle::Consistent => *expected_style = Some(current_style),
                    }
                }
            }
        }

        // Recursively check children
        for child in node.children() {
            self.check_node(child, violations, expected_style);
        }
    }
}

impl Default for MD046 {
    fn default() -> Self {
        Self::new()
    }
}

impl AstRule for MD046 {
    fn id(&self) -> &'static str {
        "MD046"
    }

    fn name(&self) -> &'static str {
        "code-block-style"
    }

    fn description(&self) -> &'static str {
        "Code block style should be consistent"
    }

    fn metadata(&self) -> RuleMetadata {
        RuleMetadata::stable(RuleCategory::Formatting).introduced_in("mdbook-lint v0.1.0")
    }

    fn check_ast<'a>(&self, _document: &Document, ast: &'a AstNode<'a>) -> Result<Vec<Violation>> {
        let mut violations = Vec::new();
        let mut expected_style = match self.style {
            CodeBlockStyle::Fenced => Some(CodeBlockStyle::Fenced),
            CodeBlockStyle::Indented => Some(CodeBlockStyle::Indented),
            CodeBlockStyle::Consistent => None, // Detect from first usage
        };

        self.check_node(ast, &mut violations, &mut expected_style);
        Ok(violations)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::rule::Rule;
    use std::path::PathBuf;

    fn create_test_document(content: &str) -> Document {
        Document::new(content.to_string(), PathBuf::from("test.md")).unwrap()
    }

    #[test]
    fn test_md046_consistent_fenced_style() {
        let content = r#"Here is some fenced code:

```rust
fn main() {
    println!("Hello");
}
```

And another fenced block:

```python
print("Hello")
```
"#;

        let document = create_test_document(content);
        let rule = MD046::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md046_consistent_indented_style() {
        let content = r#"Here is some indented code:

    fn main() {
        println!("Hello");
    }

And another indented block:

    print("Hello")
"#;

        let document = create_test_document(content);
        let rule = MD046::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md046_mixed_styles_violation() {
        let content = r#"Here is fenced code:

```rust
fn main() {
    println!("Hello");
}
```

And here is indented code:

    print("Hello")
"#;

        let document = create_test_document(content);
        let rule = MD046::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert_eq!(violations[0].rule_id, "MD046");
        assert!(
            violations[0]
                .message
                .contains("expected fenced but found indented")
        );
    }

    #[test]
    fn test_md046_preferred_fenced_style() {
        let content = r#"Here is indented code:

    print("Hello")
"#;

        let document = create_test_document(content);
        let rule = MD046::with_style(CodeBlockStyle::Fenced);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(
            violations[0]
                .message
                .contains("expected fenced but found indented")
        );
    }

    #[test]
    fn test_md046_preferred_indented_style() {
        let content = r#"Here is fenced code:

```rust
fn main() {}
```
"#;

        let document = create_test_document(content);
        let rule = MD046::with_style(CodeBlockStyle::Indented);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(
            violations[0]
                .message
                .contains("expected indented but found fenced")
        );
    }

    #[test]
    fn test_md046_multiple_fenced_blocks() {
        let content = r#"First block:

```rust
fn main() {}
```

Second block:

```python
print("hello")
```

Third block:

```javascript
console.log("hello");
```
"#;

        let document = create_test_document(content);
        let rule = MD046::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md046_multiple_indented_blocks() {
        let content = r#"First block:

    fn main() {}

Second block:

    print("hello")

Third block:

    console.log("hello");
"#;

        let document = create_test_document(content);
        let rule = MD046::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md046_mixed_multiple_violations() {
        let content = r#"Start with fenced:

```rust
fn main() {}
```

Then indented:

    print("hello")

Then fenced again:

```javascript
console.log("hello");
```

And indented again:

    another_function()
"#;

        let document = create_test_document(content);
        let rule = MD046::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 2); // Two violations: second and fourth blocks
        assert!(
            violations[0]
                .message
                .contains("expected fenced but found indented")
        );
        assert!(
            violations[1]
                .message
                .contains("expected fenced but found indented")
        );
    }

    #[test]
    fn test_md046_no_code_blocks() {
        let content = r#"This document has no code blocks.

Just regular text and paragraphs.

And maybe some `inline code` but no blocks.
"#;

        let document = create_test_document(content);
        let rule = MD046::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md046_tilde_fenced_blocks() {
        let content = r#"Using tilde fences:

~~~rust
fn main() {}
~~~

And backtick fences:

```python
print("hello")
```
"#;

        let document = create_test_document(content);
        let rule = MD046::new();
        let violations = rule.check(&document).unwrap();
        // Both are fenced style, so should be consistent
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md046_fenced_vs_indented_first_determines() {
        let content = r#"Start with indented:

    fn main() {}

Then fenced should be flagged:

```python
print("hello")
```
"#;

        let document = create_test_document(content);
        let rule = MD046::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(
            violations[0]
                .message
                .contains("expected indented but found fenced")
        );
    }
}