zerodds-xrce 1.0.0-rc.1

DDS-XRCE Wire-Codec (16 Submessages, MessageHeader, RFC-1982, UDP-Mapping)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
// SPDX-License-Identifier: Apache-2.0
// Copyright 2026 ZeroDDS Contributors

//! XRCE TCP-Transport-Mapping (Spec §11.3).
//!
//! TCP unterscheidet sich von UDP (§11.2) dadurch, dass es keine
//! Datagram-Boundaries hat — der Stream liefert nur einen kontinuierlichen
//! Byte-Strom. Spec §11.3.3 verlangt deshalb pro XRCE-Message einen
//! 2-Byte-Length-Prefix.
//!
//! ```text
//!  +--------+--------+----------------------------+
//!  | length (LE u16) |       XRCE-Message         |
//!  +--------+--------+----------------------------+
//! ```
//!
//! ## Anmerkung Endianness
//!
//! Der Spec-Text §11.3.3 spricht von "2-Byte-Length-Prefix". Die meisten
//! existierenden XRCE-Implementierungen (Micro-XRCE-DDS) nutzen
//! Little-Endian, weil das mit dem Submessage-Length-Feld (§8.3.4 — immer
//! LE) konsistent ist. Wir folgen dieser de-facto-Konvention.
//!
//! ## DoS-Schutz
//!
//! - max-message-size = `MAX_DATAGRAM_SIZE` (analog UDP)
//! - bei Truncation/Connection-Close → `XrceError::ValueOutOfRange`

use std::io::{Read, Write};
use std::net::{SocketAddr, TcpListener, TcpStream};

use crate::error::XrceError;
use crate::submessages::{DOSC_MAX_PAYLOAD_SIZE, Message};
use crate::transport_udp::MAX_DATAGRAM_SIZE;

/// Wire-Size des Length-Prefix (§11.3.3).
pub const TCP_LENGTH_PREFIX_SIZE: usize = 2;

/// XRCE-TCP-Client. Verbindet sich zu einem XRCE-TCP-Agent und kapselt
/// Length-Prefix-Framing.
#[derive(Debug)]
pub struct XrceTcpClient {
    /// Aktive TCP-Verbindung.
    pub stream: TcpStream,
}

impl XrceTcpClient {
    /// Verbindet sich zu `addr` (Agent-Adresse).
    ///
    /// # Errors
    /// `XrceError::ValueOutOfRange`, wenn der Connect fehlschlaegt.
    pub fn connect(addr: SocketAddr) -> Result<Self, XrceError> {
        let stream = TcpStream::connect(addr).map_err(|_| XrceError::ValueOutOfRange {
            message: "tcp connect failed",
        })?;
        Ok(Self { stream })
    }

    /// Wrappt einen schon existierenden Stream (z.B. aus `accept`).
    #[must_use]
    pub fn from_stream(stream: TcpStream) -> Self {
        Self { stream }
    }

    /// Sendet `msg` mit 2-Byte-Length-Prefix (LE).
    ///
    /// # Errors
    /// - `PayloadTooLarge`, wenn die Message > `MAX_DATAGRAM_SIZE` ist.
    /// - `ValueOutOfRange`, wenn das Encode oder der TCP-Write fehlschlaegt.
    pub fn send_message(&mut self, msg: &Message) -> Result<(), XrceError> {
        let bytes = msg.encode()?;
        if bytes.len() > MAX_DATAGRAM_SIZE {
            return Err(XrceError::PayloadTooLarge {
                limit: MAX_DATAGRAM_SIZE,
                actual: bytes.len(),
            });
        }
        let len = u16::try_from(bytes.len()).map_err(|_| XrceError::ValueOutOfRange {
            message: "tcp message length exceeds u16",
        })?;
        let prefix = len.to_le_bytes();
        self.stream
            .write_all(&prefix)
            .map_err(|_| XrceError::ValueOutOfRange {
                message: "tcp write_all length-prefix failed",
            })?;
        self.stream
            .write_all(&bytes)
            .map_err(|_| XrceError::ValueOutOfRange {
                message: "tcp write_all body failed",
            })?;
        Ok(())
    }

    /// Empfaengt eine Message — blockt bis komplettes Frame da ist.
    ///
    /// # Errors
    /// - `UnexpectedEof`, wenn die Verbindung geschlossen wird, bevor das
    ///   Frame vollstaendig ist.
    /// - `PayloadTooLarge`, wenn der Length-Prefix > `MAX_DATAGRAM_SIZE`
    ///   ankuendigt (DoS-Cap).
    /// - `XrceError` aus `Message::decode`.
    pub fn recv_message(&mut self) -> Result<Message, XrceError> {
        let mut prefix = [0u8; TCP_LENGTH_PREFIX_SIZE];
        read_exact_eof(&mut self.stream, &mut prefix)?;
        let len = u16::from_le_bytes(prefix) as usize;
        if len > MAX_DATAGRAM_SIZE {
            return Err(XrceError::PayloadTooLarge {
                limit: MAX_DATAGRAM_SIZE,
                actual: len,
            });
        }
        if len > DOSC_MAX_PAYLOAD_SIZE {
            return Err(XrceError::PayloadTooLarge {
                limit: DOSC_MAX_PAYLOAD_SIZE,
                actual: len,
            });
        }
        let mut body = std::vec![0u8; len];
        read_exact_eof(&mut self.stream, &mut body)?;
        Message::decode(&body)
    }

    /// Schliesst die Verbindung explizit (Drop tut das auch automatisch).
    ///
    /// # Errors
    /// `ValueOutOfRange` bei Shutdown-Fehler.
    pub fn close(&mut self) -> Result<(), XrceError> {
        self.stream
            .shutdown(std::net::Shutdown::Both)
            .map_err(|_| XrceError::ValueOutOfRange {
                message: "tcp shutdown failed",
            })
    }
}

/// XRCE-TCP-Agent (Server-Side). Lauscht auf einem Bind-Port.
#[derive(Debug)]
pub struct XrceTcpServer {
    /// Listener-Socket.
    pub listener: TcpListener,
}

impl XrceTcpServer {
    /// Bindet einen Listener-Port.
    ///
    /// # Errors
    /// `ValueOutOfRange`, wenn der Bind fehlschlaegt.
    pub fn bind(addr: SocketAddr) -> Result<Self, XrceError> {
        let listener = TcpListener::bind(addr).map_err(|_| XrceError::ValueOutOfRange {
            message: "tcp bind failed",
        })?;
        Ok(Self { listener })
    }

    /// Akzeptiert die naechste Verbindung. Blockt.
    ///
    /// # Errors
    /// `ValueOutOfRange`, wenn `accept` fehlschlaegt.
    pub fn accept(&self) -> Result<(XrceTcpClient, SocketAddr), XrceError> {
        let (stream, peer) = self
            .listener
            .accept()
            .map_err(|_| XrceError::ValueOutOfRange {
                message: "tcp accept failed",
            })?;
        Ok((XrceTcpClient::from_stream(stream), peer))
    }

    /// Lokal gebundene Adresse.
    ///
    /// # Errors
    /// `ValueOutOfRange`, wenn `local_addr` fehlschlaegt.
    pub fn local_addr(&self) -> Result<SocketAddr, XrceError> {
        self.listener
            .local_addr()
            .map_err(|_| XrceError::ValueOutOfRange {
                message: "tcp local_addr failed",
            })
    }
}

/// Liest exakt `buf.len()` Bytes; bei vorzeitigem EOF → `UnexpectedEof`.
fn read_exact_eof<R: Read>(r: &mut R, buf: &mut [u8]) -> Result<(), XrceError> {
    let needed = buf.len();
    let mut read = 0usize;
    while read < needed {
        match r.read(&mut buf[read..]) {
            Ok(0) => {
                return Err(XrceError::UnexpectedEof {
                    needed: needed - read,
                    offset: read,
                });
            }
            Ok(n) => read += n,
            Err(e) if e.kind() == std::io::ErrorKind::Interrupted => continue,
            Err(_) => {
                return Err(XrceError::ValueOutOfRange {
                    message: "tcp read failed",
                });
            }
        }
    }
    Ok(())
}

#[cfg(test)]
mod tests {
    #![allow(clippy::expect_used, clippy::unwrap_used)]
    use super::*;
    use crate::header::{ClientKey, MessageHeader, SessionId, StreamId};
    use crate::serial_number::SerialNumber16;
    use crate::submessages::write_data::DataFormat;
    use crate::submessages::{
        AckNackPayload, CreateClientPayload, HeartbeatPayload, ResetPayload, Submessage,
        WriteDataPayload,
    };
    use std::net::{Ipv4Addr, SocketAddrV4};
    use std::thread;
    use std::time::Duration;

    extern crate alloc;

    fn loopback_pair() -> (XrceTcpServer, SocketAddr) {
        let server =
            XrceTcpServer::bind(SocketAddr::V4(SocketAddrV4::new(Ipv4Addr::LOCALHOST, 0))).unwrap();
        let addr = server.local_addr().unwrap();
        (server, addr)
    }

    fn message_with(sm: Submessage) -> Message {
        let header = MessageHeader::with_client_key(
            SessionId(0),
            StreamId::BUILTIN_RELIABLE,
            SerialNumber16::new(1),
            ClientKey([0xCA, 0xFE, 0xBA, 0xBE]),
        )
        .unwrap();
        Message::new(header, alloc::vec![sm]).unwrap()
    }

    #[test]
    fn tcp_loopback_create_client_roundtrip() {
        let (server, addr) = loopback_pair();
        let server_thread = thread::spawn(move || {
            let (mut client, _) = server.accept().unwrap();
            client.recv_message().unwrap()
        });
        let mut client = XrceTcpClient::connect(addr).unwrap();
        let msg = message_with(
            CreateClientPayload {
                representation: alloc::vec![b'X', b'R', b'C', b'E', 1, 0],
            }
            .into_submessage()
            .unwrap(),
        );
        client.send_message(&msg).unwrap();
        let received = server_thread.join().unwrap();
        assert_eq!(received, msg);
    }

    #[test]
    fn tcp_loopback_write_data_roundtrip() {
        let (server, addr) = loopback_pair();
        let server_thread = thread::spawn(move || {
            let (mut client, _) = server.accept().unwrap();
            client.recv_message().unwrap()
        });
        let mut client = XrceTcpClient::connect(addr).unwrap();
        let msg = message_with(
            WriteDataPayload {
                representation: alloc::vec![1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
                data_format: DataFormat::Sample,
            }
            .into_submessage()
            .unwrap(),
        );
        client.send_message(&msg).unwrap();
        let received = server_thread.join().unwrap();
        assert_eq!(received, msg);
    }

    #[test]
    fn tcp_loopback_three_message_chain() {
        let (server, addr) = loopback_pair();
        let server_thread = thread::spawn(move || {
            let (mut client, _) = server.accept().unwrap();
            let m1 = client.recv_message().unwrap();
            let m2 = client.recv_message().unwrap();
            let m3 = client.recv_message().unwrap();
            (m1, m2, m3)
        });
        let mut client = XrceTcpClient::connect(addr).unwrap();
        let m1 = message_with(ResetPayload.into_submessage().unwrap());
        let m2 = message_with(
            HeartbeatPayload {
                first_unacked_seq_nr: 1,
                last_unacked_seq_nr: 9,
                stream_id: 0x80,
            }
            .into_submessage()
            .unwrap(),
        );
        let m3 = message_with(
            AckNackPayload {
                first_unacked_seq_num: 5,
                nack_bitmap: [0xAA, 0x55],
                stream_id: 0x80,
            }
            .into_submessage()
            .unwrap(),
        );
        client.send_message(&m1).unwrap();
        client.send_message(&m2).unwrap();
        client.send_message(&m3).unwrap();
        let (r1, r2, r3) = server_thread.join().unwrap();
        assert_eq!(r1, m1);
        assert_eq!(r2, m2);
        assert_eq!(r3, m3);
    }

    #[test]
    fn tcp_recv_after_close_returns_eof() {
        let (server, addr) = loopback_pair();
        let server_thread = thread::spawn(move || {
            let (client, _) = server.accept().unwrap();
            // Sofort Drop → schliesst die Verbindung.
            drop(client);
        });
        let mut client = XrceTcpClient::connect(addr).unwrap();
        client
            .stream
            .set_read_timeout(Some(Duration::from_secs(2)))
            .unwrap();
        server_thread.join().unwrap();
        let res = client.recv_message();
        assert!(matches!(res, Err(XrceError::UnexpectedEof { .. })));
    }

    #[test]
    fn tcp_recv_oversized_length_rejected() {
        // Wir bauen einen Mock-Server, der einen Length-Prefix sendet, der
        // groesser als MAX_DATAGRAM_SIZE ist (was nicht moeglich waere,
        // weil len ein u16 ist) — also testen wir hier, dass auch die
        // DOSC-Cap greift.
        let (server, addr) = loopback_pair();
        let server_thread = thread::spawn(move || {
            let (mut client, _) = server.accept().unwrap();
            // Sende Length-Prefix > DOSC_MAX_PAYLOAD_SIZE (geht nur bis
            // u16::MAX = 65535 = DOSC_MAX_PAYLOAD_SIZE; also testen wir
            // den boundary direkt).
            let bad: u16 = u16::MAX;
            client.stream.write_all(&bad.to_le_bytes()).unwrap();
            // dann viele bytes streamen, damit Read nicht haengt
            client.stream.write_all(&[0u8; 100]).unwrap();
            client.stream.shutdown(std::net::Shutdown::Both).ok();
        });
        let mut client = XrceTcpClient::connect(addr).unwrap();
        client
            .stream
            .set_read_timeout(Some(Duration::from_secs(2)))
            .unwrap();
        let res = client.recv_message();
        // Endweder PayloadTooLarge (cap), oder UnexpectedEof, oder
        // dekodier-Fehler — alles sind valide Reject-Pfade.
        assert!(res.is_err());
        server_thread.join().unwrap();
    }

    #[test]
    fn tcp_send_truncation_when_peer_drops() {
        let (server, addr) = loopback_pair();
        let server_thread = thread::spawn(move || {
            let (client, _) = server.accept().unwrap();
            drop(client);
        });
        let mut client = XrceTcpClient::connect(addr).unwrap();
        server_thread.join().unwrap();
        // Erste Send schreibt evtl. noch in den Kernel-Buffer; der zweite
        // sollte fehlen, da peer closed.
        let msg = message_with(ResetPayload.into_submessage().unwrap());
        let _ = client.send_message(&msg);
        let _ = client.send_message(&msg);
        // Wir machen hier keinen harten Assert — verschiedene OS liefern
        // unterschiedlich. Test laeuft sauber durch, kein UB.
    }

    #[test]
    fn tcp_local_addr_consistent_after_bind() {
        let server =
            XrceTcpServer::bind(SocketAddr::V4(SocketAddrV4::new(Ipv4Addr::LOCALHOST, 0))).unwrap();
        let addr = server.local_addr().unwrap();
        assert_eq!(addr.ip(), Ipv4Addr::LOCALHOST);
        assert!(addr.port() > 0);
    }

    #[test]
    fn tcp_close_idempotent_safe() {
        let (server, addr) = loopback_pair();
        let server_thread = thread::spawn(move || {
            let _ = server.accept().unwrap();
        });
        let mut client = XrceTcpClient::connect(addr).unwrap();
        let _ = client.close();
        // Doppel-Close darf nicht panicen (Variante 2 darf err sein).
        let _ = client.close();
        server_thread.join().unwrap();
    }

    #[test]
    fn tcp_length_prefix_size_constant() {
        assert_eq!(TCP_LENGTH_PREFIX_SIZE, 2);
    }
}