vibesql-executor 0.2.0

Query execution engine for vibesql SQL database
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
mod common;

use vibesql_executor::InsertExecutor;

#[test]
fn test_character_varying_column_with_length() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE test_cv (id INT, description CHARACTER VARYING(100))
    let schema = vibesql_catalog::TableSchema::new(
        "test_cv".to_string(),
        vec![
            vibesql_catalog::ColumnSchema::new(
                "id".to_string(),
                vibesql_types::DataType::Integer,
                false,
            ),
            vibesql_catalog::ColumnSchema::new(
                "description".to_string(),
                vibesql_types::DataType::Varchar { max_length: Some(100) },
                false,
            ),
        ],
    );
    db.create_table(schema).unwrap();

    // INSERT INTO test_cv VALUES (1, 'Test description')
    let stmt = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "test_cv".to_string(),
        columns: vec![],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Integer(1)),
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                arcstr::ArcStr::from("Test description"),
            )),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };

    let rows = InsertExecutor::execute(&mut db, &stmt).unwrap();
    assert_eq!(rows, 1);

    // Verify data was inserted correctly
    let table = db.get_table("test_cv").unwrap();
    assert_eq!(table.row_count(), 1);
}

#[test]
fn test_character_varying_column_without_length() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE test_cv_nolen (id INT, text CHARACTER VARYING)
    let schema = vibesql_catalog::TableSchema::new(
        "test_cv_nolen".to_string(),
        vec![
            vibesql_catalog::ColumnSchema::new(
                "id".to_string(),
                vibesql_types::DataType::Integer,
                false,
            ),
            vibesql_catalog::ColumnSchema::new(
                "text".to_string(),
                vibesql_types::DataType::Varchar { max_length: None },
                false,
            ),
        ],
    );
    db.create_table(schema).unwrap();

    // INSERT INTO test_cv_nolen VALUES (1, 'Unlimited length text')
    let stmt = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "test_cv_nolen".to_string(),
        columns: vec![],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Integer(1)),
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                arcstr::ArcStr::from("Unlimited length text"),
            )),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };

    let rows = InsertExecutor::execute(&mut db, &stmt).unwrap();
    assert_eq!(rows, 1);

    // Verify data was inserted correctly
    let table = db.get_table("test_cv_nolen").unwrap();
    assert_eq!(table.row_count(), 1);
}

#[test]
fn test_insert_with_default_value() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE users (id INT DEFAULT 999, name VARCHAR(50))
    let mut id_column = vibesql_catalog::ColumnSchema::new(
        "id".to_string(),
        vibesql_types::DataType::Integer,
        false,
    );
    id_column.default_value =
        Some(vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Integer(999)));

    let schema = vibesql_catalog::TableSchema::new(
        "users".to_string(),
        vec![
            id_column,
            vibesql_catalog::ColumnSchema::new(
                "name".to_string(),
                vibesql_types::DataType::Varchar { max_length: Some(50) },
                false,
            ),
        ],
    );
    db.create_table(schema).unwrap();

    // INSERT INTO users (id, name) VALUES (DEFAULT, 'Alice')
    let stmt = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "users".to_string(),
        columns: vec!["id".to_string(), "name".to_string()],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Default,
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                arcstr::ArcStr::from("Alice"),
            )),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };

    let rows = InsertExecutor::execute(&mut db, &stmt).unwrap();
    assert_eq!(rows, 1);

    // Verify default value was used
    let table = db.get_table("users").unwrap();
    let row = &table.scan()[0];
    assert_eq!(row.get(0), Some(&vibesql_types::SqlValue::Integer(999)));
    assert_eq!(row.get(1), Some(&vibesql_types::SqlValue::Varchar(arcstr::ArcStr::from("Alice"))));
}

#[test]
fn test_insert_default_no_default_value_defined() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE users (id INT, name VARCHAR(50)) -- no default for id
    let schema = vibesql_catalog::TableSchema::new(
        "users".to_string(),
        vec![
            vibesql_catalog::ColumnSchema::new(
                "id".to_string(),
                vibesql_types::DataType::Integer,
                true,
            ), /* nullable */
            vibesql_catalog::ColumnSchema::new(
                "name".to_string(),
                vibesql_types::DataType::Varchar { max_length: Some(50) },
                false,
            ),
        ],
    );
    db.create_table(schema).unwrap();

    // INSERT INTO users (id, name) VALUES (DEFAULT, 'Alice')
    let stmt = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "users".to_string(),
        columns: vec!["id".to_string(), "name".to_string()],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Default,
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                arcstr::ArcStr::from("Alice"),
            )),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };

    let rows = InsertExecutor::execute(&mut db, &stmt).unwrap();
    assert_eq!(rows, 1);

    // Verify NULL was used when no default is defined
    let table = db.get_table("users").unwrap();
    let row = &table.scan()[0];
    assert_eq!(row.get(0), Some(&vibesql_types::SqlValue::Null));
    assert_eq!(row.get(1), Some(&vibesql_types::SqlValue::Varchar(arcstr::ArcStr::from("Alice"))));
}

// ============================================================================
// INSERT DEFAULT VALUES Tests
// ============================================================================

/// Test INSERT INTO table DEFAULT VALUES syntax
/// This inserts a single row with all columns using their default values
#[test]
fn test_insert_default_values_syntax() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE test_defaults (id INTEGER DEFAULT 42, name TEXT DEFAULT 'default_name', value REAL)
    let mut id_column = vibesql_catalog::ColumnSchema::new(
        "id".to_string(),
        vibesql_types::DataType::Integer,
        true,
    );
    id_column.default_value =
        Some(vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Integer(42)));

    let mut name_column = vibesql_catalog::ColumnSchema::new(
        "name".to_string(),
        vibesql_types::DataType::Varchar { max_length: None },
        true,
    );
    name_column.default_value = Some(vibesql_ast::Expression::Literal(
        vibesql_types::SqlValue::Varchar(arcstr::ArcStr::from("default_name")),
    ));

    let value_column = vibesql_catalog::ColumnSchema::new(
        "value".to_string(),
        vibesql_types::DataType::Real,
        true, // nullable, no default
    );

    let schema = vibesql_catalog::TableSchema::new(
        "test_defaults".to_string(),
        vec![id_column, name_column, value_column],
    );
    db.create_table(schema).unwrap();

    // INSERT INTO test_defaults DEFAULT VALUES
    let stmt = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "test_defaults".to_string(),
        columns: vec![], // No column list
        source: vibesql_ast::InsertSource::DefaultValues,
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };

    let rows = InsertExecutor::execute(&mut db, &stmt).unwrap();
    assert_eq!(rows, 1);

    // Verify: id=42 (default), name='default_name' (default), value=NULL (no default)
    let table = db.get_table("test_defaults").unwrap();
    let row = &table.scan()[0];
    assert_eq!(row.get(0), Some(&vibesql_types::SqlValue::Integer(42)));
    assert_eq!(
        row.get(1),
        Some(&vibesql_types::SqlValue::Varchar(arcstr::ArcStr::from("default_name")))
    );
    assert_eq!(row.get(2), Some(&vibesql_types::SqlValue::Null));
}

/// Test INSERT DEFAULT VALUES with INTEGER PRIMARY KEY (auto-increment)
#[test]
fn test_insert_default_values_with_integer_primary_key() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE autoincrement_test (id INTEGER PRIMARY KEY, name TEXT DEFAULT 'test')
    let mut name_column = vibesql_catalog::ColumnSchema::new(
        "name".to_string(),
        vibesql_types::DataType::Varchar { max_length: None },
        true,
    );
    name_column.default_value = Some(vibesql_ast::Expression::Literal(
        vibesql_types::SqlValue::Varchar(arcstr::ArcStr::from("test")),
    ));

    let schema = vibesql_catalog::TableSchema::with_primary_key(
        "autoincrement_test".to_string(),
        vec![
            vibesql_catalog::ColumnSchema::new(
                "id".to_string(),
                vibesql_types::DataType::Integer,
                false,
            ),
            name_column,
        ],
        vec!["id".to_string()],
    );
    db.create_table(schema).unwrap();

    // INSERT INTO autoincrement_test DEFAULT VALUES (3 times)
    for _ in 0..3 {
        let stmt = vibesql_ast::InsertStmt {
            with_clause: None,
            schema_name: None,
            schema_quoted: false,
            table_quoted: false,
            table_name: "autoincrement_test".to_string(),
            columns: vec![],
            source: vibesql_ast::InsertSource::DefaultValues,
            conflict_clause: None,
            on_conflict: None,
            on_duplicate_key_update: None,
            returning: None,
        };
        InsertExecutor::execute(&mut db, &stmt).unwrap();
    }

    // Verify: 3 rows with auto-incremented IDs (1, 2, 3)
    let table = db.get_table("autoincrement_test").unwrap();
    assert_eq!(table.row_count(), 3);

    let rows = table.scan();
    assert_eq!(rows[0].get(0), Some(&vibesql_types::SqlValue::Integer(1)));
    assert_eq!(rows[1].get(0), Some(&vibesql_types::SqlValue::Integer(2)));
    assert_eq!(rows[2].get(0), Some(&vibesql_types::SqlValue::Integer(3)));
}

// ============================================================================
// INTEGER PRIMARY KEY NULL Auto-Generation Tests (SQLite Semantics)
// ============================================================================

/// Test that inserting NULL into an INTEGER PRIMARY KEY column auto-generates
/// the next value (max + 1, or 1 if table is empty).
#[test]
fn test_integer_primary_key_null_autogen_empty_table() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE track (tid INTEGER PRIMARY KEY, name TEXT)
    let schema = vibesql_catalog::TableSchema::with_primary_key(
        "track".to_string(),
        vec![
            vibesql_catalog::ColumnSchema::new(
                "tid".to_string(),
                vibesql_types::DataType::Integer,
                false, // NOT NULL (implicit for INTEGER PRIMARY KEY)
            ),
            vibesql_catalog::ColumnSchema::new(
                "name".to_string(),
                vibesql_types::DataType::Varchar { max_length: None },
                true,
            ),
        ],
        vec!["tid".to_string()],
    );
    db.create_table(schema).unwrap();

    // INSERT INTO track VALUES (NULL, 'song1')
    let stmt = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "track".to_string(),
        columns: vec![],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Null),
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                arcstr::ArcStr::from("song1"),
            )),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };

    let rows = InsertExecutor::execute(&mut db, &stmt).unwrap();
    assert_eq!(rows, 1);

    // Verify auto-generated value is 1 (first row in empty table)
    let table = db.get_table("track").unwrap();
    let row = &table.scan()[0];
    assert_eq!(row.get(0), Some(&vibesql_types::SqlValue::Integer(1)));
    assert_eq!(row.get(1), Some(&vibesql_types::SqlValue::Varchar(arcstr::ArcStr::from("song1"))));
}

/// Test sequential auto-generation when inserting multiple NULLs
#[test]
fn test_integer_primary_key_null_autogen_sequential() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE items (id INTEGER PRIMARY KEY, val TEXT)
    let schema = vibesql_catalog::TableSchema::with_primary_key(
        "items".to_string(),
        vec![
            vibesql_catalog::ColumnSchema::new(
                "id".to_string(),
                vibesql_types::DataType::Integer,
                false,
            ),
            vibesql_catalog::ColumnSchema::new(
                "val".to_string(),
                vibesql_types::DataType::Varchar { max_length: None },
                true,
            ),
        ],
        vec!["id".to_string()],
    );
    db.create_table(schema).unwrap();

    // INSERT first row with NULL → should get id=1
    let stmt1 = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "items".to_string(),
        columns: vec![],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Null),
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                arcstr::ArcStr::from("a"),
            )),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };
    InsertExecutor::execute(&mut db, &stmt1).unwrap();

    // INSERT second row with NULL → should get id=2
    let stmt2 = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "items".to_string(),
        columns: vec![],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Null),
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                arcstr::ArcStr::from("b"),
            )),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };
    InsertExecutor::execute(&mut db, &stmt2).unwrap();

    // Verify sequential ids
    let table = db.get_table("items").unwrap();
    assert_eq!(table.row_count(), 2);
    assert_eq!(table.scan()[0].get(0), Some(&vibesql_types::SqlValue::Integer(1)));
    assert_eq!(table.scan()[1].get(0), Some(&vibesql_types::SqlValue::Integer(2)));
}

/// Test that explicit values still work, and next NULL uses max + 1
#[test]
fn test_integer_primary_key_null_autogen_after_explicit() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE t (id INTEGER PRIMARY KEY, data TEXT)
    let schema = vibesql_catalog::TableSchema::with_primary_key(
        "t".to_string(),
        vec![
            vibesql_catalog::ColumnSchema::new(
                "id".to_string(),
                vibesql_types::DataType::Integer,
                false,
            ),
            vibesql_catalog::ColumnSchema::new(
                "data".to_string(),
                vibesql_types::DataType::Varchar { max_length: None },
                true,
            ),
        ],
        vec!["id".to_string()],
    );
    db.create_table(schema).unwrap();

    // INSERT explicit value 100
    let stmt1 = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "t".to_string(),
        columns: vec![],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Integer(100)),
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                arcstr::ArcStr::from("explicit"),
            )),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };
    InsertExecutor::execute(&mut db, &stmt1).unwrap();

    // INSERT NULL → should get id=101 (max + 1)
    let stmt2 = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "t".to_string(),
        columns: vec![],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Null),
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                arcstr::ArcStr::from("auto"),
            )),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };
    InsertExecutor::execute(&mut db, &stmt2).unwrap();

    // Verify ids
    let table = db.get_table("t").unwrap();
    assert_eq!(table.row_count(), 2);

    // Find the auto-generated row
    let auto_row = table.scan().iter().find(|r| {
        r.get(1) == Some(&vibesql_types::SqlValue::Varchar(arcstr::ArcStr::from("auto")))
    });
    assert!(auto_row.is_some());
    assert_eq!(auto_row.unwrap().get(0), Some(&vibesql_types::SqlValue::Integer(101)));
}

/// Test that BIGINT PRIMARY KEY does NOT auto-generate (only INTEGER does)
#[test]
fn test_bigint_primary_key_no_autogen() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE t (id BIGINT PRIMARY KEY, data TEXT)
    let schema = vibesql_catalog::TableSchema::with_primary_key(
        "bigint_pk".to_string(),
        vec![
            vibesql_catalog::ColumnSchema::new(
                "id".to_string(),
                vibesql_types::DataType::Bigint, // NOT Integer!
                true,                            // Must be nullable since we're inserting NULL
            ),
            vibesql_catalog::ColumnSchema::new(
                "data".to_string(),
                vibesql_types::DataType::Varchar { max_length: None },
                true,
            ),
        ],
        vec!["id".to_string()],
    );
    db.create_table(schema).unwrap();

    // INSERT NULL should stay as NULL (no auto-generation for BIGINT)
    let stmt = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "bigint_pk".to_string(),
        columns: vec![],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Null),
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                arcstr::ArcStr::from("test"),
            )),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };
    InsertExecutor::execute(&mut db, &stmt).unwrap();

    // Verify NULL is preserved
    let table = db.get_table("bigint_pk").unwrap();
    assert_eq!(table.scan()[0].get(0), Some(&vibesql_types::SqlValue::Null));
}

/// Test multi-row INSERT with all NULLs in INTEGER PRIMARY KEY
#[test]
fn test_integer_primary_key_null_autogen_multirow() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE track (tid INTEGER PRIMARY KEY, name TEXT)
    let schema = vibesql_catalog::TableSchema::with_primary_key(
        "track".to_string(),
        vec![
            vibesql_catalog::ColumnSchema::new(
                "tid".to_string(),
                vibesql_types::DataType::Integer,
                false,
            ),
            vibesql_catalog::ColumnSchema::new(
                "name".to_string(),
                vibesql_types::DataType::Varchar { max_length: None },
                true,
            ),
        ],
        vec!["tid".to_string()],
    );
    db.create_table(schema).unwrap();

    // Multi-row INSERT with all NULLs (like SQLite's orderby1.test)
    // INSERT INTO track VALUES (NULL, 'one'), (NULL, 'two'), (NULL, 'three');
    let stmt = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "track".to_string(),
        columns: vec![],
        source: vibesql_ast::InsertSource::Values(vec![
            vec![
                vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Null),
                vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                    arcstr::ArcStr::from("one"),
                )),
            ],
            vec![
                vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Null),
                vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                    arcstr::ArcStr::from("two"),
                )),
            ],
            vec![
                vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Null),
                vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Varchar(
                    arcstr::ArcStr::from("three"),
                )),
            ],
        ]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };

    let rows = InsertExecutor::execute(&mut db, &stmt).unwrap();
    assert_eq!(rows, 3);

    // Verify all three rows have unique auto-generated ids
    let table = db.get_table("track").unwrap();
    assert_eq!(table.row_count(), 3);

    let ids: Vec<i64> = table
        .scan()
        .iter()
        .filter_map(|r| {
            if let Some(vibesql_types::SqlValue::Integer(id)) = r.get(0) {
                Some(*id)
            } else {
                None
            }
        })
        .collect();

    // All ids should be unique
    let mut sorted_ids = ids.clone();
    sorted_ids.sort();
    assert_eq!(sorted_ids, vec![1, 2, 3], "Expected sequential ids 1, 2, 3");
}

/// Test composite primary key does NOT auto-generate
#[test]
fn test_composite_primary_key_no_autogen() {
    let mut db = vibesql_storage::Database::new();

    // CREATE TABLE t (a INTEGER, b INTEGER, PRIMARY KEY(a, b))
    let schema = vibesql_catalog::TableSchema::with_primary_key(
        "composite_pk".to_string(),
        vec![
            vibesql_catalog::ColumnSchema::new(
                "a".to_string(),
                vibesql_types::DataType::Integer,
                true, // Must be nullable
            ),
            vibesql_catalog::ColumnSchema::new(
                "b".to_string(),
                vibesql_types::DataType::Integer,
                true,
            ),
        ],
        vec!["a".to_string(), "b".to_string()], // Composite PK
    );
    db.create_table(schema).unwrap();

    // INSERT NULL should stay as NULL (no auto-generation for composite PK)
    let stmt = vibesql_ast::InsertStmt {
        with_clause: None,
        schema_name: None,
        schema_quoted: false,
        table_quoted: false,
        table_name: "composite_pk".to_string(),
        columns: vec![],
        source: vibesql_ast::InsertSource::Values(vec![vec![
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Null),
            vibesql_ast::Expression::Literal(vibesql_types::SqlValue::Integer(1)),
        ]]),
        conflict_clause: None,
        on_conflict: None,
        on_duplicate_key_update: None,
        returning: None,
    };
    InsertExecutor::execute(&mut db, &stmt).unwrap();

    // Verify NULL is preserved
    let table = db.get_table("composite_pk").unwrap();
    assert_eq!(table.scan()[0].get(0), Some(&vibesql_types::SqlValue::Null));
}