1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
//! Pattern compilation
//!
//! Compiles destructuring patterns to bytecode.
use super::Compiler;
use super::bytecode::{Op, Register};
use crate::ast::{ObjectPatternProperty, ObjectPropertyKey, Pattern};
use crate::error::JsError;
use crate::prelude::*;
use crate::value::CheapClone;
impl Compiler {
/// Compile a pattern binding (for variable declarations)
/// Creates new variable bindings from the pattern
pub fn compile_pattern_binding(
&mut self,
pattern: &Pattern,
value_reg: Register,
mutable: bool,
is_var: bool,
) -> Result<(), JsError> {
match pattern {
Pattern::Identifier(id) => {
// In strict mode (which we always use), 'eval' and 'arguments' cannot be binding names
if id.name.as_ref() == "eval" || id.name.as_ref() == "arguments" {
return Err(JsError::syntax_error_simple(
"Unexpected eval or arguments in strict mode".to_string(),
));
}
let name_idx = self.builder.add_string(id.name.cheap_clone())?;
if is_var {
// For var declarations, check if already hoisted
if self.is_hoisted(&id.name) {
// Already hoisted - just assign
self.builder.emit(Op::SetVar {
name: name_idx,
src: value_reg,
});
} else {
// Not hoisted yet (e.g., inside eval or dynamic scope)
self.builder.emit(Op::DeclareVarHoisted {
name: name_idx,
init: value_reg,
});
}
} else {
self.builder.emit(Op::DeclareVar {
name: name_idx,
init: value_reg,
mutable,
});
}
Ok(())
}
Pattern::Object(obj_pat) => {
self.compile_object_pattern_binding(obj_pat, value_reg, mutable, is_var)
}
Pattern::Array(arr_pat) => {
self.compile_array_pattern_binding(arr_pat, value_reg, mutable, is_var)
}
Pattern::Assignment(assign_pat) => {
// Pattern with default value: pattern = defaultValue
// If value is undefined, use default
let actual_value = self.builder.alloc_register()?;
// Check if value is undefined
let is_undefined = self.builder.alloc_register()?;
self.builder.emit(Op::LoadUndefined { dst: is_undefined });
self.builder.emit(Op::StrictEq {
dst: is_undefined,
left: value_reg,
right: is_undefined,
});
// If undefined, use default; otherwise use value
let skip_default = self.builder.emit_jump_if_false(is_undefined);
self.builder.free_register(is_undefined);
// Use default value - with name inference if left is an identifier
if let Pattern::Identifier(id) = &*assign_pat.left {
// Pass the identifier name for function name inference
self.compile_expression_with_inferred_name(
&assign_pat.right,
actual_value,
Some(id.name.cheap_clone()),
)?;
} else {
self.compile_expression(&assign_pat.right, actual_value)?;
}
let skip_value = self.builder.emit_jump();
// Use provided value
self.builder.patch_jump(skip_default);
self.builder.emit(Op::Move {
dst: actual_value,
src: value_reg,
});
self.builder.patch_jump(skip_value);
// Recursively bind to the inner pattern
self.compile_pattern_binding(&assign_pat.left, actual_value, mutable, is_var)?;
self.builder.free_register(actual_value);
Ok(())
}
Pattern::Rest(rest) => {
// Rest element in pattern - this should only appear in array patterns
// At this level, value_reg already contains the rest array
self.compile_pattern_binding(&rest.argument, value_reg, mutable, is_var)
}
}
}
/// Compile object pattern binding
fn compile_object_pattern_binding(
&mut self,
obj_pat: &crate::ast::ObjectPattern,
value_reg: Register,
mutable: bool,
is_var: bool,
) -> Result<(), JsError> {
use crate::value::JsString;
// First pass: collect keys that will be extracted (for rest handling)
let mut extracted_keys: Vec<JsString> = Vec::new();
let mut has_rest = false;
for prop in &obj_pat.properties {
match prop {
ObjectPatternProperty::KeyValue { key, .. } => {
// Collect the key name for rest handling
match key {
ObjectPropertyKey::Identifier(id) => {
extracted_keys.push(id.name.cheap_clone());
}
ObjectPropertyKey::String(s) => {
extracted_keys.push(s.value.cheap_clone());
}
// Computed keys can't be statically known, skip them
// (rest will still work but may include some extra props)
ObjectPropertyKey::Computed(_) | ObjectPropertyKey::Number(_) => {}
ObjectPropertyKey::PrivateIdentifier(_) => {}
}
}
ObjectPatternProperty::Rest(_) => {
has_rest = true;
}
}
}
// Second pass: compile bindings
for prop in &obj_pat.properties {
match prop {
ObjectPatternProperty::KeyValue {
key,
value,
shorthand: _,
span: _,
} => {
// Get property from object
let prop_value = self.builder.alloc_register()?;
match key {
ObjectPropertyKey::Identifier(id) => {
let key_idx = self.builder.add_string(id.name.cheap_clone())?;
self.builder.emit(Op::GetPropertyConst {
dst: prop_value,
obj: value_reg,
key: key_idx,
});
}
ObjectPropertyKey::String(s) => {
let key_idx = self.builder.add_string(s.value.cheap_clone())?;
self.builder.emit(Op::GetPropertyConst {
dst: prop_value,
obj: value_reg,
key: key_idx,
});
}
ObjectPropertyKey::Computed(expr) => {
let key_reg = self.builder.alloc_register()?;
self.compile_expression(expr, key_reg)?;
self.builder.emit(Op::GetProperty {
dst: prop_value,
obj: value_reg,
key: key_reg,
});
self.builder.free_register(key_reg);
}
ObjectPropertyKey::Number(lit) => {
let key_reg = self.builder.alloc_register()?;
self.compile_literal(&lit.value, key_reg)?;
self.builder.emit(Op::GetProperty {
dst: prop_value,
obj: value_reg,
key: key_reg,
});
self.builder.free_register(key_reg);
}
ObjectPropertyKey::PrivateIdentifier(_) => {
return Err(JsError::syntax_error_simple(
"Private identifiers not yet supported in destructuring",
));
}
}
// Bind to the value pattern
self.compile_pattern_binding(value, prop_value, mutable, is_var)?;
self.builder.free_register(prop_value);
}
ObjectPatternProperty::Rest(rest) => {
// Rest in object destructuring: { a, ...rest }
// Create object with remaining properties (excluding extracted keys)
let rest_obj = self.builder.alloc_register()?;
if has_rest && !extracted_keys.is_empty() {
// Add excluded keys to constant pool
let excluded_idx =
self.builder.add_excluded_keys(extracted_keys.clone())?;
self.builder.emit(Op::CreateObjectRest {
dst: rest_obj,
src: value_reg,
excluded_keys: excluded_idx,
});
} else {
// No keys to exclude, copy all properties
let excluded_idx = self.builder.add_excluded_keys(vec![])?;
self.builder.emit(Op::CreateObjectRest {
dst: rest_obj,
src: value_reg,
excluded_keys: excluded_idx,
});
}
self.compile_pattern_binding(&rest.argument, rest_obj, mutable, is_var)?;
self.builder.free_register(rest_obj);
}
}
}
Ok(())
}
/// Compile array pattern binding
fn compile_array_pattern_binding(
&mut self,
arr_pat: &crate::ast::ArrayPattern,
value_reg: Register,
mutable: bool,
is_var: bool,
) -> Result<(), JsError> {
// Get iterator for the value
let iter_reg = self.builder.alloc_register()?;
self.builder.emit(Op::GetIterator {
dst: iter_reg,
obj: value_reg,
});
let result_reg = self.builder.alloc_register()?;
let elem_value = self.builder.alloc_register()?;
// Track if iterator is exhausted (by rest pattern)
let mut iterator_exhausted = false;
for (i, elem) in arr_pat.elements.iter().enumerate() {
if let Some(pattern) = elem {
// Check for rest pattern
if let Pattern::Rest(rest) = pattern {
// Collect remaining elements into an array
// This exhausts the iterator, so no need to close it
let rest_arr = self.builder.alloc_register()?;
self.builder.emit(Op::CreateRestArray {
dst: rest_arr,
start_index: i as u8,
});
self.compile_pattern_binding(&rest.argument, rest_arr, mutable, is_var)?;
self.builder.free_register(rest_arr);
iterator_exhausted = true;
break;
}
// Get next iterator value
self.builder.emit(Op::IteratorNext {
dst: result_reg,
iterator: iter_reg,
});
// Get the value (or undefined if done)
self.builder.emit(Op::IteratorValue {
dst: elem_value,
result: result_reg,
});
// Bind to the pattern
self.compile_pattern_binding(pattern, elem_value, mutable, is_var)?;
} else {
// Hole in array pattern - skip this element
self.builder.emit(Op::IteratorNext {
dst: result_reg,
iterator: iter_reg,
});
}
}
// Close the iterator if it wasn't exhausted
// Per ES spec, IteratorClose should be called when destructuring
// completes without exhausting the iterator
if !iterator_exhausted {
self.builder.emit(Op::IteratorClose { iterator: iter_reg });
}
self.builder.free_register(elem_value);
self.builder.free_register(result_reg);
self.builder.free_register(iter_reg);
Ok(())
}
/// Compile a pattern assignment (for assignment expressions)
/// Assigns to existing bindings from the pattern
pub fn compile_pattern_assignment(
&mut self,
pattern: &Pattern,
value_reg: Register,
) -> Result<(), JsError> {
match pattern {
Pattern::Identifier(id) => {
let name_idx = self.builder.add_string(id.name.cheap_clone())?;
self.builder.emit(Op::SetVar {
name: name_idx,
src: value_reg,
});
Ok(())
}
Pattern::Object(obj_pat) => self.compile_object_pattern_assignment(obj_pat, value_reg),
Pattern::Array(arr_pat) => self.compile_array_pattern_assignment(arr_pat, value_reg),
Pattern::Assignment(assign_pat) => {
// Pattern with default value
let actual_value = self.builder.alloc_register()?;
// Check if value is undefined
let is_undefined = self.builder.alloc_register()?;
self.builder.emit(Op::LoadUndefined { dst: is_undefined });
self.builder.emit(Op::StrictEq {
dst: is_undefined,
left: value_reg,
right: is_undefined,
});
let skip_default = self.builder.emit_jump_if_false(is_undefined);
self.builder.free_register(is_undefined);
// Use default value - with name inference if left is an identifier
if let Pattern::Identifier(id) = &*assign_pat.left {
// Pass the identifier name for function name inference
self.compile_expression_with_inferred_name(
&assign_pat.right,
actual_value,
Some(id.name.cheap_clone()),
)?;
} else {
self.compile_expression(&assign_pat.right, actual_value)?;
}
let skip_value = self.builder.emit_jump();
// Use provided value
self.builder.patch_jump(skip_default);
self.builder.emit(Op::Move {
dst: actual_value,
src: value_reg,
});
self.builder.patch_jump(skip_value);
// Recursively assign
self.compile_pattern_assignment(&assign_pat.left, actual_value)?;
self.builder.free_register(actual_value);
Ok(())
}
Pattern::Rest(rest) => self.compile_pattern_assignment(&rest.argument, value_reg),
}
}
/// Compile object pattern assignment
fn compile_object_pattern_assignment(
&mut self,
obj_pat: &crate::ast::ObjectPattern,
value_reg: Register,
) -> Result<(), JsError> {
use crate::value::JsString;
// First pass: collect keys that will be extracted (for rest handling)
let mut extracted_keys: Vec<JsString> = Vec::new();
let mut has_rest = false;
for prop in &obj_pat.properties {
match prop {
ObjectPatternProperty::KeyValue { key, .. } => match key {
ObjectPropertyKey::Identifier(id) => {
extracted_keys.push(id.name.cheap_clone());
}
ObjectPropertyKey::String(s) => {
extracted_keys.push(s.value.cheap_clone());
}
ObjectPropertyKey::Computed(_) | ObjectPropertyKey::Number(_) => {}
ObjectPropertyKey::PrivateIdentifier(_) => {}
},
ObjectPatternProperty::Rest(_) => {
has_rest = true;
}
}
}
// Second pass: compile assignments
for prop in &obj_pat.properties {
match prop {
ObjectPatternProperty::KeyValue {
key,
value,
shorthand: _,
span: _,
} => {
let prop_value = self.builder.alloc_register()?;
match key {
ObjectPropertyKey::Identifier(id) => {
let key_idx = self.builder.add_string(id.name.cheap_clone())?;
self.builder.emit(Op::GetPropertyConst {
dst: prop_value,
obj: value_reg,
key: key_idx,
});
}
ObjectPropertyKey::String(s) => {
let key_idx = self.builder.add_string(s.value.cheap_clone())?;
self.builder.emit(Op::GetPropertyConst {
dst: prop_value,
obj: value_reg,
key: key_idx,
});
}
ObjectPropertyKey::Computed(expr) => {
let key_reg = self.builder.alloc_register()?;
self.compile_expression(expr, key_reg)?;
self.builder.emit(Op::GetProperty {
dst: prop_value,
obj: value_reg,
key: key_reg,
});
self.builder.free_register(key_reg);
}
ObjectPropertyKey::Number(lit) => {
let key_reg = self.builder.alloc_register()?;
self.compile_literal(&lit.value, key_reg)?;
self.builder.emit(Op::GetProperty {
dst: prop_value,
obj: value_reg,
key: key_reg,
});
self.builder.free_register(key_reg);
}
ObjectPropertyKey::PrivateIdentifier(_) => {
return Err(JsError::syntax_error_simple(
"Private identifiers not yet supported in destructuring",
));
}
}
self.compile_pattern_assignment(value, prop_value)?;
self.builder.free_register(prop_value);
}
ObjectPatternProperty::Rest(rest) => {
let rest_obj = self.builder.alloc_register()?;
if has_rest {
let excluded_idx =
self.builder.add_excluded_keys(extracted_keys.clone())?;
self.builder.emit(Op::CreateObjectRest {
dst: rest_obj,
src: value_reg,
excluded_keys: excluded_idx,
});
} else {
let excluded_idx = self.builder.add_excluded_keys(vec![])?;
self.builder.emit(Op::CreateObjectRest {
dst: rest_obj,
src: value_reg,
excluded_keys: excluded_idx,
});
}
self.compile_pattern_assignment(&rest.argument, rest_obj)?;
self.builder.free_register(rest_obj);
}
}
}
Ok(())
}
/// Compile array pattern assignment
fn compile_array_pattern_assignment(
&mut self,
arr_pat: &crate::ast::ArrayPattern,
value_reg: Register,
) -> Result<(), JsError> {
let iter_reg = self.builder.alloc_register()?;
self.builder.emit(Op::GetIterator {
dst: iter_reg,
obj: value_reg,
});
let result_reg = self.builder.alloc_register()?;
let elem_value = self.builder.alloc_register()?;
// Track if iterator is exhausted (by rest pattern)
let mut iterator_exhausted = false;
for (i, elem) in arr_pat.elements.iter().enumerate() {
if let Some(pattern) = elem {
if let Pattern::Rest(rest) = pattern {
let rest_arr = self.builder.alloc_register()?;
self.builder.emit(Op::CreateRestArray {
dst: rest_arr,
start_index: i as u8,
});
self.compile_pattern_assignment(&rest.argument, rest_arr)?;
self.builder.free_register(rest_arr);
iterator_exhausted = true;
break;
}
self.builder.emit(Op::IteratorNext {
dst: result_reg,
iterator: iter_reg,
});
self.builder.emit(Op::IteratorValue {
dst: elem_value,
result: result_reg,
});
self.compile_pattern_assignment(pattern, elem_value)?;
} else {
self.builder.emit(Op::IteratorNext {
dst: result_reg,
iterator: iter_reg,
});
}
}
// Close the iterator if it wasn't exhausted
// Per ES spec, IteratorClose should be called when destructuring
// completes without exhausting the iterator
if !iterator_exhausted {
self.builder.emit(Op::IteratorClose { iterator: iter_reg });
}
self.builder.free_register(elem_value);
self.builder.free_register(result_reg);
self.builder.free_register(iter_reg);
Ok(())
}
}