[{"url":"https://api.github.com/repos/astral-sh/ruff/pulls/comments/1946208119","pull_request_review_id":2601201016,"id":1946208119,"node_id":"PRRC_kwDOHy0Bzc50AMd3","diff_hunk":"@@ -0,0 +1,53 @@\n+use std::sync::Arc;\n+\n+use red_knot_python_semantic::lint::RuleSelection;\n+\n+/// The resolved [`super::Options`] for the project.\n+///\n+/// Unlike [`super::Options`], the struct has default values filled in and\n+/// uses representations that are optimized for reads (instead of preserving the source representation).\n+/// It's also not required that this structure precisely resembles the TOML schema, although\n+/// it's encouraged to use a similar structure.\n+///\n+/// It's worth considering to adding a salsa query for specific settings to\n+/// limite the blast radius when only some settings change. For example,\n+/// changing the terminal settings shouldn't invalidate any core type-checking queries.\n+/// This can be achieved by adding a salsa query for the type checking specific settings.\n+///\n+/// Settings that are part of [`ProgramSettings`] are not included here.\n+#[derive(Clone, Debug, Eq, PartialEq)]\n+pub struct Settings {","path":"crates/red_knot_project/src/metadata/settings.rs","commit_id":"71e4b8938044fb18f88b6d07378d1d2069ed7792","original_commit_id":"9020e417b82e363c8d203d5362a7ab8969b7e187","user":{"login":"dhruvmanila","id":67177269,"node_id":"MDQ6VXNlcjY3MTc3MjY5","avatar_url":"https://avatars.githubusercontent.com/u/67177269?v=4","gravatar_id":"","url":"https://api.github.com/users/dhruvmanila","html_url":"https://github.com/dhruvmanila","followers_url":"https://api.github.com/users/dhruvmanila/followers","following_url":"https://api.github.com/users/dhruvmanila/following{/other_user}","gists_url":"https://api.github.com/users/dhruvmanila/gists{/gist_id}","starred_url":"https://api.github.com/users/dhruvmanila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhruvmanila/subscriptions","organizations_url":"https://api.github.com/users/dhruvmanila/orgs","repos_url":"https://api.github.com/users/dhruvmanila/repos","events_url":"https://api.github.com/users/dhruvmanila/events{/privacy}","received_events_url":"https://api.github.com/users/dhruvmanila/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"I believe this will help in converting the mdtest config options into the final resolved settings for the project?","created_at":"2025-02-07T09:12:23Z","updated_at":"2025-02-07T09:12:23Z","html_url":"https://github.com/astral-sh/ruff/pull/16000#discussion_r1946208119","pull_request_url":"https://api.github.com/repos/astral-sh/ruff/pulls/16000","_links":{"self":{"href":"https://api.github.com/repos/astral-sh/ruff/pulls/comments/1946208119"},"html":{"href":"https://github.com/astral-sh/ruff/pull/16000#discussion_r1946208119"},"pull_request":{"href":"https://api.github.com/repos/astral-sh/ruff/pulls/16000"}},"reactions":{"url":"https://api.github.com/repos/astral-sh/ruff/pulls/comments/1946208119/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":19,"original_line":19,"side":"RIGHT","author_association":"MEMBER","original_position":19,"position":19,"subject_type":"line"},{"url":"https://api.github.com/repos/astral-sh/ruff/pulls/comments/1946274087","pull_request_review_id":2601308845,"id":1946274087,"node_id":"PRRC_kwDOHy0Bzc50Ackn","diff_hunk":"@@ -0,0 +1,53 @@\n+use std::sync::Arc;\n+\n+use red_knot_python_semantic::lint::RuleSelection;\n+\n+/// The resolved [`super::Options`] for the project.\n+///\n+/// Unlike [`super::Options`], the struct has default values filled in and\n+/// uses representations that are optimized for reads (instead of preserving the source representation).\n+/// It's also not required that this structure precisely resembles the TOML schema, although\n+/// it's encouraged to use a similar structure.\n+///\n+/// It's worth considering to adding a salsa query for specific settings to\n+/// limite the blast radius when only some settings change. For example,\n+/// changing the terminal settings shouldn't invalidate any core type-checking queries.\n+/// This can be achieved by adding a salsa query for the type checking specific settings.\n+///\n+/// Settings that are part of [`ProgramSettings`] are not included here.\n+#[derive(Clone, Debug, Eq, PartialEq)]\n+pub struct Settings {","path":"crates/red_knot_project/src/metadata/settings.rs","commit_id":"71e4b8938044fb18f88b6d07378d1d2069ed7792","original_commit_id":"9020e417b82e363c8d203d5362a7ab8969b7e187","user":{"login":"MichaReiser","id":1203881,"node_id":"MDQ6VXNlcjEyMDM4ODE=","avatar_url":"https://avatars.githubusercontent.com/u/1203881?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaReiser","html_url":"https://github.com/MichaReiser","followers_url":"https://api.github.com/users/MichaReiser/followers","following_url":"https://api.github.com/users/MichaReiser/following{/other_user}","gists_url":"https://api.github.com/users/MichaReiser/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaReiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaReiser/subscriptions","organizations_url":"https://api.github.com/users/MichaReiser/orgs","repos_url":"https://api.github.com/users/MichaReiser/repos","events_url":"https://api.github.com/users/MichaReiser/events{/privacy}","received_events_url":"https://api.github.com/users/MichaReiser/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Probably not because the `mdtest` framework doesn't depend on `red_knot_project`, unless we decide to change that.","created_at":"2025-02-07T10:00:21Z","updated_at":"2025-02-07T10:00:21Z","html_url":"https://github.com/astral-sh/ruff/pull/16000#discussion_r1946274087","pull_request_url":"https://api.github.com/repos/astral-sh/ruff/pulls/16000","_links":{"self":{"href":"https://api.github.com/repos/astral-sh/ruff/pulls/comments/1946274087"},"html":{"href":"https://github.com/astral-sh/ruff/pull/16000#discussion_r1946274087"},"pull_request":{"href":"https://api.github.com/repos/astral-sh/ruff/pulls/16000"}},"reactions":{"url":"https://api.github.com/repos/astral-sh/ruff/pulls/comments/1946274087/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":19,"original_line":19,"side":"RIGHT","in_reply_to_id":1946208119,"author_association":"MEMBER","original_position":19,"position":19,"subject_type":"line"},{"url":"https://api.github.com/repos/astral-sh/ruff/pulls/comments/1946350354","pull_request_review_id":2601437666,"id":1946350354,"node_id":"PRRC_kwDOHy0Bzc50AvMS","diff_hunk":"@@ -0,0 +1,53 @@\n+use std::sync::Arc;\n+\n+use red_knot_python_semantic::lint::RuleSelection;\n+\n+/// The resolved [`super::Options`] for the project.\n+///\n+/// Unlike [`super::Options`], the struct has default values filled in and\n+/// uses representations that are optimized for reads (instead of preserving the source representation).\n+/// It's also not required that this structure precisely resembles the TOML schema, although\n+/// it's encouraged to use a similar structure.\n+///\n+/// It's worth considering to adding a salsa query for specific settings to\n+/// limite the blast radius when only some settings change. For example,\n+/// changing the terminal settings shouldn't invalidate any core type-checking queries.\n+/// This can be achieved by adding a salsa query for the type checking specific settings.\n+///\n+/// Settings that are part of [`ProgramSettings`] are not included here.\n+#[derive(Clone, Debug, Eq, PartialEq)]\n+pub struct Settings {","path":"crates/red_knot_project/src/metadata/settings.rs","commit_id":"71e4b8938044fb18f88b6d07378d1d2069ed7792","original_commit_id":"9020e417b82e363c8d203d5362a7ab8969b7e187","user":{"login":"dhruvmanila","id":67177269,"node_id":"MDQ6VXNlcjY3MTc3MjY5","avatar_url":"https://avatars.githubusercontent.com/u/67177269?v=4","gravatar_id":"","url":"https://api.github.com/users/dhruvmanila","html_url":"https://github.com/dhruvmanila","followers_url":"https://api.github.com/users/dhruvmanila/followers","following_url":"https://api.github.com/users/dhruvmanila/following{/other_user}","gists_url":"https://api.github.com/users/dhruvmanila/gists{/gist_id}","starred_url":"https://api.github.com/users/dhruvmanila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhruvmanila/subscriptions","organizations_url":"https://api.github.com/users/dhruvmanila/orgs","repos_url":"https://api.github.com/users/dhruvmanila/repos","events_url":"https://api.github.com/users/dhruvmanila/events{/privacy}","received_events_url":"https://api.github.com/users/dhruvmanila/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Ah right.","created_at":"2025-02-07T10:57:50Z","updated_at":"2025-02-07T10:57:51Z","html_url":"https://github.com/astral-sh/ruff/pull/16000#discussion_r1946350354","pull_request_url":"https://api.github.com/repos/astral-sh/ruff/pulls/16000","_links":{"self":{"href":"https://api.github.com/repos/astral-sh/ruff/pulls/comments/1946350354"},"html":{"href":"https://github.com/astral-sh/ruff/pull/16000#discussion_r1946350354"},"pull_request":{"href":"https://api.github.com/repos/astral-sh/ruff/pulls/16000"}},"reactions":{"url":"https://api.github.com/repos/astral-sh/ruff/pulls/comments/1946350354/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":19,"original_line":19,"side":"RIGHT","in_reply_to_id":1946208119,"author_association":"MEMBER","original_position":19,"position":19,"subject_type":"line"}]