[{"url":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/comments/1766848243","pull_request_review_id":2315570568,"id":1766848243,"node_id":"PRRC_kwDOAzJbyc5pT_bz","diff_hunk":"@@ -351,6 +351,27 @@ impl GlobSet {\n false\n }\n \n+ /// Returns true if ALL globs in this set match the path given.","path":"crates/globset/src/lib.rs","commit_id":"c26831ce39d3cfa36db8f913998ab8b52be4d38c","original_commit_id":"3c17c22ef64e78064d8c621b118d7cdb3652fa76","user":{"login":"BurntSushi","id":456674,"node_id":"MDQ6VXNlcjQ1NjY3NA==","avatar_url":"https://avatars.githubusercontent.com/u/456674?v=4","gravatar_id":"","url":"https://api.github.com/users/BurntSushi","html_url":"https://github.com/BurntSushi","followers_url":"https://api.github.com/users/BurntSushi/followers","following_url":"https://api.github.com/users/BurntSushi/following{/other_user}","gists_url":"https://api.github.com/users/BurntSushi/gists{/gist_id}","starred_url":"https://api.github.com/users/BurntSushi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurntSushi/subscriptions","organizations_url":"https://api.github.com/users/BurntSushi/orgs","repos_url":"https://api.github.com/users/BurntSushi/repos","events_url":"https://api.github.com/users/BurntSushi/events{/privacy}","received_events_url":"https://api.github.com/users/BurntSushi/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"I don't think we need to use caps for `ALL` here. Just \"all\" is fine.","created_at":"2024-09-19T13:34:43Z","updated_at":"2024-09-19T13:41:27Z","html_url":"https://github.com/BurntSushi/ripgrep/pull/2900#discussion_r1766848243","pull_request_url":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/2900","_links":{"self":{"href":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/comments/1766848243"},"html":{"href":"https://github.com/BurntSushi/ripgrep/pull/2900#discussion_r1766848243"},"pull_request":{"href":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/2900"}},"reactions":{"url":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/comments/1766848243/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":null,"original_line":354,"side":"RIGHT","author_association":"OWNER","original_position":4,"position":1,"subject_type":"line"},{"url":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/comments/1766859217","pull_request_review_id":2315570568,"id":1766859217,"node_id":"PRRC_kwDOAzJbyc5pUCHR","diff_hunk":"@@ -351,6 +351,27 @@ impl GlobSet {\n false\n }\n \n+ /// Returns true if ALL globs in this set match the path given.\n+ pub fn matches_all<P: AsRef<Path>>(&self, path: P) -> bool {\n+ self.matches_all_candidate(&Candidate::new(path.as_ref()))\n+ }\n+\n+ /// Returns ture if all globs in this set match the path given.\n+ ///\n+ /// This takes a Candidate as input, which can be used to amortize the\n+ /// cost of peparing a path for matching.\n+ ///\n+ /// This will return true if the set of globs is empty, as in that case all `0` of\n+ /// the globs will match.","path":"crates/globset/src/lib.rs","commit_id":"c26831ce39d3cfa36db8f913998ab8b52be4d38c","original_commit_id":"3c17c22ef64e78064d8c621b118d7cdb3652fa76","user":{"login":"BurntSushi","id":456674,"node_id":"MDQ6VXNlcjQ1NjY3NA==","avatar_url":"https://avatars.githubusercontent.com/u/456674?v=4","gravatar_id":"","url":"https://api.github.com/users/BurntSushi","html_url":"https://github.com/BurntSushi","followers_url":"https://api.github.com/users/BurntSushi/followers","following_url":"https://api.github.com/users/BurntSushi/following{/other_user}","gists_url":"https://api.github.com/users/BurntSushi/gists{/gist_id}","starred_url":"https://api.github.com/users/BurntSushi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurntSushi/subscriptions","organizations_url":"https://api.github.com/users/BurntSushi/orgs","repos_url":"https://api.github.com/users/BurntSushi/repos","events_url":"https://api.github.com/users/BurntSushi/events{/privacy}","received_events_url":"https://api.github.com/users/BurntSushi/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Please wrap lines to 79 columns (inclusive).","created_at":"2024-09-19T13:39:26Z","updated_at":"2024-09-19T13:41:27Z","html_url":"https://github.com/BurntSushi/ripgrep/pull/2900#discussion_r1766859217","pull_request_url":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/2900","_links":{"self":{"href":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/comments/1766859217"},"html":{"href":"https://github.com/BurntSushi/ripgrep/pull/2900#discussion_r1766859217"},"pull_request":{"href":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/2900"}},"reactions":{"url":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/comments/1766859217/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":null,"original_line":365,"side":"RIGHT","author_association":"OWNER","original_position":15,"position":1,"subject_type":"line"},{"url":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/comments/1766860858","pull_request_review_id":2315570568,"id":1766860858,"node_id":"PRRC_kwDOAzJbyc5pUCg6","diff_hunk":"@@ -351,6 +351,27 @@ impl GlobSet {\n false\n }\n \n+ /// Returns true if ALL globs in this set match the path given.\n+ pub fn matches_all<P: AsRef<Path>>(&self, path: P) -> bool {\n+ self.matches_all_candidate(&Candidate::new(path.as_ref()))\n+ }\n+\n+ /// Returns ture if all globs in this set match the path given.\n+ ///\n+ /// This takes a Candidate as input, which can be used to amortize the\n+ /// cost of peparing a path for matching.\n+ ///\n+ /// This will return true if the set of globs is empty, as in that case all `0` of\n+ /// the globs will match.","path":"crates/globset/src/lib.rs","commit_id":"c26831ce39d3cfa36db8f913998ab8b52be4d38c","original_commit_id":"3c17c22ef64e78064d8c621b118d7cdb3652fa76","user":{"login":"BurntSushi","id":456674,"node_id":"MDQ6VXNlcjQ1NjY3NA==","avatar_url":"https://avatars.githubusercontent.com/u/456674?v=4","gravatar_id":"","url":"https://api.github.com/users/BurntSushi","html_url":"https://github.com/BurntSushi","followers_url":"https://api.github.com/users/BurntSushi/followers","following_url":"https://api.github.com/users/BurntSushi/following{/other_user}","gists_url":"https://api.github.com/users/BurntSushi/gists{/gist_id}","starred_url":"https://api.github.com/users/BurntSushi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurntSushi/subscriptions","organizations_url":"https://api.github.com/users/BurntSushi/orgs","repos_url":"https://api.github.com/users/BurntSushi/repos","events_url":"https://api.github.com/users/BurntSushi/events{/privacy}","received_events_url":"https://api.github.com/users/BurntSushi/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Also, this note should be added to `matches_all` too.","created_at":"2024-09-19T13:39:52Z","updated_at":"2024-09-19T13:41:27Z","html_url":"https://github.com/BurntSushi/ripgrep/pull/2900#discussion_r1766860858","pull_request_url":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/2900","_links":{"self":{"href":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/comments/1766860858"},"html":{"href":"https://github.com/BurntSushi/ripgrep/pull/2900#discussion_r1766860858"},"pull_request":{"href":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/2900"}},"reactions":{"url":"https://api.github.com/repos/BurntSushi/ripgrep/pulls/comments/1766860858/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":null,"original_line":365,"side":"RIGHT","in_reply_to_id":1766859217,"author_association":"OWNER","original_position":15,"position":1,"subject_type":"line"}]