syncable-cli 0.37.1

A Rust-based CLI that analyzes code repositories and generates Infrastructure as Code configurations
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66

//! DL4005: Use SHELL to change the default shell
//!
//! Instead of using shell commands to change the shell, use the SHELL instruction.

use crate::analyzer::hadolint::parser::instruction::Instruction;
use crate::analyzer::hadolint::rules::{SimpleRule, simple_rule};
use crate::analyzer::hadolint::shell::ParsedShell;
use crate::analyzer::hadolint::types::Severity;

pub fn rule() -> SimpleRule<impl Fn(&Instruction, Option<&ParsedShell>) -> bool + Send + Sync> {
    simple_rule(
        "DL4005",
        Severity::Warning,
        "Use `SHELL` to change the default shell.",
        |instr, _shell| {
            match instr {
                Instruction::Run(args) => {
                    let cmd_text = match &args.arguments {
                        crate::analyzer::hadolint::parser::instruction::Arguments::Text(t) => {
                            t.as_str()
                        }
                        crate::analyzer::hadolint::parser::instruction::Arguments::List(l) => {
                            if l.is_empty() {
                                return true;
                            }
                            l.first().map(|s| s.as_str()).unwrap_or("")
                        }
                    };

                    // Check for commands that try to change shell
                    !cmd_text.contains("ln -s") || !cmd_text.contains("/bin/sh")
                }
                _ => true,
            }
        },
    )
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::analyzer::hadolint::config::HadolintConfig;
    use crate::analyzer::hadolint::lint::{LintResult, lint};

    fn lint_dockerfile(content: &str) -> LintResult {
        lint(content, &HadolintConfig::default())
    }

    #[test]
    fn test_shell_instruction() {
        let result = lint_dockerfile("FROM ubuntu:20.04\nSHELL [\"/bin/bash\", \"-c\"]");
        assert!(!result.failures.iter().any(|f| f.code.as_str() == "DL4005"));
    }

    #[test]
    fn test_ln_s_shell() {
        let result = lint_dockerfile("FROM ubuntu:20.04\nRUN ln -s /bin/bash /bin/sh");
        assert!(result.failures.iter().any(|f| f.code.as_str() == "DL4005"));
    }

    #[test]
    fn test_normal_run() {
        let result = lint_dockerfile("FROM ubuntu:20.04\nRUN echo hello");
        assert!(!result.failures.iter().any(|f| f.code.as_str() == "DL4005"));
    }
}