syncable-cli 0.37.1

A Rust-based CLI that analyzes code repositories and generates Infrastructure as Code configurations
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86

//! DL3009: Delete the apt-get lists after installing something
//!
//! After installing packages with apt-get, the package lists should be
//! removed to reduce image size.

use crate::analyzer::hadolint::parser::instruction::Instruction;
use crate::analyzer::hadolint::rules::{SimpleRule, simple_rule};
use crate::analyzer::hadolint::shell::ParsedShell;
use crate::analyzer::hadolint::types::Severity;

pub fn rule() -> SimpleRule<impl Fn(&Instruction, Option<&ParsedShell>) -> bool + Send + Sync> {
    simple_rule(
        "DL3009",
        Severity::Info,
        "Delete the apt-get lists after installing something.",
        |instr, shell| {
            match instr {
                Instruction::Run(_) => {
                    if let Some(shell) = shell {
                        // Check if apt-get install is used
                        let has_apt_install = shell.any_command(|cmd| {
                            cmd.name == "apt-get" && cmd.has_any_arg(&["install"])
                        });

                        if !has_apt_install {
                            return true;
                        }

                        // Check if lists are cleaned
                        shell.any_command(|cmd| {
                            // rm -rf /var/lib/apt/lists/*
                            (cmd.name == "rm" && cmd.arguments.iter().any(|arg| {
                                arg.contains("/var/lib/apt/lists")
                            }))
                            // Or apt-get clean
                            || (cmd.name == "apt-get" && cmd.has_any_arg(&["clean", "autoclean"]))
                        })
                    } else {
                        true
                    }
                }
                _ => true,
            }
        },
    )
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::analyzer::hadolint::config::HadolintConfig;
    use crate::analyzer::hadolint::lint::{LintResult, lint};

    fn lint_dockerfile(content: &str) -> LintResult {
        lint(content, &HadolintConfig::default())
    }

    #[test]
    fn test_apt_get_without_cleanup() {
        let result =
            lint_dockerfile("FROM ubuntu:20.04\nRUN apt-get update && apt-get install -y nginx");
        assert!(result.failures.iter().any(|f| f.code.as_str() == "DL3009"));
    }

    #[test]
    fn test_apt_get_with_rm_cleanup() {
        let result = lint_dockerfile(
            "FROM ubuntu:20.04\nRUN apt-get update && apt-get install -y nginx && rm -rf /var/lib/apt/lists/*",
        );
        assert!(!result.failures.iter().any(|f| f.code.as_str() == "DL3009"));
    }

    #[test]
    fn test_apt_get_with_clean() {
        let result = lint_dockerfile(
            "FROM ubuntu:20.04\nRUN apt-get update && apt-get install -y nginx && apt-get clean",
        );
        assert!(!result.failures.iter().any(|f| f.code.as_str() == "DL3009"));
    }

    #[test]
    fn test_no_apt_get() {
        let result = lint_dockerfile("FROM ubuntu:20.04\nRUN echo hello");
        assert!(!result.failures.iter().any(|f| f.code.as_str() == "DL3009"));
    }
}