smoltcp-nal 0.7.0

embedded-nal implementation for smoltcp
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
//! A [embedded_nal]-compatible network stack for [smoltcp]
//!
//! # Usage
//! To use this library, first instantiate the [smoltcp::iface::Interface] and add sockets to
//! it. Once sockets have been added, pass the interface to [NetworkStack::new()].
//!
//! # Sharing the Stack
//! If you have multiple users of the network stack, you can use the [shared::NetworkManager] by
//! enabling the `shared-stack` feature. Note that this implementation does not employ any mutually
//! exclusive access mechanism. For information on how to use this manager, refer to
//! [shared_bus::AtomicCheckMutex]'s documentation.
//!
//! When sharing the stack, it is the users responsibility to ensure that access to the network
//! stack is mutually exclusive. For example, this can be done when using RTIC by storing all of
//! the resources that use the network stack in a single resource.
#![no_std]

use core::{
    convert::TryFrom,
    net::{IpAddr, SocketAddr},
};
pub use embedded_nal;
use nanorand::{Rng, SeedableRng};
pub use smoltcp;

use embedded_nal::{TcpClientStack, UdpClientStack, UdpFullStack};
use embedded_time::duration::Milliseconds;
use smoltcp::{
    iface::{PollResult, SocketHandle},
    socket::dhcpv4,
    wire::{IpAddress, IpCidr, IpEndpoint, Ipv4Address, Ipv4Cidr},
};

use heapless::Vec;
use nanorand::wyrand::WyRand;

#[cfg(feature = "shared-stack")]
pub mod shared;

// The start of TCP port dynamic range allocation.
const TCP_PORT_DYNAMIC_RANGE_START: u16 = 49152;

#[derive(Debug, Copy, Clone)]
pub enum SmoltcpError {
    RouteTableFull,
}

#[derive(Debug, Copy, Clone)]
pub enum NetworkError {
    NoSocket,
    DnsStart(smoltcp::socket::dns::StartQueryError),
    DnsFailure,
    UdpConnectionFailure(smoltcp::socket::udp::BindError),
    TcpConnectionFailure(smoltcp::socket::tcp::ConnectError),
    TcpReadFailure(smoltcp::socket::tcp::RecvError),
    TcpWriteFailure(smoltcp::socket::tcp::SendError),
    UdpReadFailure(smoltcp::socket::udp::RecvError),
    UdpWriteFailure(smoltcp::socket::udp::SendError),
    Unsupported,
    NotConnected,
    NoAddress,
}

impl embedded_nal::TcpError for NetworkError {
    fn kind(&self) -> embedded_nal::TcpErrorKind {
        match self {
            NetworkError::TcpReadFailure(_) => embedded_nal::TcpErrorKind::PipeClosed,
            NetworkError::TcpWriteFailure(_) => embedded_nal::TcpErrorKind::PipeClosed,
            _ => embedded_nal::TcpErrorKind::Other,
        }
    }
}

impl From<smoltcp::iface::RouteTableFull> for SmoltcpError {
    fn from(_: smoltcp::iface::RouteTableFull) -> SmoltcpError {
        SmoltcpError::RouteTableFull
    }
}

/// Combination error used for polling the network stack
#[derive(Debug)]
pub enum Error {
    Network(SmoltcpError),
    Time(embedded_time::TimeError),
}

impl From<embedded_time::TimeError> for Error {
    fn from(e: embedded_time::TimeError) -> Self {
        Error::Time(e)
    }
}

impl From<embedded_time::clock::Error> for Error {
    fn from(e: embedded_time::clock::Error) -> Self {
        Error::Time(e.into())
    }
}

impl From<embedded_time::ConversionError> for Error {
    fn from(e: embedded_time::ConversionError) -> Self {
        Error::Time(e.into())
    }
}

#[derive(Debug)]
pub struct UdpSocket {
    handle: SocketHandle,
    destination: Option<IpEndpoint>,
}

/// Network abstraction layer for smoltcp.
pub struct NetworkStack<'a, Device, Clock>
where
    Device: smoltcp::phy::Device,
    Clock: embedded_time::Clock,
    u32: From<Clock::T>,
{
    network_interface: smoltcp::iface::Interface,
    device: Device,
    sockets: smoltcp::iface::SocketSet<'a>,
    dhcp_handle: Option<SocketHandle>,
    dns_handle: Option<SocketHandle>,
    dns_lookups: heapless::LinearMap<heapless::String<255>, smoltcp::socket::dns::QueryHandle, 2>,
    unused_tcp_handles: Vec<SocketHandle, 16>,
    unused_udp_handles: Vec<SocketHandle, 16>,
    clock: Clock,
    last_poll: Option<embedded_time::Instant<Clock>>,
    stack_time: smoltcp::time::Instant,
    rand: WyRand,
}

impl<'a, Device, Clock> NetworkStack<'a, Device, Clock>
where
    Device: smoltcp::phy::Device,
    Clock: embedded_time::Clock,
    u32: From<Clock::T>,
{
    /// Construct a new network stack.
    ///
    /// # Note
    /// This implementation only supports up to 16 usable sockets.
    ///
    /// Any handles provided to this function must not be used after constructing the network
    /// stack.
    ///
    /// This implementation currently only supports IPv4.
    ///
    /// # Args
    /// * `stack` - The ethernet interface to construct the network stack from.
    /// * `clock` - A clock to use for determining network time.
    ///
    /// # Returns
    /// A [embedded_nal] compatible network stack.
    pub fn new(
        stack: smoltcp::iface::Interface,
        device: Device,
        sockets: smoltcp::iface::SocketSet<'a>,
        clock: Clock,
    ) -> Self {
        let mut unused_tcp_handles: Vec<SocketHandle, 16> = Vec::new();
        let mut unused_udp_handles: Vec<SocketHandle, 16> = Vec::new();
        let mut dhcp_handle: Option<SocketHandle> = None;
        let mut dns_handle: Option<SocketHandle> = None;

        for (handle, socket) in sockets.iter() {
            match socket {
                smoltcp::socket::Socket::Tcp(_) => {
                    unused_tcp_handles.push(handle).ok();
                }
                smoltcp::socket::Socket::Udp(_) => {
                    unused_udp_handles.push(handle).ok();
                }
                smoltcp::socket::Socket::Dhcpv4(_) => {
                    dhcp_handle.replace(handle);
                }
                smoltcp::socket::Socket::Dns(_) => {
                    dns_handle.replace(handle);
                }

                // This branch may be enabled through cargo feature unification (e.g. if an
                // application enables raw-sockets). To accomodate this, we provide a default match
                // arm.
                #[allow(unreachable_patterns)]
                _ => {}
            }
        }

        NetworkStack {
            network_interface: stack,
            sockets,
            device,
            dhcp_handle,
            dns_handle,
            unused_tcp_handles,
            unused_udp_handles,
            last_poll: None,
            dns_lookups: heapless::LinearMap::new(),
            clock,
            stack_time: smoltcp::time::Instant::from_secs(0),
            rand: WyRand::new_seed(0),
        }
    }

    /// Seed the TCP port randomizer.
    ///
    /// # Args
    /// * `seed` - A seed of random data to use for randomizing local TCP port selection.
    pub fn seed_random_port(&mut self, seed: &[u8]) {
        let mut s = [0; 8];
        let n = seed.len().min(s.len());
        s[..n].copy_from_slice(&seed[..n]);
        self.rand.reseed(s);
    }

    /// Poll the network stack for potential updates.
    ///
    /// # Returns
    /// A boolean indicating if the network stack updated in any way.
    pub fn poll(&mut self) -> Result<bool, Error> {
        let now = self.clock.try_now()?;

        // We can only start using the clock once we call `poll()`, as it may not be initialized
        // beforehand. In these cases, the last_poll may be uninitialized. If this is the case,
        // populate it now.
        if self.last_poll.is_none() {
            self.last_poll.replace(now);
        }

        // Note(unwrap): We guarantee that the last_poll value is set above.
        let elapsed_system_time = now - *self.last_poll.as_ref().unwrap();

        let elapsed_ms: Milliseconds<u32> = Milliseconds::try_from(elapsed_system_time)?;

        if elapsed_ms.0 > 0 {
            self.stack_time += smoltcp::time::Duration::from_millis(elapsed_ms.0.into());

            // In order to avoid quantization noise, instead of setting the previous poll instant
            // to the current time, we set it to the last poll instant plus the number of millis
            // that we incremented smoltcps time by. This ensures that if e.g. we had 1.5 millis
            // elapse, we don't accidentally discard the 500 microseconds by fast-forwarding
            // smoltcp by 1ms, but moving our internal timer by 1.5ms.
            //
            // Note(unwrap): We guarantee that last_poll is always some time above.
            self.last_poll.replace(self.last_poll.unwrap() + elapsed_ms);
        }

        let updated = matches!(
            self.network_interface
                .poll(self.stack_time, &mut self.device, &mut self.sockets),
            PollResult::SocketStateChanged
        );

        // Service the DHCP client.
        if let Some(handle) = self.dhcp_handle {
            let mut close_sockets = false;
            let mut dns_server = None;

            if let Some(event) = self.sockets.get_mut::<dhcpv4::Socket>(handle).poll() {
                match event {
                    dhcpv4::Event::Configured(config) => {
                        let is_unicast = {
                            let address = config.address.address();
                            !(address.is_broadcast()
                                || address.is_multicast()
                                || address.is_unspecified())
                        };
                        if is_unicast
                            && self.network_interface.ipv4_addr().unwrap()
                                != config.address.address()
                        {
                            close_sockets = true;
                            Self::set_ipv4_addr(&mut self.network_interface, config.address);
                        }

                        if let Some(server) = config
                            .dns_servers
                            .iter()
                            .next()
                            .map(|ipv4| smoltcp::wire::IpAddress::Ipv4(*ipv4))
                        {
                            dns_server.replace(server);
                        }

                        if let Some(route) = config.router {
                            // Note: If the user did not provide enough route storage, we may not be
                            // able to store the gateway.
                            self.network_interface
                                .routes_mut()
                                .add_default_ipv4_route(route)
                                .map_err(|e| Error::Network(e.into()))?;
                        } else {
                            self.network_interface
                                .routes_mut()
                                .remove_default_ipv4_route();
                        }
                    }
                    dhcpv4::Event::Deconfigured => {
                        self.network_interface
                            .routes_mut()
                            .remove_default_ipv4_route();
                        Self::set_ipv4_addr(
                            &mut self.network_interface,
                            Ipv4Cidr::new(Ipv4Address::UNSPECIFIED, 0),
                        );
                    }
                }
            }

            if close_sockets {
                self.close_sockets();
            }

            if let Some((server, handle)) = dns_server.zip(self.dns_handle) {
                let dns = self.sockets.get_mut::<smoltcp::socket::dns::Socket>(handle);

                // Clear out all pending DNS queries now that we have a new server.
                for (_query, handle) in self.dns_lookups.iter() {
                    dns.cancel_query(*handle);
                }
                self.dns_lookups.clear();

                dns.update_servers(&[server]);
            }
        }

        Ok(updated)
    }

    /// Force-close all sockets.
    pub fn close_sockets(&mut self) {
        // Close all sockets.
        for (_handle, socket) in self.sockets.iter_mut() {
            match socket {
                smoltcp::socket::Socket::Udp(sock) => {
                    sock.close();
                }
                smoltcp::socket::Socket::Tcp(sock) => {
                    sock.abort();
                }

                _ => {}
            }
        }
    }

    fn set_ipv4_addr(interface: &mut smoltcp::iface::Interface, address: Ipv4Cidr) {
        interface.update_ip_addrs(|addrs| {
            // Note(unwrap): This stack requires at least 1 Ipv4 Address.
            match addrs
                .iter_mut()
                .find(|cidr| matches!(cidr.address(), IpAddress::Ipv4(_)))
            {
                Some(addr) => *addr = IpCidr::Ipv4(address),
                None => addrs.push(IpCidr::Ipv4(address)).unwrap(),
            }
        });
    }

    /// Handle a disconnection of the physical interface.
    pub fn handle_link_reset(&mut self) {
        // Close all of the sockets and de-configure the interface.
        self.close_sockets();

        // Reset the DHCP client.
        if let Some(handle) = self.dhcp_handle {
            self.sockets.get_mut::<dhcpv4::Socket>(handle).reset();

            self.network_interface.update_ip_addrs(|addrs| {
                if let Some(addr) = addrs.iter_mut().next() {
                    *addr = IpCidr::Ipv4(Ipv4Cidr::new(Ipv4Address::UNSPECIFIED, 0));
                };
            });
        }
    }

    /// Access the underlying network interface.
    pub fn interface(&self) -> &smoltcp::iface::Interface {
        &self.network_interface
    }

    /// Mutably access the underlying network interface.
    ///
    /// # Note
    /// Modification of the underlying network interface may unintentionally interfere with
    /// operation of this library (e.g. through reset, modification of IP addresses, etc.). Mutable
    /// access to the interface should be done with care.
    pub fn interface_mut(&mut self) -> &mut smoltcp::iface::Interface {
        &mut self.network_interface
    }

    /// Check if a port is currently in use.
    ///
    /// # Returns
    /// True if the port is in use. False otherwise.
    fn is_port_in_use(&mut self, port: u16) -> bool {
        for (_handle, socket) in self.sockets.iter_mut() {
            match socket {
                smoltcp::socket::Socket::Tcp(sock) => {
                    if sock
                        .local_endpoint()
                        .map(|endpoint| endpoint.port == port)
                        .unwrap_or(false)
                    {
                        return true;
                    }
                }
                smoltcp::socket::Socket::Udp(sock) => {
                    let endpoint = sock.endpoint();
                    if endpoint.is_specified() && endpoint.port == port {
                        return true;
                    }
                }
                _ => {}
            }
        }

        false
    }

    // Get an ephemeral port number.
    fn get_ephemeral_port(&mut self) -> u16 {
        loop {
            // Get the next ephemeral port by generating a random, valid TCP port continuously
            // until an unused port is found.
            let random_offset = {
                let random_data = self.rand.rand();
                u16::from_be_bytes([random_data[0], random_data[1]])
            };

            let port = TCP_PORT_DYNAMIC_RANGE_START
                + random_offset % (u16::MAX - TCP_PORT_DYNAMIC_RANGE_START);
            if !self.is_port_in_use(port) {
                return port;
            }
        }
    }
}

impl<Device, Clock> TcpClientStack for NetworkStack<'_, Device, Clock>
where
    Device: smoltcp::phy::Device,
    Clock: embedded_time::Clock,
    u32: From<Clock::T>,
{
    type Error = NetworkError;
    type TcpSocket = SocketHandle;

    fn socket(&mut self) -> Result<SocketHandle, NetworkError> {
        match self.unused_tcp_handles.pop() {
            Some(handle) => {
                // Abort any active connections on the handle.
                let internal_socket: &mut smoltcp::socket::tcp::Socket =
                    self.sockets.get_mut(handle);
                internal_socket.abort();

                Ok(handle)
            }
            None => Err(NetworkError::NoSocket),
        }
    }

    fn connect(
        &mut self,
        socket: &mut SocketHandle,
        remote: SocketAddr,
    ) -> embedded_nal::nb::Result<(), NetworkError> {
        let dest_addr = match remote.ip() {
            IpAddr::V4(addr) => {
                let octets = addr.octets();
                smoltcp::wire::Ipv4Address::new(octets[0], octets[1], octets[2], octets[3])
            }

            // We only support IPv4.
            _ => return Err(embedded_nal::nb::Error::Other(NetworkError::Unsupported)),
        };

        let local_port = self.get_ephemeral_port();
        let internal_socket = self
            .sockets
            .get_mut::<smoltcp::socket::tcp::Socket>(*socket);

        if !internal_socket.is_open() {
            let context = self.network_interface.context();
            internal_socket
                .connect(context, (dest_addr, remote.port()), local_port)
                .map_err(|e| {
                    embedded_nal::nb::Error::Other(NetworkError::TcpConnectionFailure(e))
                })?;
        }

        if internal_socket.state() == smoltcp::socket::tcp::State::Established {
            Ok(())
        } else {
            Err(embedded_nal::nb::Error::WouldBlock)
        }
    }

    fn send(
        &mut self,
        socket: &mut SocketHandle,
        buffer: &[u8],
    ) -> embedded_nal::nb::Result<usize, NetworkError> {
        let socket: &mut smoltcp::socket::tcp::Socket = self.sockets.get_mut(*socket);
        socket
            .send_slice(buffer)
            .map_err(|e| embedded_nal::nb::Error::Other(NetworkError::TcpWriteFailure(e)))
    }

    fn receive(
        &mut self,
        socket: &mut SocketHandle,
        buffer: &mut [u8],
    ) -> embedded_nal::nb::Result<usize, NetworkError> {
        let socket: &mut smoltcp::socket::tcp::Socket = self.sockets.get_mut(*socket);
        socket
            .recv_slice(buffer)
            .map_err(|e| embedded_nal::nb::Error::Other(NetworkError::TcpReadFailure(e)))
    }

    fn close(&mut self, socket: SocketHandle) -> Result<(), NetworkError> {
        let internal_socket: &mut smoltcp::socket::tcp::Socket = self.sockets.get_mut(socket);

        internal_socket.close();
        self.unused_tcp_handles.push(socket).unwrap();
        Ok(())
    }
}

impl<Device, Clock> UdpClientStack for NetworkStack<'_, Device, Clock>
where
    Device: smoltcp::phy::Device,
    Clock: embedded_time::Clock,
    u32: From<Clock::T>,
{
    type Error = NetworkError;
    type UdpSocket = UdpSocket;

    fn socket(&mut self) -> Result<UdpSocket, NetworkError> {
        let handle = self
            .unused_udp_handles
            .pop()
            .ok_or(NetworkError::NoSocket)?;

        // Make sure the socket is in a closed state before handing it to the user.
        let internal_socket: &mut smoltcp::socket::udp::Socket = self.sockets.get_mut(handle);
        internal_socket.close();

        Ok(UdpSocket {
            handle,
            destination: None,
        })
    }

    fn connect(&mut self, socket: &mut UdpSocket, remote: SocketAddr) -> Result<(), NetworkError> {
        // Store the route for this socket.
        match remote {
            SocketAddr::V4(addr) => {
                let octets = addr.ip().octets();
                socket.destination.replace(IpEndpoint::new(
                    IpAddress::v4(octets[0], octets[1], octets[2], octets[3]),
                    addr.port(),
                ));
            }

            // We only support IPv4.
            _ => return Err(NetworkError::Unsupported),
        }

        // Select a random port to bind to locally.
        let local_port = self.get_ephemeral_port();

        let Some(cidr) = self
            .network_interface
            .ip_addrs()
            .iter()
            .find(|item| matches!(item, smoltcp::wire::IpCidr::Ipv4(_)))
        else {
            return Err(NetworkError::NoAddress);
        };

        let local_endpoint = IpEndpoint::new(cidr.address(), local_port);

        let internal_socket: &mut smoltcp::socket::udp::Socket =
            self.sockets.get_mut(socket.handle);
        internal_socket
            .bind(local_endpoint)
            .map_err(NetworkError::UdpConnectionFailure)?;

        Ok(())
    }

    fn send(
        &mut self,
        socket: &mut UdpSocket,
        buffer: &[u8],
    ) -> embedded_nal::nb::Result<(), NetworkError> {
        let internal_socket: &mut smoltcp::socket::udp::Socket =
            self.sockets.get_mut(socket.handle);
        let destination = socket.destination.ok_or(NetworkError::NotConnected)?;
        internal_socket
            .send_slice(buffer, destination)
            .map_err(|e| embedded_nal::nb::Error::Other(NetworkError::UdpWriteFailure(e)))
    }

    fn receive(
        &mut self,
        socket: &mut UdpSocket,
        buffer: &mut [u8],
    ) -> embedded_nal::nb::Result<(usize, SocketAddr), NetworkError> {
        let internal_socket: &mut smoltcp::socket::udp::Socket =
            self.sockets.get_mut(socket.handle);
        let (size, source) = internal_socket
            .recv_slice(buffer)
            .map_err(|e| embedded_nal::nb::Error::Other(NetworkError::UdpReadFailure(e)))?;

        let source = {
            let addr = match source.endpoint.addr {
                IpAddress::Ipv4(addr) => IpAddr::V4(addr),
                IpAddress::Ipv6(addr) => IpAddr::V6(addr),
            };

            SocketAddr::new(addr, source.endpoint.port)
        };

        Ok((size, source))
    }

    fn close(&mut self, socket: UdpSocket) -> Result<(), NetworkError> {
        let internal_socket: &mut smoltcp::socket::udp::Socket =
            self.sockets.get_mut(socket.handle);

        internal_socket.close();

        // There should always be room to return the socket handle to the unused handle list.
        self.unused_udp_handles.push(socket.handle).unwrap();

        Ok(())
    }
}

impl<Device, Clock> UdpFullStack for NetworkStack<'_, Device, Clock>
where
    Device: smoltcp::phy::Device,
    Clock: embedded_time::Clock,
    u32: From<Clock::T>,
{
    /// Bind a UDP socket to a specific port.
    fn bind(&mut self, socket: &mut UdpSocket, local_port: u16) -> Result<(), NetworkError> {
        let Some(cidr) = self
            .network_interface
            .ip_addrs()
            .iter()
            .find(|item| matches!(item, smoltcp::wire::IpCidr::Ipv4(_)))
        else {
            return Err(NetworkError::NoAddress);
        };

        let local_endpoint = IpEndpoint::new(cidr.address(), local_port);

        let internal_socket: &mut smoltcp::socket::udp::Socket =
            self.sockets.get_mut(socket.handle);
        internal_socket
            .bind(local_endpoint)
            .map_err(NetworkError::UdpConnectionFailure)?;

        Ok(())
    }

    /// Send a packet to a remote host/port.
    fn send_to(
        &mut self,
        socket: &mut Self::UdpSocket,
        remote: SocketAddr,
        buffer: &[u8],
    ) -> embedded_nal::nb::Result<(), NetworkError> {
        let destination = match remote {
            SocketAddr::V4(addr) => {
                let octets = addr.ip().octets();
                IpEndpoint::new(
                    IpAddress::v4(octets[0], octets[1], octets[2], octets[3]),
                    addr.port(),
                )
            }
            // We only support IPv4.
            _ => return Err(embedded_nal::nb::Error::Other(NetworkError::Unsupported)),
        };

        let internal_socket: &mut smoltcp::socket::udp::Socket =
            self.sockets.get_mut(socket.handle);
        internal_socket
            .send_slice(buffer, destination)
            .map_err(|e| embedded_nal::nb::Error::Other(NetworkError::UdpWriteFailure(e)))
    }
}

impl<Device, Clock> embedded_nal::Dns for NetworkStack<'_, Device, Clock>
where
    Device: smoltcp::phy::Device,
    Clock: embedded_time::Clock,
    u32: From<Clock::T>,
{
    type Error = NetworkError;
    fn get_host_by_name(
        &mut self,
        hostname: &str,
        _addr_type: embedded_nal::AddrType,
    ) -> embedded_nal::nb::Result<IpAddr, Self::Error> {
        let handle = self.dns_handle.ok_or(NetworkError::Unsupported)?;
        let dns_socket: &mut smoltcp::socket::dns::Socket = self.sockets.get_mut(handle);
        let context = self.network_interface.context();
        let key = heapless::String::try_from(hostname).map_err(|_| NetworkError::Unsupported)?;

        if let Some(handle) = self.dns_lookups.get(&key) {
            match dns_socket.get_query_result(*handle) {
                Ok(addrs) => {
                    self.dns_lookups.remove(&key);
                    let addr = addrs.iter().next().ok_or(NetworkError::DnsFailure)?;
                    let smoltcp::wire::IpAddress::Ipv4(addr) = addr else {
                        panic!("Unexpected address return type");
                    };
                    return Ok(IpAddr::V4(*addr));
                }
                Err(smoltcp::socket::dns::GetQueryResultError::Pending) => {}
                Err(smoltcp::socket::dns::GetQueryResultError::Failed) => {
                    self.dns_lookups.remove(&key);
                    return Err(embedded_nal::nb::Error::Other(NetworkError::DnsFailure));
                }
            }
        } else {
            // Note: We only support A types because we are an Ipv4-only stack
            let dns_query = dns_socket
                .start_query(context, hostname, smoltcp::wire::DnsQueryType::A)
                .map_err(NetworkError::DnsStart)?;
            if self.dns_lookups.insert(key, dns_query).is_err() {
                dns_socket.cancel_query(dns_query);
                return Err(embedded_nal::nb::Error::Other(NetworkError::Unsupported));
            }
        }

        Err(embedded_nal::nb::Error::WouldBlock)
    }

    fn get_host_by_address(
        &mut self,
        _addr: IpAddr,
        _: &mut [u8],
    ) -> Result<usize, embedded_nal::nb::Error<Self::Error>> {
        unimplemented!()
    }
}