sklears-simd 0.1.1

High-performance SIMD acceleration primitives for the Sklears machine learning ecosystem
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
//! SIMD-optimized regression operations
//!
//! This module provides vectorized implementations of common regression operations
//! including least squares, ridge regression, and elastic net computations.

#[cfg(feature = "no-std")]
use alloc::{vec, vec::Vec};

/// SIMD-optimized ordinary least squares computation
/// Computes X^T * X and X^T * y for the normal equation
pub fn least_squares_normal_equation(
    x: &[&[f32]], // Design matrix (n_samples x n_features)
    y: &[f32],    // Target values (n_samples)
) -> (Vec<Vec<f32>>, Vec<f32>) {
    let n_samples = x.len();
    let n_features = if n_samples > 0 { x[0].len() } else { 0 };

    assert!(!x.is_empty(), "Design matrix cannot be empty");
    assert_eq!(
        y.len(),
        n_samples,
        "Target length must match number of samples"
    );

    // Initialize X^T * X matrix
    let mut xtx = vec![vec![0.0f32; n_features]; n_features];
    // Initialize X^T * y vector
    let mut xty = vec![0.0f32; n_features];

    #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
    {
        if crate::simd_feature_detected!("avx2") {
            unsafe { least_squares_avx2(x, y, &mut xtx, &mut xty) };
            return (xtx, xty);
        } else if crate::simd_feature_detected!("sse2") {
            unsafe { least_squares_sse2(x, y, &mut xtx, &mut xty) };
            return (xtx, xty);
        }
    }

    least_squares_scalar(x, y, &mut xtx, &mut xty);
    (xtx, xty)
}

fn least_squares_scalar(x: &[&[f32]], y: &[f32], xtx: &mut [Vec<f32>], xty: &mut [f32]) {
    let n_samples = x.len();
    let n_features = x[0].len();

    // Compute X^T * X
    for i in 0..n_features {
        for j in 0..n_features {
            let sum: f32 = x.iter().map(|row| row[i] * row[j]).sum();
            xtx[i][j] = sum;
        }
    }

    // Compute X^T * y
    for i in 0..n_features {
        let mut sum = 0.0;
        for k in 0..n_samples {
            sum += x[k][i] * y[k];
        }
        xty[i] = sum;
    }
}

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
#[target_feature(enable = "sse2")]
unsafe fn least_squares_sse2(x: &[&[f32]], y: &[f32], xtx: &mut [Vec<f32>], xty: &mut [f32]) {
    use core::arch::x86_64::*;

    let n_samples = x.len();
    let n_features = x[0].len();

    // Compute X^T * X with SIMD
    for i in 0..n_features {
        for j in 0..n_features {
            let mut sum = _mm_setzero_ps();
            let mut k = 0;

            while k + 4 <= n_samples {
                let xi_vec = _mm_setr_ps(x[k][i], x[k + 1][i], x[k + 2][i], x[k + 3][i]);
                let xj_vec = _mm_setr_ps(x[k][j], x[k + 1][j], x[k + 2][j], x[k + 3][j]);
                let prod = _mm_mul_ps(xi_vec, xj_vec);
                sum = _mm_add_ps(sum, prod);
                k += 4;
            }

            let mut result = [0.0f32; 4];
            _mm_storeu_ps(result.as_mut_ptr(), sum);
            let mut scalar_sum = result[0] + result[1] + result[2] + result[3];

            while k < n_samples {
                scalar_sum += x[k][i] * x[k][j];
                k += 1;
            }

            xtx[i][j] = scalar_sum;
        }
    }

    // Compute X^T * y with SIMD
    for i in 0..n_features {
        let mut sum = _mm_setzero_ps();
        let mut k = 0;

        while k + 4 <= n_samples {
            let xi_vec = _mm_setr_ps(x[k][i], x[k + 1][i], x[k + 2][i], x[k + 3][i]);
            let y_vec = _mm_loadu_ps(&y[k]);
            let prod = _mm_mul_ps(xi_vec, y_vec);
            sum = _mm_add_ps(sum, prod);
            k += 4;
        }

        let mut result = [0.0f32; 4];
        _mm_storeu_ps(result.as_mut_ptr(), sum);
        let mut scalar_sum = result[0] + result[1] + result[2] + result[3];

        while k < n_samples {
            scalar_sum += x[k][i] * y[k];
            k += 1;
        }

        xty[i] = scalar_sum;
    }
}

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
#[target_feature(enable = "avx2")]
unsafe fn least_squares_avx2(x: &[&[f32]], y: &[f32], xtx: &mut [Vec<f32>], xty: &mut [f32]) {
    use core::arch::x86_64::*;

    let n_samples = x.len();
    let n_features = x[0].len();

    // Compute X^T * X with SIMD
    for i in 0..n_features {
        for j in 0..n_features {
            let mut sum = _mm256_setzero_ps();
            let mut k = 0;

            while k + 8 <= n_samples {
                let xi_vec = _mm256_setr_ps(
                    x[k][i],
                    x[k + 1][i],
                    x[k + 2][i],
                    x[k + 3][i],
                    x[k + 4][i],
                    x[k + 5][i],
                    x[k + 6][i],
                    x[k + 7][i],
                );
                let xj_vec = _mm256_setr_ps(
                    x[k][j],
                    x[k + 1][j],
                    x[k + 2][j],
                    x[k + 3][j],
                    x[k + 4][j],
                    x[k + 5][j],
                    x[k + 6][j],
                    x[k + 7][j],
                );
                let prod = _mm256_mul_ps(xi_vec, xj_vec);
                sum = _mm256_add_ps(sum, prod);
                k += 8;
            }

            let mut result = [0.0f32; 8];
            _mm256_storeu_ps(result.as_mut_ptr(), sum);
            let mut scalar_sum = result.iter().sum::<f32>();

            while k < n_samples {
                scalar_sum += x[k][i] * x[k][j];
                k += 1;
            }

            xtx[i][j] = scalar_sum;
        }
    }

    // Compute X^T * y with SIMD
    for i in 0..n_features {
        let mut sum = _mm256_setzero_ps();
        let mut k = 0;

        while k + 8 <= n_samples {
            let xi_vec = _mm256_setr_ps(
                x[k][i],
                x[k + 1][i],
                x[k + 2][i],
                x[k + 3][i],
                x[k + 4][i],
                x[k + 5][i],
                x[k + 6][i],
                x[k + 7][i],
            );
            let y_vec = _mm256_loadu_ps(&y[k]);
            let prod = _mm256_mul_ps(xi_vec, y_vec);
            sum = _mm256_add_ps(sum, prod);
            k += 8;
        }

        let mut result = [0.0f32; 8];
        _mm256_storeu_ps(result.as_mut_ptr(), sum);
        let mut scalar_sum = result.iter().sum::<f32>();

        while k < n_samples {
            scalar_sum += x[k][i] * y[k];
            k += 1;
        }

        xty[i] = scalar_sum;
    }
}

/// SIMD-optimized ridge regression normal equation computation
/// Computes (X^T * X + alpha * I) and X^T * y
pub fn ridge_regression_normal_equation(
    x: &[&[f32]], // Design matrix (n_samples x n_features)
    y: &[f32],    // Target values (n_samples)
    alpha: f32,   // Regularization parameter
) -> (Vec<Vec<f32>>, Vec<f32>) {
    let (mut xtx, xty) = least_squares_normal_equation(x, y);

    // Add ridge regularization: X^T * X + alpha * I
    for (i, row) in xtx.iter_mut().enumerate() {
        row[i] += alpha;
    }

    (xtx, xty)
}

/// SIMD-optimized elastic net penalty computation
/// Computes the elastic net penalty: alpha * l1_ratio * ||w||_1 + 0.5 * alpha * (1 - l1_ratio) * ||w||_2^2
pub fn elastic_net_penalty(weights: &[f32], alpha: f32, l1_ratio: f32) -> f32 {
    assert!(
        (0.0..=1.0).contains(&l1_ratio),
        "l1_ratio must be between 0 and 1"
    );
    assert!(alpha >= 0.0, "alpha must be non-negative");

    if weights.is_empty() {
        return 0.0;
    }

    #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
    {
        if crate::simd_feature_detected!("avx2") {
            return unsafe { elastic_net_penalty_avx2(weights, alpha, l1_ratio) };
        } else if crate::simd_feature_detected!("sse2") {
            return unsafe { elastic_net_penalty_sse2(weights, alpha, l1_ratio) };
        }
    }

    elastic_net_penalty_scalar(weights, alpha, l1_ratio)
}

fn elastic_net_penalty_scalar(weights: &[f32], alpha: f32, l1_ratio: f32) -> f32 {
    let l1_norm: f32 = weights.iter().map(|w| w.abs()).sum();
    let l2_norm_squared: f32 = weights.iter().map(|w| w * w).sum();

    alpha * l1_ratio * l1_norm + 0.5 * alpha * (1.0 - l1_ratio) * l2_norm_squared
}

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
#[target_feature(enable = "sse2")]
unsafe fn elastic_net_penalty_sse2(weights: &[f32], alpha: f32, l1_ratio: f32) -> f32 {
    use core::arch::x86_64::*;

    let mut l1_sum = _mm_setzero_ps();
    let mut l2_sum = _mm_setzero_ps();
    let sign_mask = _mm_set1_ps(-0.0f32);
    let mut i = 0;

    while i + 4 <= weights.len() {
        let w_vec = _mm_loadu_ps(weights.as_ptr().add(i));

        // L1 norm: sum of absolute values
        let abs_w = _mm_andnot_ps(sign_mask, w_vec);
        l1_sum = _mm_add_ps(l1_sum, abs_w);

        // L2 norm squared: sum of squares
        let squared_w = _mm_mul_ps(w_vec, w_vec);
        l2_sum = _mm_add_ps(l2_sum, squared_w);

        i += 4;
    }

    let mut l1_result = [0.0f32; 4];
    let mut l2_result = [0.0f32; 4];
    _mm_storeu_ps(l1_result.as_mut_ptr(), l1_sum);
    _mm_storeu_ps(l2_result.as_mut_ptr(), l2_sum);

    let mut l1_scalar = l1_result[0] + l1_result[1] + l1_result[2] + l1_result[3];
    let mut l2_scalar = l2_result[0] + l2_result[1] + l2_result[2] + l2_result[3];

    while i < weights.len() {
        l1_scalar += weights[i].abs();
        l2_scalar += weights[i] * weights[i];
        i += 1;
    }

    alpha * l1_ratio * l1_scalar + 0.5 * alpha * (1.0 - l1_ratio) * l2_scalar
}

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
#[target_feature(enable = "avx2")]
unsafe fn elastic_net_penalty_avx2(weights: &[f32], alpha: f32, l1_ratio: f32) -> f32 {
    use core::arch::x86_64::*;

    let mut l1_sum = _mm256_setzero_ps();
    let mut l2_sum = _mm256_setzero_ps();
    let sign_mask = _mm256_set1_ps(-0.0f32);
    let mut i = 0;

    while i + 8 <= weights.len() {
        let w_vec = _mm256_loadu_ps(weights.as_ptr().add(i));

        // L1 norm: sum of absolute values
        let abs_w = _mm256_andnot_ps(sign_mask, w_vec);
        l1_sum = _mm256_add_ps(l1_sum, abs_w);

        // L2 norm squared: sum of squares
        let squared_w = _mm256_mul_ps(w_vec, w_vec);
        l2_sum = _mm256_add_ps(l2_sum, squared_w);

        i += 8;
    }

    let mut l1_result = [0.0f32; 8];
    let mut l2_result = [0.0f32; 8];
    _mm256_storeu_ps(l1_result.as_mut_ptr(), l1_sum);
    _mm256_storeu_ps(l2_result.as_mut_ptr(), l2_sum);

    let mut l1_scalar = l1_result.iter().sum::<f32>();
    let mut l2_scalar = l2_result.iter().sum::<f32>();

    while i < weights.len() {
        l1_scalar += weights[i].abs();
        l2_scalar += weights[i] * weights[i];
        i += 1;
    }

    alpha * l1_ratio * l1_scalar + 0.5 * alpha * (1.0 - l1_ratio) * l2_scalar
}

/// SIMD-optimized soft thresholding for LASSO
/// Applies soft thresholding: sign(x) * max(|x| - threshold, 0)
pub fn soft_threshold(values: &[f32], threshold: f32, output: &mut [f32]) {
    assert_eq!(
        values.len(),
        output.len(),
        "Arrays must have the same length"
    );
    assert!(threshold >= 0.0, "Threshold must be non-negative");

    if values.is_empty() {
        return;
    }

    #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
    {
        if crate::simd_feature_detected!("avx2") {
            unsafe { soft_threshold_avx2(values, threshold, output) };
            return;
        } else if crate::simd_feature_detected!("sse2") {
            unsafe { soft_threshold_sse2(values, threshold, output) };
            return;
        }
    }

    soft_threshold_scalar(values, threshold, output);
}

fn soft_threshold_scalar(values: &[f32], threshold: f32, output: &mut [f32]) {
    for i in 0..values.len() {
        let abs_val = values[i].abs();
        if abs_val <= threshold {
            output[i] = 0.0;
        } else {
            output[i] = values[i].signum() * (abs_val - threshold);
        }
    }
}

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
#[target_feature(enable = "sse2")]
unsafe fn soft_threshold_sse2(values: &[f32], threshold: f32, output: &mut [f32]) {
    use core::arch::x86_64::*;

    let threshold_vec = _mm_set1_ps(threshold);
    let zero = _mm_setzero_ps();
    let one = _mm_set1_ps(1.0);
    let neg_one = _mm_set1_ps(-1.0);
    let sign_mask = _mm_set1_ps(-0.0f32);
    let mut i = 0;

    while i + 4 <= values.len() {
        let val_vec = _mm_loadu_ps(values.as_ptr().add(i));
        let abs_val = _mm_andnot_ps(sign_mask, val_vec);

        // Check if |x| > threshold
        let mask = _mm_cmpgt_ps(abs_val, threshold_vec);

        // Compute sign
        let pos_mask = _mm_cmpgt_ps(val_vec, zero);
        let neg_mask = _mm_cmplt_ps(val_vec, zero);
        let sign = _mm_add_ps(_mm_and_ps(pos_mask, one), _mm_and_ps(neg_mask, neg_one));

        // Compute soft thresholding: sign * max(|x| - threshold, 0)
        let thresholded = _mm_sub_ps(abs_val, threshold_vec);
        let result = _mm_mul_ps(sign, thresholded);

        // Apply mask: 0 if |x| <= threshold, result otherwise
        let final_result = _mm_and_ps(mask, result);

        _mm_storeu_ps(output.as_mut_ptr().add(i), final_result);
        i += 4;
    }

    while i < values.len() {
        let abs_val = values[i].abs();
        output[i] = if abs_val <= threshold {
            0.0
        } else {
            values[i].signum() * (abs_val - threshold)
        };
        i += 1;
    }
}

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
#[target_feature(enable = "avx2")]
unsafe fn soft_threshold_avx2(values: &[f32], threshold: f32, output: &mut [f32]) {
    use core::arch::x86_64::*;

    let threshold_vec = _mm256_set1_ps(threshold);
    let zero = _mm256_setzero_ps();
    let one = _mm256_set1_ps(1.0);
    let neg_one = _mm256_set1_ps(-1.0);
    let sign_mask = _mm256_set1_ps(-0.0f32);
    let mut i = 0;

    while i + 8 <= values.len() {
        let val_vec = _mm256_loadu_ps(values.as_ptr().add(i));
        let abs_val = _mm256_andnot_ps(sign_mask, val_vec);

        // Check if |x| > threshold
        let mask = _mm256_cmp_ps(abs_val, threshold_vec, _CMP_GT_OQ);

        // Compute sign
        let pos_mask = _mm256_cmp_ps(val_vec, zero, _CMP_GT_OQ);
        let neg_mask = _mm256_cmp_ps(val_vec, zero, _CMP_LT_OQ);
        let sign = _mm256_add_ps(
            _mm256_and_ps(pos_mask, one),
            _mm256_and_ps(neg_mask, neg_one),
        );

        // Compute soft thresholding: sign * max(|x| - threshold, 0)
        let thresholded = _mm256_sub_ps(abs_val, threshold_vec);
        let result = _mm256_mul_ps(sign, thresholded);

        // Apply mask: 0 if |x| <= threshold, result otherwise
        let final_result = _mm256_and_ps(mask, result);

        _mm256_storeu_ps(output.as_mut_ptr().add(i), final_result);
        i += 8;
    }

    while i < values.len() {
        let abs_val = values[i].abs();
        output[i] = if abs_val <= threshold {
            0.0
        } else {
            values[i].signum() * (abs_val - threshold)
        };
        i += 1;
    }
}

/// SIMD-optimized prediction for linear models
/// Computes y = X * beta
pub fn linear_predict(x: &[&[f32]], weights: &[f32], output: &mut [f32]) {
    let n_samples = x.len();
    let n_features = if n_samples > 0 { x[0].len() } else { 0 };

    assert_eq!(
        weights.len(),
        n_features,
        "Weight length must match number of features"
    );
    assert_eq!(
        output.len(),
        n_samples,
        "Output length must match number of samples"
    );

    if n_samples == 0 {
        return;
    }

    #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
    {
        if crate::simd_feature_detected!("avx2") {
            unsafe { linear_predict_avx2(x, weights, output) };
            return;
        } else if crate::simd_feature_detected!("sse2") {
            unsafe { linear_predict_sse2(x, weights, output) };
            return;
        }
    }

    linear_predict_scalar(x, weights, output);
}

fn linear_predict_scalar(x: &[&[f32]], weights: &[f32], output: &mut [f32]) {
    let n_samples = x.len();
    let n_features = weights.len();

    for i in 0..n_samples {
        let mut sum = 0.0;
        for j in 0..n_features {
            sum += x[i][j] * weights[j];
        }
        output[i] = sum;
    }
}

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
#[target_feature(enable = "sse2")]
unsafe fn linear_predict_sse2(x: &[&[f32]], weights: &[f32], output: &mut [f32]) {
    use core::arch::x86_64::*;

    let n_samples = x.len();
    let n_features = weights.len();

    for i in 0..n_samples {
        let mut sum = _mm_setzero_ps();
        let mut j = 0;

        while j + 4 <= n_features {
            let x_vec = _mm_loadu_ps(&x[i][j]);
            let w_vec = _mm_loadu_ps(&weights[j]);
            let prod = _mm_mul_ps(x_vec, w_vec);
            sum = _mm_add_ps(sum, prod);
            j += 4;
        }

        let mut result = [0.0f32; 4];
        _mm_storeu_ps(result.as_mut_ptr(), sum);
        let mut scalar_sum = result[0] + result[1] + result[2] + result[3];

        while j < n_features {
            scalar_sum += x[i][j] * weights[j];
            j += 1;
        }

        output[i] = scalar_sum;
    }
}

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
#[target_feature(enable = "avx2")]
unsafe fn linear_predict_avx2(x: &[&[f32]], weights: &[f32], output: &mut [f32]) {
    use core::arch::x86_64::*;

    let n_samples = x.len();
    let n_features = weights.len();

    for i in 0..n_samples {
        let mut sum = _mm256_setzero_ps();
        let mut j = 0;

        while j + 8 <= n_features {
            let x_vec = _mm256_loadu_ps(&x[i][j]);
            let w_vec = _mm256_loadu_ps(&weights[j]);
            let prod = _mm256_mul_ps(x_vec, w_vec);
            sum = _mm256_add_ps(sum, prod);
            j += 8;
        }

        let mut result = [0.0f32; 8];
        _mm256_storeu_ps(result.as_mut_ptr(), sum);
        let mut scalar_sum = result.iter().sum::<f32>();

        while j < n_features {
            scalar_sum += x[i][j] * weights[j];
            j += 1;
        }

        output[i] = scalar_sum;
    }
}

#[allow(non_snake_case)]
#[cfg(all(test, not(feature = "no-std")))]
mod tests {
    use super::*;
    use approx::assert_relative_eq;

    #[test]
    fn test_least_squares_normal_equation() {
        // Simple 2x2 design matrix
        let x1 = [1.0, 2.0];
        let x2 = [3.0, 4.0];
        let x = vec![&x1[..], &x2[..]];
        let y = [5.0, 6.0];

        let (xtx, xty) = least_squares_normal_equation(&x, &y);

        // Expected X^T * X = [[1*1 + 3*3, 1*2 + 3*4], [2*1 + 4*3, 2*2 + 4*4]] = [[10, 14], [14, 20]]
        assert_relative_eq!(xtx[0][0], 10.0, epsilon = 1e-6);
        assert_relative_eq!(xtx[0][1], 14.0, epsilon = 1e-6);
        assert_relative_eq!(xtx[1][0], 14.0, epsilon = 1e-6);
        assert_relative_eq!(xtx[1][1], 20.0, epsilon = 1e-6);

        // Expected X^T * y = [1*5 + 3*6, 2*5 + 4*6] = [23, 34]
        assert_relative_eq!(xty[0], 23.0, epsilon = 1e-6);
        assert_relative_eq!(xty[1], 34.0, epsilon = 1e-6);
    }

    #[test]
    fn test_ridge_regression_normal_equation() {
        let x1 = [1.0, 2.0];
        let x2 = [3.0, 4.0];
        let x = vec![&x1[..], &x2[..]];
        let y = [5.0, 6.0];
        let alpha = 1.0;

        let (xtx, _) = ridge_regression_normal_equation(&x, &y, alpha);

        // Expected: X^T * X + alpha * I = [[10+1, 14], [14, 20+1]] = [[11, 14], [14, 21]]
        assert_relative_eq!(xtx[0][0], 11.0, epsilon = 1e-6);
        assert_relative_eq!(xtx[0][1], 14.0, epsilon = 1e-6);
        assert_relative_eq!(xtx[1][0], 14.0, epsilon = 1e-6);
        assert_relative_eq!(xtx[1][1], 21.0, epsilon = 1e-6);
    }

    #[test]
    fn test_elastic_net_penalty() {
        let weights = vec![1.0, -2.0, 3.0, -4.0];
        let alpha = 0.1;
        let l1_ratio = 0.5;

        let penalty = elastic_net_penalty(&weights, alpha, l1_ratio);

        // Expected: L1 norm = |1| + |-2| + |3| + |-4| = 10
        // L2 norm squared = 1^2 + 2^2 + 3^2 + 4^2 = 30
        // Penalty = 0.1 * 0.5 * 10 + 0.5 * 0.1 * 0.5 * 30 = 0.5 + 0.75 = 1.25
        assert_relative_eq!(penalty, 1.25, epsilon = 1e-6);
    }

    #[test]
    fn test_soft_threshold() {
        let values = vec![3.0, -2.0, 1.0, -0.5, 0.0];
        let threshold = 1.5;
        let mut output = vec![0.0; 5];

        soft_threshold(&values, threshold, &mut output);

        // Expected:
        // 3.0: |3.0| > 1.5, so 1.0 * (3.0 - 1.5) = 1.5
        // -2.0: |-2.0| > 1.5, so -1.0 * (2.0 - 1.5) = -0.5
        // 1.0: |1.0| <= 1.5, so 0.0
        // -0.5: |-0.5| <= 1.5, so 0.0
        // 0.0: |0.0| <= 1.5, so 0.0
        assert_relative_eq!(output[0], 1.5, epsilon = 1e-6);
        assert_relative_eq!(output[1], -0.5, epsilon = 1e-6);
        assert_relative_eq!(output[2], 0.0, epsilon = 1e-6);
        assert_relative_eq!(output[3], 0.0, epsilon = 1e-6);
        assert_relative_eq!(output[4], 0.0, epsilon = 1e-6);
    }

    #[test]
    fn test_linear_predict() {
        let x1 = [1.0, 2.0];
        let x2 = [3.0, 4.0];
        let x = vec![&x1[..], &x2[..]];
        let weights = vec![0.5, 1.0];
        let mut output = vec![0.0; 2];

        linear_predict(&x, &weights, &mut output);

        // Expected:
        // Sample 1: 1.0 * 0.5 + 2.0 * 1.0 = 2.5
        // Sample 2: 3.0 * 0.5 + 4.0 * 1.0 = 5.5
        assert_relative_eq!(output[0], 2.5, epsilon = 1e-6);
        assert_relative_eq!(output[1], 5.5, epsilon = 1e-6);
    }
}