rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138

//! Layout/SpaceAroundMethodCallOperator.

use tree_sitter::Node;

use crate::cop::shared;
use crate::cop::{Cop, CopConfig};
use crate::correction::Correction;
use crate::diagnostic::Diagnostic;
use crate::parse::source::SourceFile;

pub struct SpaceAroundMethodCallOperator;

fn op_span(bytes: &[u8], recv: Node<'_>, method: Node<'_>) -> Option<(usize, usize)> {
    let search = &bytes[recv.end_byte()..method.start_byte()];
    let dot_rel = search.iter().position(|&b| b == b'.')?;
    let dot = recv.end_byte() + dot_rel;
    let op_start = if dot > 0 && bytes[dot - 1] == b'&' {
        dot - 1
    } else {
        dot
    };
    Some((op_start, dot + 1))
}

fn strip_spaces(
    corr: &mut Vec<Correction>,
    cop_name: &'static str,
    recv_end: usize,
    op_start: usize,
    op_end: usize,
    method_start: usize,
    before: bool,
    after: bool,
) {
    if before {
        corr.push(Correction {
            start: recv_end,
            end: op_start,
            replacement: String::new(),
            cop_name,
            cop_index: 0,
        });
    }
    if after {
        corr.push(Correction {
            start: op_end,
            end: method_start,
            replacement: String::new(),
            cop_name,
            cop_index: 0,
        });
    }
}

fn report_spaces(
    cop: &dyn Cop,
    source: &SourceFile,
    recv: Node<'_>,
    method: Node<'_>,
    op_start: usize,
    op_end: usize,
    before: bool,
    after: bool,
    diagnostics: &mut Vec<Diagnostic>,
    corrections: &mut Option<&mut Vec<Correction>>,
) {
    let (line, col) = source.offset_to_line_col(op_start);
    let mut diag = cop.diagnostic(
        source,
        line,
        col,
        "Avoid using spaces around a method call operator.".into(),
    );
    if let Some(corr) = corrections {
        strip_spaces(
            corr,
            cop.name(),
            recv.end_byte(),
            op_start,
            op_end,
            method.start_byte(),
            before,
            after,
        );
        diag.corrected = true;
    }
    diagnostics.push(diag);
}

impl Cop for SpaceAroundMethodCallOperator {
    fn name(&self) -> &'static str {
        "Layout/SpaceAroundMethodCallOperator"
    }
    fn supports_autocorrect(&self) -> bool {
        true
    }
    fn interested_node_kinds(&self) -> &'static [&'static str] {
        &["call"]
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        mut corrections: Option<&mut Vec<Correction>>,
    ) {
        let _ = config;
        let bytes = source.as_bytes();
        let Some(recv) = node.child_by_field_name("receiver") else {
            return;
        };
        let Some(method) = node.child_by_field_name("method") else {
            return;
        };
        let Some((op_start, op_end)) = op_span(bytes, recv, method) else {
            return;
        };
        let before = shared::only_hspace(bytes, recv.end_byte(), op_start);
        let after = shared::only_hspace(bytes, op_end, method.start_byte());
        if !(before || after) {
            return;
        }
        report_spaces(
            self,
            source,
            recv,
            method,
            op_start,
            op_end,
            before,
            after,
            diagnostics,
            &mut corrections,
        );
    }
}