rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94

//! Layout/SpaceAfterComma — require whitespace after `,` in code (not strings/comments).

use tree_sitter::Tree;

use crate::cop::{Cop, CopConfig};
use crate::correction::Correction;
use crate::diagnostic::Diagnostic;
use crate::parse::codemap::CodeMap;
use crate::parse::source::SourceFile;

pub struct SpaceAfterComma;

fn ok_after_comma(next: Option<u8>) -> bool {
    matches!(
        next,
        Some(b' ') | Some(b'\t') | Some(b'\n') | Some(b'\r') | None
    )
}

fn skip_before_close(next: Option<u8>, skip_rcurly: bool) -> bool {
    matches!(next, Some(b')') | Some(b']') | Some(b'|') | Some(b';'))
        || (skip_rcurly && next == Some(b'}'))
}

fn report_missing(
    cop: &SpaceAfterComma,
    source: &SourceFile,
    at: usize,
    diagnostics: &mut Vec<Diagnostic>,
    corrections: &mut Option<&mut Vec<Correction>>,
) {
    let (line, col) = source.offset_to_line_col(at);
    let mut diag = cop.diagnostic(source, line, col, "Space missing after comma.".to_string());
    if let Some(corr) = corrections.as_deref_mut() {
        corr.push(Correction {
            start: at + 1,
            end: at + 1,
            replacement: " ".into(),
            cop_name: cop.name(),
            cop_index: 0,
        });
        diag.corrected = true;
    }
    diagnostics.push(diag);
}

fn line_continued(bytes: &[u8], i: usize) -> bool {
    bytes.get(i + 1) == Some(&b'\\')
        && matches!(bytes.get(i + 2).copied(), Some(b'\n') | Some(b'\r') | None)
}

fn should_flag(bytes: &[u8], i: usize, code_map: &CodeMap, skip_rcurly: bool) -> bool {
    if bytes[i] != b',' || code_map.covers(i) || (i > 0 && bytes[i - 1] == b'$') {
        return false;
    }
    let next = bytes.get(i + 1).copied();
    if skip_before_close(next, skip_rcurly) || line_continued(bytes, i) {
        return false;
    }
    !ok_after_comma(next)
}

impl Cop for SpaceAfterComma {
    fn name(&self) -> &'static str {
        "Layout/SpaceAfterComma"
    }

    fn supports_autocorrect(&self) -> bool {
        true
    }

    fn uses_source_phase(&self) -> bool {
        true
    }

    fn check_source(
        &self,
        source: &SourceFile,
        _tree: &Tree,
        code_map: &CodeMap,
        config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        mut corrections: Option<&mut Vec<Correction>>,
    ) {
        let skip_rcurly =
            config.get_str("__SpaceInsideHashBracesStyle", "space") == "no_space";
        let bytes = source.as_bytes();
        for i in 0..bytes.len() {
            if should_flag(bytes, i, code_map, skip_rcurly) {
                report_missing(self, source, i, diagnostics, &mut corrections);
            }
        }
    }
}