rho-coding-agent 1.48.0

A lightweight agent harness inspired by Pi
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144

use pretty_assertions::assert_eq;

use super::super::{tests::test_app, App, ComposerMode};

fn app_with_pins(pins: &[&str]) -> App {
    let mut app = test_app();
    // OpenAI models come from a cache these unit tests do not populate.
    // xAI is a static-catalog provider, so a stored key makes pins usable.
    rho_providers::credentials::save_provider_api_key(
        app.credential_store.as_ref(),
        "xai",
        "xai-test",
    )
    .unwrap();
    let pins = pins.iter().map(|pin| pin.to_string()).collect::<Vec<_>>();
    app.info
        .services
        .config_repository
        .update(|config| config.favorite_models = pins.clone())
        .unwrap();
    app.info.runtime.favorite_models = pins;
    app.refresh_available_auths();
    app
}

fn open_model_picker(app: &mut App) {
    let picker = app.conversation_model_picker();
    app.input_ui.set_composer(ComposerMode::Picker(picker));
}

fn picker_title(app: &App) -> String {
    let ComposerMode::Picker(picker) = app.input_ui.composer() else {
        panic!("model picker should be open");
    };
    picker.title.clone()
}

fn picker_values(app: &App) -> Vec<String> {
    let ComposerMode::Picker(picker) = app.input_ui.composer() else {
        panic!("model picker should be open");
    };
    picker.items.iter().map(|item| item.value.clone()).collect()
}

// Covers: the scope toggle must flip the open picker between pinned and all,
// keep the choice for the rest of the session, and refuse to leave the session
// on a pinned view that has nothing to show.
// Owner: model picker scope
#[test]
fn scope_toggle_flips_the_open_picker_and_sticks() {
    let mut app = app_with_pins(&["xai/grok-4.6"]);
    open_model_picker(&mut app);
    assert!(picker_title(&app).contains("pinned"));
    assert_eq!(picker_values(&app), vec!["xai/grok-4.6".to_string()]);

    app.toggle_model_picker_scope().unwrap();
    assert!(picker_title(&app).contains("all"));
    assert!(picker_values(&app).len() > 1);
    assert_eq!(app.status(), "showing all models");

    // The session remembers the choice, so reopening stays on all.
    open_model_picker(&mut app);
    assert!(picker_title(&app).contains("all"));

    app.toggle_model_picker_scope().unwrap();
    assert!(picker_title(&app).contains("pinned"));
    assert_eq!(app.status(), "showing pinned models");
}

// Covers: toggling to pinned with no usable pin must report and leave both the
// picker and the remembered scope untouched, never flip silently.
// Owner: model picker scope
#[test]
fn scope_toggle_refuses_an_empty_pinned_view() {
    let mut app = app_with_pins(&[]);
    open_model_picker(&mut app);
    let before = picker_values(&app);
    assert!(picker_title(&app).contains("all"));

    app.toggle_model_picker_scope().unwrap();

    assert_eq!(app.status(), "no pinned models");
    assert!(picker_title(&app).contains("all"));
    assert_eq!(picker_values(&app), before);
    assert_eq!(app.model_picker_scope_override, None);
}

// Covers: unpinning the last usable pin while the pinned view is open must
// fall back to the catalogue instead of leaving an empty list.
// Owner: model picker scope
#[test]
fn unpinning_the_last_pin_falls_back_to_all() {
    let mut app = app_with_pins(&["xai/grok-4.6"]);
    open_model_picker(&mut app);
    assert!(picker_title(&app).contains("pinned"));

    app.toggle_selected_model_favorite().unwrap();

    assert!(picker_title(&app).contains("all"));
    assert!(picker_values(&app).len() > 1);
    assert!(app.info.runtime.favorite_models.is_empty());
}

// Covers: a rebuild must keep the parent picker so users opened from /config
// still have a way back after pinning or switching scope.
// Owner: model picker scope
#[test]
fn rebuilding_keeps_the_parent_picker() {
    let mut app = app_with_pins(&["xai/grok-4.6"]);
    let parent = crate::tui::provider_picker::login_group_picker();
    let picker = app.conversation_model_picker().with_parent(parent);
    app.input_ui.set_composer(ComposerMode::Picker(picker));

    app.toggle_model_picker_scope().unwrap();

    let ComposerMode::Picker(picker) = app.input_ui.composer() else {
        panic!("model picker should still be open");
    };
    assert!(picker.has_parent(), "scope toggle must keep the parent");
}

// Covers: a session that first opened /model with no usable pin must still
// open on the pinned list once a pin has auth, without the user pressing
// the scope toggle.
// Owner: model picker scope
#[test]
fn first_open_without_pins_promotes_after_a_pin_is_added() {
    let mut app = app_with_pins(&[]);
    open_model_picker(&mut app);
    assert!(picker_title(&app).contains("all"));
    assert_eq!(app.model_picker_scope_override, None);

    app.info
        .services
        .config_repository
        .update(|config| config.favorite_models = vec!["xai/grok-4.6".into()])
        .unwrap();
    app.info.runtime.favorite_models = vec!["xai/grok-4.6".into()];

    open_model_picker(&mut app);
    assert!(picker_title(&app).contains("pinned"));
    assert_eq!(picker_values(&app), vec!["xai/grok-4.6".to_string()]);
    assert_eq!(app.model_picker_scope_override, None);
}